From ff23b1b37b690bd3ea46470e45eee54fda62bf5c Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Mon, 7 Nov 2022 12:42:05 +0100 Subject: [PATCH] renderer: s/format_size/render_size/ format_size is the "lower" level helper and is not fit (anymore) to be set as renderer directly, as its parameter signature may clash with the extra, different ones, that renderers get passed. For example, the useSI param always gets evaluated as true due to the metaData "truthy" value that calls to a renderer get passed along most of the time. Use the render_size instead, a wrapper which only passes along value to format_size. Signed-off-by: Thomas Lamprecht --- js/AttachmentGrid.js | 2 +- js/BackupRestore.js | 2 +- js/PBSSnapshotView.js | 2 +- js/PostfixMailQueue.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js index aea526b..eaac638 100644 --- a/js/AttachmentGrid.js +++ b/js/AttachmentGrid.js @@ -90,7 +90,7 @@ Ext.define('PMG.grid.AttachmentGrid', { }, { text: gettext('Size'), - renderer: Proxmox.Utils.format_size, + renderer: Proxmox.Utils.render_size, dataIndex: 'size', flex: 1, }, diff --git a/js/BackupRestore.js b/js/BackupRestore.js index 21a979f..8f1c4f4 100644 --- a/js/BackupRestore.js +++ b/js/BackupRestore.js @@ -183,7 +183,7 @@ Ext.define('PMG.BackupRestore', { header: gettext('Size'), width: 100, sortable: true, - renderer: Proxmox.Utils.format_size, + renderer: Proxmox.Utils.render_size, dataIndex: 'size', }, { diff --git a/js/PBSSnapshotView.js b/js/PBSSnapshotView.js index c182bfb..9527220 100644 --- a/js/PBSSnapshotView.js +++ b/js/PBSSnapshotView.js @@ -267,7 +267,7 @@ Ext.define('PMG.PBSConfig', { { text: 'Size', dataIndex: 'size', - renderer: Proxmox.Utils.format_size, + renderer: Proxmox.Utils.render_size, flex: 1, }, { diff --git a/js/PostfixMailQueue.js b/js/PostfixMailQueue.js index 94ab186..8b4ee8c 100644 --- a/js/PostfixMailQueue.js +++ b/js/PostfixMailQueue.js @@ -147,7 +147,7 @@ Ext.define('PMG.Postfix.MailQueue', { }, { header: 'Size', - renderer: Proxmox.Utils.format_size, + renderer: Proxmox.Utils.render_size, flex: 1, dataIndex: 'message_size', }, -- 2.39.2