From 4ed79f7b4cd3e77ec9764f6233ce83098ace60d9 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Thu, 11 Nov 2021 10:17:14 +0100 Subject: [PATCH] Revert "dns-challenge: add 'use-proxy' property" a bit to weird of a place to configure this especially as enabling it does not guarantee any proxying if there's none.. This reverts commit e1088f616ffc73a96ee3433f0ea07639ef7513e7. --- src/PVE/ACME/DNSChallenge.pm | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/PVE/ACME/DNSChallenge.pm b/src/PVE/ACME/DNSChallenge.pm index 3e86f8c..7214d88 100644 --- a/src/PVE/ACME/DNSChallenge.pm +++ b/src/PVE/ACME/DNSChallenge.pm @@ -56,12 +56,7 @@ sub properties { optional => 1, minimum => 0, maximum => 2 * 24 * 60 * 60, - }, - 'use-proxy' => { - description => "Flag indicating whether a http proxy should be used.", - type => 'boolean', - optional => 1, - }, + } }; } @@ -72,7 +67,6 @@ sub options { nodes => { optional => 1 }, disable => { optional => 1 }, 'validation-delay' => { optional => 1 }, - 'use-proxy' => { optional => 1 }, }; } @@ -90,7 +84,6 @@ my $proxmox_acme_command = sub { my $txtvalue = PVE::ACME::encode(sha256($key_auth)); my $dnsplugin = $data->{plugin}->{api}; my $plugin_conf_string = $data->{plugin}->{data}; - my $proxy = $data->{plugin}->{proxy}; # for security reasons, we execute the command as nobody # we can't verify that the code of the DNSPlugins are harmless. @@ -106,7 +99,6 @@ my $proxmox_acme_command = sub { } my $input = "$txtvalue\n"; $input .= "$plugin_conf_string\n" if $plugin_conf_string; - $input .= "https_proxy=$proxy\nhttp_proxy=$proxy\n" if $proxy; PVE::Tools::run_command($cmd, input => $input); -- 2.39.2