From bd6d81d468c2d670fceb4bf6ed60805f2d71533b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
Date: Fri, 17 Apr 2020 14:31:49 +0200
Subject: [PATCH] plugins: remove get_subplugins
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

it's unused, and the only plugin that has such functionality already
encodes the possible values as enum in the schema anyway..

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 src/PVE/ACME.pm              | 21 ---------------------
 src/PVE/ACME/Challenge.pm    |  4 ----
 src/PVE/ACME/DNSChallenge.pm |  4 ----
 src/PVE/ACME/StandAlone.pm   |  4 ----
 4 files changed, 33 deletions(-)

diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm
index 4a05024..c5b8d66 100644
--- a/src/PVE/ACME.pm
+++ b/src/PVE/ACME.pm
@@ -493,27 +493,6 @@ sub request_challenge_validation {
     return $return;
 }
 
-# return all availible subplugins from the plugins
-sub get_subplugins {
-
-    my $tmp = [];
-    my $plugins = PVE::ACME::Challenge->lookup_types();
-
-    foreach my $plugin_name (@$plugins) {
-	my $plugin = PVE::ACME::Challenge->lookup($plugin_name);
-	push @$tmp, $plugin->get_subplugins();
-    }
-
-    my $subplugins = [];
-    foreach my $array (@$tmp) {
-	foreach my $subplugin ( @$array) {
-	    push @$subplugins, $subplugin;
-	}
-    }
-
-    return $subplugins;
-}
-
 # actually 'do' a $method request on $url
 # $data: input for JWS, optional
 # $use_jwk: use JWK instead of KID in JWD (see sub jws)
diff --git a/src/PVE/ACME/Challenge.pm b/src/PVE/ACME/Challenge.pm
index 5fb9cbe..16d75ad 100644
--- a/src/PVE/ACME/Challenge.pm
+++ b/src/PVE/ACME/Challenge.pm
@@ -70,10 +70,6 @@ sub extract_challenge {
     die "plugin does not support any of the requested challenge types\n";
 }
 
-sub get_subplugins {
-    return [];
-}
-
 # acme => PVE::ACME instance
 # auth => authorization object returned by ACME server
 # $data => {
diff --git a/src/PVE/ACME/DNSChallenge.pm b/src/PVE/ACME/DNSChallenge.pm
index 7f7f125..8e61c25 100644
--- a/src/PVE/ACME/DNSChallenge.pm
+++ b/src/PVE/ACME/DNSChallenge.pm
@@ -143,10 +143,6 @@ sub options {
     };
 }
 
-sub get_subplugins {
-    return $api_name_list;
-}
-
 my $proxmox_acme_command = sub {
     my ($self, $acme, $auth, $data, $action) = @_;
 
diff --git a/src/PVE/ACME/StandAlone.pm b/src/PVE/ACME/StandAlone.pm
index 6a6f05a..0e2ece6 100644
--- a/src/PVE/ACME/StandAlone.pm
+++ b/src/PVE/ACME/StandAlone.pm
@@ -27,10 +27,6 @@ sub options {
     };
 }
 
-sub get_subplugins {
-    return [];
-}
-
 sub setup {
     my ($self, $acme, $auth, $data) = @_;
 
-- 
2.39.2