form: combo grid: fix selection after filtering

firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers
too often, for example when selecting an entry (since the field lost
focus). This lead to the picker refreshing and not registering the
click and thus not selecting the desired entry.

Instead refresh the view when we really need it: when the picker is shown.
The filter is already gone, but the picker grid does not know this yet,
so we fire the event then.

Fixes: 7e47328 ("Combogrid: clear filter on blur")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
index 3ee023863fd3c32f86ac73d5cd4b99306a46e9e4..4cb79d0778cf8f0a8d761c2ee2a4c48e97c2dca4 100644 (file)
--- a/src/form/ComboGrid.js
+++ b/src/form/ComboGrid.js
@@ -300,6 +300,7 @@ Ext.define('Proxmox.form.ComboGrid', {
        //
        // we save the minheight to reset it after the load
        picker.on('show', function() {
+           me.store.fireEvent('refresh');
            if (me.enableLoadMask) {
                me.savedMinHeight = picker.getMinHeight();
                picker.setMinHeight(100);
@@ -324,7 +325,6 @@ Ext.define('Proxmox.form.ComboGrid', {
            me.store.removeFilter(me.queryFilter, true);
            me.queryFilter = null;
            me.changingFilters = false;
-           me.store.fireEvent('refresh');
        }
     },