code cleanups, inline more, use arrow-fns

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/src/button/Button.js b/src/button/Button.js
index 93c773cbbc029201b15fb85e392a518cdbb3e3c0..1f53869601664254fbbe2c9ec5feed3facf221f0 100644 (file)
--- a/src/button/Button.js
+++ b/src/button/Button.js
@@ -152,9 +152,7 @@ Ext.define('Proxmox.button.StdRemoveButton', {
            callback: function(options, success, response) {
                Ext.callback(me.callback, me.scope, [options, success, response], 0, me);
            },
-           failure: function(response, opts) {
-               Ext.Msg.alert(gettext('Error'), response.htmlStatus);
-           },
+           failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
        });
     },
     initComponent: function() {

diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index 2e83130288b685f92c7873816a19f701204717a8..da47fba50ae700370c765f1800a4dd8179da0e2d 100644 (file)
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -40,7 +40,7 @@ Ext.define('Proxmox.node.NetworkView', {
            throw "no node name specified";
        }
 
-       let baseUrl = '/nodes/' + me.nodename + '/network';
+       let baseUrl = `/nodes/${me.nodename}/network`;
 
        let store = Ext.create('Ext.data.Store', {
            model: 'proxmox-networks',
@@ -173,19 +173,6 @@ Ext.define('Proxmox.node.NetworkView', {
            del_btn.setDisabled(!rec);
        };
 
-       let render_ports = function(value, metaData, record) {
-           if (value === 'bridge') {
-               return record.data.bridge_ports;
-           } else if (value === 'bond') {
-               return record.data.slaves;
-           } else if (value === 'OVSBridge') {
-               return record.data.ovs_ports;
-           } else if (value === 'OVSBond') {
-               return record.data.ovs_bonds;
-           }
-           return '';
-       };
-
        let find_next_iface_id = function(prefix) {
            let next;
            for (next = 0; next <= 9999; next++) {
@@ -389,7 +376,18 @@ Ext.define('Proxmox.node.NetworkView', {
                        {
                            header: gettext('Ports/Slaves'),
                            dataIndex: 'type',
-                           renderer: render_ports,
+                           renderer: (value, metaData, { data }) => {
+                               if (value === 'bridge') {
+                                   return data.bridge_ports;
+                               } else if (value === 'bond') {
+                                   return data.slaves;
+                               } else if (value === 'OVSBridge') {
+                                   return data.ovs_ports;
+                               } else if (value === 'OVSBond') {
+                                   return data.ovs_bonds;
+                               }
+                               return '';
+                           },
                        },
                        {
                            header: gettext('Bond Mode'),