From: Dominik Csapak <d.csapak@proxmox.com>
Date: Mon, 28 Mar 2022 13:53:45 +0000 (+0200)
Subject: form: combo grid: fix selection after filtering
X-Git-Url: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff_plain;h=01a79a97814756d4d7c57efc1f88f1bf3eb8bf9d

form: combo grid: fix selection after filtering

firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers
too often, for example when selecting an entry (since the field lost
focus). This lead to the picker refreshing and not registering the
click and thus not selecting the desired entry.

Instead refresh the view when we really need it: when the picker is shown.
The filter is already gone, but the picker grid does not know this yet,
so we fire the event then.

Fixes: 7e47328 ("Combogrid: clear filter on blur")

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
index 3ee0238..4cb79d0 100644
--- a/src/form/ComboGrid.js
+++ b/src/form/ComboGrid.js
@@ -300,6 +300,7 @@ Ext.define('Proxmox.form.ComboGrid', {
 	//
 	// we save the minheight to reset it after the load
 	picker.on('show', function() {
+	    me.store.fireEvent('refresh');
 	    if (me.enableLoadMask) {
 		me.savedMinHeight = picker.getMinHeight();
 		picker.setMinHeight(100);
@@ -324,7 +325,6 @@ Ext.define('Proxmox.form.ComboGrid', {
 	    me.store.removeFilter(me.queryFilter, true);
 	    me.queryFilter = null;
 	    me.changingFilters = false;
-	    me.store.fireEvent('refresh');
 	}
     },