From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Thu, 22 Apr 2021 10:47:54 +0000 (+0200)
Subject: safe destroy: code/readability cleanup
X-Git-Url: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff_plain;h=f2d18cd7b37eb0d3ed9110d02617c5757e1e9112

safe destroy: code/readability cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index 72e7e19..4e9323a 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -137,7 +137,9 @@ Ext.define('Proxmox.window.SafeDestroy', {
 			hideTrigger: true,
 			allowBlank: false,
 		    },
-		].concat(me.additionalItems).concat([
+		]
+		.concat(me.additionalItems)
+		.concat([
 		    {
 			xtype: 'container',
 			reference: 'noteContainer',
@@ -163,33 +165,28 @@ Ext.define('Proxmox.window.SafeDestroy', {
 
 	me.callParent();
 
-	const item = me.getItem();
-
-	if (!Ext.isDefined(item.id)) {
+	const itemId = me.getItem().id;
+	if (!Ext.isDefined(itemId)) {
 	    throw "no ID specified";
 	}
 
-	const messageCmp = me.lookupReference('messageCmp');
-	const noteCmp = me.lookupReference('noteCmp');
-	let msg;
-
 	if (Ext.isDefined(me.getNote())) {
-	    noteCmp.setHtml(`<span title="${me.getNote()}">${me.getNote()}</span>`);
+	    me.lookupReference('noteCmp').setHtml(`<span title="${me.getNote()}">${me.getNote()}</span>`);
 	    const noteContainer = me.lookupReference('noteContainer');
 	    noteContainer.setHidden(false);
 	    noteContainer.setDisabled(false);
 	}
 
-	if (Ext.isDefined(me.getTaskName())) {
-	    msg = Proxmox.Utils.format_task_description(me.getTaskName(), item.id);
-	    messageCmp.setHtml(msg);
+	let taskName = me.getTaskName();
+	if (Ext.isDefined(taskName)) {
+	    me.lookupReference('messageCmp').setHtml(
+		Proxmox.Utils.format_task_description(taskName, itemId),
+	    );
 	} else {
 	    throw "no task name specified";
 	}
 
-	const confirmField = me.lookupReference('confirmField');
-	msg = gettext('Please enter the ID to confirm') +
-	    ' (' + item.id + ')';
-	confirmField.setFieldLabel(msg);
+	me.lookupReference('confirmField')
+	    .setFieldLabel(`${gettext('Please enter the ID to confirm')} (${itemId})`);
     },
 });