From 4fedb4e28d2da5cfbf244e72da4e4149a6a60554 Mon Sep 17 00:00:00 2001 From: Friedrich Weber Date: Fri, 24 Mar 2023 10:02:30 +0100 Subject: [PATCH] fix #4612: mobile: avoid crash due to missing getProxy method A previous commit (51083ee) added an override of the internal ExtJS method `Ext.data.Store.onProxyLoad` in order to fix a race condition. This override calls `Operation.getProxy`. However, this method is not available on Sencha Touch. As a consequence, the mobile UI was broken. This commit modifies the override such that it has no effect in the mobile UI. Fixes: 51083ee54aa98af5a711622e4ed240840dcbbabe Suggested-by: Dominik Csapak Signed-off-by: Friedrich Weber Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- src/Utils.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index 34c348f..ef72630 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -1483,10 +1483,11 @@ Ext.override(Ext.data.Store, { // If the store's proxy is changed while it is waiting for an AJAX // response, `onProxyLoad` will still be called for the outdated response. // To avoid displaying inconsistent information, only process responses - // belonging to the current proxy. + // belonging to the current proxy. However, do not apply this workaround + // to the mobile UI, as Sencha Touch has an incompatible internal API. onProxyLoad: function(operation) { let me = this; - if (operation.getProxy() === me.getProxy()) { + if (Proxmox.Utils.toolkit === 'touch' || operation.getProxy() === me.getProxy()) { me.callParent(arguments); } else { console.log(`ignored outdated response: ${operation.getRequest().getUrl()}`); -- 2.39.2