From 80ea69b416986455622821a4e8c6b74c19ca9362 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Thu, 3 Mar 2022 15:11:45 +0100 Subject: [PATCH 1/1] fix #3919: log view: show first task output line correctly if a task did not produce output yet, we always get a single line with "no output". our heuristic in the gui counts the total lines + the current position. so to update the first output correctly, we have to update every time in case we only have one line. Otherwise, we only update on the second line, which is bad in case the only line we ever get is the result. Signed-off-by: Dominik Csapak --- src/panel/LogView.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/panel/LogView.js b/src/panel/LogView.js index 22029a1..412b26e 100644 --- a/src/panel/LogView.js +++ b/src/panel/LogView.js @@ -53,7 +53,12 @@ Ext.define('Proxmox.panel.LogView', { let data = viewModel.get('data'); if (first === data.first && total === data.total && lines.length === data.lines) { - return; // same content, skip setting and scrolling + // before there is any real output, we get 'no output' as a single line. + // so always update if we only have one to be sure to catch + // the first real line of output + if (total !== 1) { + return; // same content, skip setting and scrolling + } } viewModel.set('data', { first: first, -- 2.39.2