From ce8c5365c214b9ac4b464cac67d3eaa4a69225cc Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Wed, 12 Jun 2019 11:46:20 +0200 Subject: [PATCH] followup: network selector: reorder columns and adapt widths and use format_boolean to render the active column also hide the type column by default, it often is not too important, and can be derived from the interface name, e.g., vmbrX -> bridge, bondX -> bond, etc. Signed-off-by: Thomas Lamprecht --- form/NetworkSelector.js | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/form/NetworkSelector.js b/form/NetworkSelector.js index e6824b6..2a94bbd 100644 --- a/form/NetworkSelector.js +++ b/form/NetworkSelector.js @@ -94,36 +94,33 @@ Ext.define('Proxmox.form.NetworkSelector', { listConfig: { width: 600, columns: [ + { + + header: gettext('CIDR'), + dataIndex: 'cidr', + hideable: false, + flex: 1 + }, { header: gettext('Interface'), - sortable: true, - flex:1, + width: 90, dataIndex: 'iface' }, { header: gettext('Active'), - sortable: true, - flex:1, + renderer: Proxmox.Utils.format_boolean, + width: 60, dataIndex: 'active' }, - { - - header: gettext('CIDR'), - dataIndex: 'cidr', - sortable: true, - hideable: false, - flex:1 - }, { header: gettext('Type'), - sortable: true, - flex:1, + width: 80, + hidden: true, dataIndex: 'type' }, { header: gettext('Comment'), - sortable: true, - flex:1, + flex: 2, dataIndex: 'comments' } ] -- 2.39.2