]>
git.proxmox.com Git - pve-access-control.git/blob - PVE/RPCEnvironment.pm
b1ed897b5bc48394b5edd4e04d80af7906486f3d
1 package PVE
::RPCEnvironment
;
5 use POSIX
qw(:sys_wait_h EINTR);
10 use PVE
::Exception
qw(raise raise_perm_exc);
16 use PVE
::AccessControl
;
18 # we use this singleton class to pass RPC related environment values
22 # save $SIG{CHLD} handler implementation.
23 # simply set $SIG{CHLD} = $worker_reaper;
24 # and register forked processes with &$register_worker(pid)
25 # Note: using $SIG{CHLD} = 'IGNORE' or $SIG{CHLD} = sub { wait (); } or ...
26 # has serious side effects, because perls built in system() and open()
27 # functions can't get the correct exit status of a child. So we cant use
28 # that (also see perlipc)
33 my $log_task_result = sub {
34 my ($upid, $user, $status) = @_;
36 my $msg = 'successful';
39 my $ec = $status >> 8;
40 my $ic = $status & 255;
41 $msg = $ec ?
"failed ($ec)" : "interrupted ($ic)";
44 my $tlist = active_workers
($upid);
45 PVE
::Cluster
::broadcast_tasklist
($tlist);
47 foreach my $t (@$tlist) {
48 if ($t->{upid
} eq $upid) {
53 if ($task && $task->{status
}) {
54 $msg = $task->{status
};
56 PVE
::Cluster
::log_msg
($pri, $user, "end task $upid $msg");
59 my $worker_reaper = sub {
61 foreach my $pid (keys %$WORKER_PIDS) {
62 my $waitpid = waitpid ($pid, WNOHANG
);
63 if (defined($waitpid) && ($waitpid == $pid)) {
64 my $info = $WORKER_PIDS->{$pid};
65 if ($info && $info->{upid
} && $info->{user
}) {
66 &$log_task_result($info->{upid
}, $info->{user
}, $?);
68 delete ($WORKER_PIDS->{$pid});
73 my $register_worker = sub {
74 my ($pid, $user, $upid) = @_;
78 # do not register if already finished
79 my $waitpid = waitpid ($pid, WNOHANG
);
80 if (defined($waitpid) && ($waitpid == $pid)) {
81 delete ($WORKER_PIDS->{$pid});
85 $WORKER_PIDS->{$pid} = {
93 my $compile_acl_path = sub {
94 my ($self, $user, $path) = @_;
96 my $cfg = $self->{user_cfg
};
98 return undef if !$cfg->{roles
};
100 die "internal error" if $user eq 'root@pam';
102 my $cache = $self->{aclcache
};
103 $cache->{$user} = {} if !$cache->{$user};
104 my $data = $cache->{$user};
106 if (!$data->{poolroles
}) {
107 $data->{poolroles
} = {};
109 foreach my $pool (keys %{$cfg->{pools
}}) {
110 my $d = $cfg->{pools
}->{$pool};
111 my @ra = PVE
::AccessControl
::roles
($cfg, $user, "/pool/$pool"); # pool roles
112 next if !scalar(@ra);
113 foreach my $vmid (keys %{$d->{vms
}}) {
115 $data->{poolroles
}->{"/vms/$vmid"}->{$role} = 1;
118 foreach my $storeid (keys %{$d->{storage
}}) {
120 $data->{poolroles
}->{"/storage/$storeid"}->{$role} = 1;
126 my @ra = PVE
::AccessControl
::roles
($cfg, $user, $path);
128 # apply roles inherited from pools
129 # Note: assume we do not want to propagate those privs
130 if ($data->{poolroles
}->{$path}) {
131 if (!($ra[0] && $ra[0] eq 'NoAccess')) {
132 if ($data->{poolroles
}->{$path}->{NoAccess
}) {
135 foreach my $role (keys %{$data->{poolroles
}->{$path}}) {
142 $data->{roles
}->{$path} = [ @ra ];
145 foreach my $role (@ra) {
146 if (my $privset = $cfg->{roles
}->{$role}) {
147 foreach my $p (keys %$privset) {
152 $data->{privs
}->{$path} = $privs;
158 my ($self, $user, $path) = @_;
160 if ($user eq 'root@pam') { # root can do anything
161 return ('Administrator');
164 $user = PVE
::AccessControl
::verify_username
($user, 1);
167 my $cache = $self->{aclcache
};
168 $cache->{$user} = {} if !$cache->{$user};
170 my $acl = $cache->{$user};
172 my $roles = $acl->{roles
}->{$path};
173 return @$roles if $roles;
175 &$compile_acl_path($self, $user, $path);
176 $roles = $acl->{roles
}->{$path} || [];
181 my ($self, $user, $path) = @_;
183 if ($user eq 'root@pam') { # root can do anything
184 my $cfg = $self->{user_cfg
};
185 return $cfg->{roles
}->{'Administrator'};
188 $user = PVE
::AccessControl
::verify_username
($user, 1);
191 my $cache = $self->{aclcache
};
192 $cache->{$user} = {} if !$cache->{$user};
194 my $acl = $cache->{$user};
196 my $perm = $acl->{privs
}->{$path};
197 return $perm if $perm;
199 return &$compile_acl_path($self, $user, $path);
203 my ($self, $user, $path, $privs, $noerr) = @_;
205 my $perm = $self->permissions($user, $path);
207 foreach my $priv (@$privs) {
208 PVE
::AccessControl
::verify_privname
($priv);
209 if (!$perm->{$priv}) {
210 return undef if $noerr;
211 raise_perm_exc
("$path, $priv");
219 my ($self, $user, $path, $privs, $noerr) = @_;
221 my $perm = $self->permissions($user, $path);
224 foreach my $priv (@$privs) {
225 PVE
::AccessControl
::verify_privname
($priv);
226 if ($perm->{$priv}) {
234 return undef if $noerr;
236 raise_perm_exc
("$path, " . join("|", @$privs));
240 my ($self, $username, $path, $privs, $any, $noerr) = @_;
242 return $self->check_any($username, $path, $privs, $noerr);
244 return $self->check($username, $path, $privs, $noerr);
248 sub check_user_enabled
{
249 my ($self, $user, $noerr) = @_;
251 my $cfg = $self->{user_cfg
};
252 return PVE
::AccessControl
::check_user_enabled
($cfg, $user, $noerr);
255 sub check_user_exist
{
256 my ($self, $user, $noerr) = @_;
258 my $cfg = $self->{user_cfg
};
259 return PVE
::AccessControl
::check_user_exist
($cfg, $user, $noerr);
262 sub check_pool_exist
{
263 my ($self, $pool, $noerr) = @_;
265 my $cfg = $self->{user_cfg
};
267 return 1 if $cfg->{pools
}->{$pool};
269 return undef if $noerr;
271 raise_perm_exc
("pool '$pool' does not exist");
275 my ($self, $user, $vmid, $pool, $privs, $any, $noerr) = @_;
277 my $cfg = $self->{user_cfg
};
280 return if $self->check_full($user, "/pool/$pool", $privs, $any, 1);
282 return $self->check_full($user, "/vms/$vmid", $privs, $any, $noerr);
285 sub check_volume_access
{
286 my ($self, $user, $storecfg, $vmid, $volid) = @_;
288 # test if we have read access to volid
290 my ($sid, $volname) = PVE
::Storage
::parse_volume_id
($volid, 1);
292 my ($vtype, undef, $ownervm) = PVE
::Storage
::parse_volname
($storecfg, $volid);
293 if ($vtype eq 'iso' || $vtype eq 'vztmpl') {
294 # we simply allow access
295 } elsif (defined($ownervm) && defined($vmid) && ($ownervm == $vmid)) {
296 # we are owner - allow access
297 } elsif ($vtype eq 'backup' && $ownervm) {
298 $self->check($user, "/storage/$sid", ['Datastore.AllocateSpace']);
299 $self->check($user, "/vms/$ownervm", ['VM.Backup']);
301 # allow if we are Datastore administrator
302 $self->check($user, "/storage/$sid", ['Datastore.Allocate']);
305 die "Only root can pass arbitrary filesystem paths."
306 if $user ne 'root@pam';
312 sub is_group_member
{
313 my ($self, $group, $user) = @_;
315 my $cfg = $self->{user_cfg
};
317 return 0 if !$cfg->{groups
}->{$group};
319 return defined($cfg->{groups
}->{$group}->{users
}->{$user});
323 my ($self, $user, $privs, $any) = @_;
325 my $cfg = $self->{user_cfg
};
328 foreach my $group (keys %{$cfg->{groups
}}) {
329 my $path = "/access/groups/$group";
330 if ($self->check_full($user, $path, $privs, $any, 1)) {
331 $groups->{$group} = $cfg->{groups
}->{$group};
338 sub group_member_join
{
339 my ($self, $grouplist) = @_;
343 my $cfg = $self->{user_cfg
};
344 foreach my $group (@$grouplist) {
345 my $data = $cfg->{groups
}->{$group};
347 foreach my $user (keys %{$data->{users
}}) {
355 sub check_perm_modify
{
356 my ($self, $username, $path, $noerr) = @_;
358 return $self->check($username, '/access', [ 'Permissions.Modify' ], $noerr) if !$path;
360 my $testperms = [ 'Permissions.Modify' ];
361 if ($path =~ m
|^/storage/.+$|) {
362 push @$testperms, 'Datastore.Allocate';
363 } elsif ($path =~ m
|^/vms/.+$|) {
364 push @$testperms, 'VM.Allocate';
365 } elsif ($path =~ m
|^/pool/.+$|) {
366 push @$testperms, 'Pool.Allocate';
369 return $self->check_any($username, $path, $testperms, $noerr);
372 sub exec_api2_perm_check
{
373 my ($self, $check, $username, $param, $noerr) = @_;
375 # syslog("info", "CHECK " . join(', ', @$check));
378 my $test = $check->[$ind++];
379 die "no permission test specified" if !$test;
381 if ($test eq 'and') {
382 while (my $subcheck = $check->[$ind++]) {
383 $self->exec_api2_perm_check($subcheck, $username, $param);
386 } elsif ($test eq 'or') {
387 while (my $subcheck = $check->[$ind++]) {
388 return 1 if $self->exec_api2_perm_check($subcheck, $username, $param, 1);
392 } elsif ($test eq 'perm') {
393 my ($t, $tmplpath, $privs, %options) = @$check;
394 my $any = $options{any
};
395 die "missing parameters" if !($tmplpath && $privs);
396 my $require_param = $options{require_param
};
397 if ($require_param && !defined($param->{$require_param})) {
401 my $path = PVE
::Tools
::template_replace
($tmplpath, $param);
402 $path = PVE
::AccessControl
::normalize_path
($path);
403 return $self->check_full($username, $path, $privs, $any, $noerr);
404 } elsif ($test eq 'userid-group') {
405 my $userid = $param->{userid
};
406 my ($t, $privs, %options) = @$check;
407 return 0 if !$options{groups_param
} && !$self->check_user_exist($userid, $noerr);
408 if (!$self->check_any($username, "/access/groups", $privs, 1)) {
409 my $groups = $self->filter_groups($username, $privs, 1);
410 if ($options{groups_param
}) {
411 my @group_param = PVE
::Tools
::split_list
($param->{groups
});
412 raise_perm_exc
("/access/groups, " . join("|", @$privs)) if !scalar(@group_param);
413 foreach my $pg (@group_param) {
414 raise_perm_exc
("/access/groups/$pg, " . join("|", @$privs))
418 my $allowed_users = $self->group_member_join([keys %$groups]);
419 if (!$allowed_users->{$userid}) {
426 } elsif ($test eq 'userid-param') {
427 my ($userid, undef, $realm) = PVE
::AccessControl
::verify_username
($param->{userid
});
428 my ($t, $subtest) = @$check;
429 die "missing parameters" if !$subtest;
430 if ($subtest eq 'self') {
431 return 0 if !$self->check_user_exist($userid, $noerr);
432 return 1 if $username eq $userid;
435 } elsif ($subtest eq 'Realm.AllocateUser') {
436 my $path = "/access/realm/$realm";
437 return $self->check($username, $path, ['Realm.AllocateUser'], $noerr);
439 die "unknown userid-param test";
441 } elsif ($test eq 'perm-modify') {
442 my ($t, $tmplpath) = @$check;
443 my $path = PVE
::Tools
::template_replace
($tmplpath, $param);
444 $path = PVE
::AccessControl
::normalize_path
($path);
445 return $self->check_perm_modify($username, $path, $noerr);
447 die "unknown permission test";
451 sub check_api2_permissions
{
452 my ($self, $perm, $username, $param) = @_;
454 return 1 if !$username && $perm->{user
} eq 'world';
456 raise_perm_exc
("user != null") if !$username;
458 return 1 if $username eq 'root@pam';
460 raise_perm_exc
('user != root@pam') if !$perm;
462 return 1 if $perm->{user
} && $perm->{user
} eq 'all';
464 return $self->exec_api2_perm_check($perm->{check
}, $username, $param)
470 # initialize environment - must be called once at program startup
472 my ($class, $type, %params) = @_;
474 $class = ref($class) || $class;
476 die "already initialized" if $pve_env;
478 die "unknown environment type" if !$type || $type !~ m/^(cli|pub|priv|ha)$/;
480 $SIG{CHLD
} = $worker_reaper;
483 # cli ... command started fron command line
484 # pub ... access from public server (apache)
485 # priv ... access from private server (pvedaemon)
486 # ha ... access from HA resource manager agent (rgmanager)
497 foreach my $p (keys %params) {
498 if ($p eq 'atfork') {
499 $self->{$p} = $params{$p};
501 die "unknown option '$p'";
507 my ($sysname, $nodename) = POSIX
::uname
();
509 $nodename =~ s/\..*$//; # strip domain part, if any
511 $self->{nodename
} = $nodename;
516 # convenience function for command line tools
517 sub setup_default_cli_env
{
518 my ($class, $username) = @_;
520 $class = ref($class) || $class;
522 $username //= 'root@pam';
524 PVE
::INotify
::inotify_init
();
526 my $rpcenv = $class->init('cli');
527 $rpcenv->init_request();
528 $rpcenv->set_language($ENV{LANG
});
529 $rpcenv->set_user($username);
531 die "please run as root\n"
532 if ($username eq 'root@pam') && ($> != 0);
538 die "not initialized" if !$pve_env;
543 # init_request - must be called before each RPC request
545 my ($self, %params) = @_;
547 PVE
::Cluster
::cfs_update
();
549 $self->{result_attributes
} = {};
551 my $userconfig; # we use this for regression tests
552 foreach my $p (keys %params) {
553 if ($p eq 'userconfig') {
554 $userconfig = $params{$p};
556 die "unknown parameter '$p'";
561 $self->{aclcache
} = {};
563 my $ucdata = PVE
::Tools
::file_get_contents
($userconfig);
564 my $cfg = PVE
::AccessControl
::parse_user_config
($userconfig, $ucdata);
565 $self->{user_cfg
} = $cfg;
568 my $ucvers = PVE
::Cluster
::cfs_file_version
('user.cfg');
569 if (!$self->{aclcache
} || !defined($self->{aclversion
}) ||
570 !defined($ucvers) || ($ucvers ne $self->{aclversion
})) {
571 $self->{aclversion
} = $ucvers;
572 my $cfg = PVE
::Cluster
::cfs_read_file
('user.cfg');
573 $self->{user_cfg
} = $cfg;
578 $self->{user_cfg
} = {};
579 die "Unable to load access control list: $err";
584 my ($self, $ip) = @_;
586 $self->{client_ip
} = $ip;
592 return $self->{client_ip
};
595 sub set_result_attrib
{
596 my ($self, $key, $value) = @_;
598 $self->{result_attributes
}->{$key} = $value;
601 sub get_result_attrib
{
602 my ($self, $key) = @_;
604 return $self->{result_attributes
}->{$key};
608 my ($self, $lang) = @_;
610 # fixme: initialize I18N
612 $self->{language
} = $lang;
618 return $self->{language
};
622 my ($self, $user) = @_;
626 $self->{user
} = $user;
632 die "user name not set\n" if !$self->{user
};
634 return $self->{user
};
641 # read/update list of active workers
642 # we move all finished tasks to the archive index,
643 # but keep aktive and most recent task in the active file.
644 # $nocheck ... consider $new_upid still running (avoid that
645 # we try to read the reult to early.
647 my ($new_upid, $nocheck) = @_;
649 my $lkfn = "/var/log/pve/tasks/.active.lock";
655 my $tasklist = PVE
::INotify
::read_file
('active');
659 my $thash = {}; # only list task once
661 my $check_task = sub {
662 my ($task, $running) = @_;
664 if ($running || PVE
::ProcFSTools
::check_process_running
($task->{pid
}, $task->{pstart
})) {
670 delete $task->{pstart
};
673 foreach my $task (@$tasklist) {
674 my $upid = $task->{upid
};
675 next if $thash->{$upid};
676 $thash->{$upid} = $task;
680 if ($new_upid && !(my $task = $thash->{$new_upid})) {
681 $task = PVE
::Tools
::upid_decode
($new_upid);
682 $task->{upid
} = $new_upid;
683 $thash->{$new_upid} = $task;
684 &$check_task($task, $nocheck);
688 @ta = sort { $b->{starttime
} cmp $a->{starttime
} } @ta;
690 my $save = defined($new_upid);
692 foreach my $task (@ta) {
693 next if $task->{endtime
};
694 $task->{endtime
} = time();
695 $task->{status
} = PVE
::Tools
::upid_read_status
($task->{upid
});
701 foreach my $task (@ta) {
702 if (!$task->{saved
}) {
703 $archive .= sprintf("%s %08X %s\n", $task->{upid
}, $task->{endtime
}, $task->{status
});
712 my $filename = "/var/log/pve/tasks/index";
714 my $fh = IO
::File-
>new($filename, '>>', 0644) ||
715 die "unable to open file '$filename' - $!\n";
716 PVE
::Tools
::safe_print
($filename, $fh, $archive);
719 die "unable to close file '$filename' - $!\n";
724 foreach my $task (@arlist) { # mark as not saved
728 my $maxsize = 50000; # about 1000 entries
729 if ($size > $maxsize) {
730 rename($filename, "$filename.1");
734 # we try to reduce the amount of data
735 # list all running tasks and task and a few others
736 # try to limit to 25 tasks
738 my $max = 25 - scalar(@$tlist);
739 foreach my $task (@ta) {
745 PVE
::INotify
::write_file
('active', $tlist) if $save;
750 my $res = PVE
::Tools
::lock_file
($lkfn, $timeout, $code);
756 my $kill_process_group = sub {
757 my ($pid, $pstart) = @_;
759 # send kill to process group (negative pid)
762 # always send signal to all pgrp members
763 kill(15, $kpid); # send TERM signal
765 # give max 5 seconds to shut down
766 for (my $i = 0; $i < 5; $i++) {
767 return if !PVE
::ProcFSTools
::check_process_running
($pid, $pstart);
776 my ($upid, $killit) = @_;
778 my $task = PVE
::Tools
::upid_decode
($upid);
780 my $running = PVE
::ProcFSTools
::check_process_running
($task->{pid
}, $task->{pstart
});
782 return 0 if !$running;
785 &$kill_process_group($task->{pid
});
792 # start long running workers
793 # STDIN is redirected to /dev/null
794 # STDOUT,STDERR are redirected to the filename returned by upid_decode
795 # NOTE: we simulate running in foreground if ($self->{type} eq 'cli')
797 my ($self, $dtype, $id, $user, $function, $background) = @_;
799 $dtype = 'unknown' if !defined ($dtype);
800 $id = '' if !defined ($id);
802 $user = 'root@pve' if !defined ($user);
804 my $sync = ($self->{type
} eq 'cli' && !$background) ?
1 : 0;
809 local $SIG{TERM
} = 'IGNORE';
811 my $starttime = time ();
813 my @psync = POSIX
::pipe();
814 my @csync = POSIX
::pipe();
816 my $node = $self->{nodename
};
819 die "unable to fork worker - $!" if !defined($cpid);
821 my $workerpuid = $cpid ?
$cpid : $$;
823 my $pstart = PVE
::ProcFSTools
::read_proc_starttime
($workerpuid) ||
824 die "unable to read process start time";
826 my $upid = PVE
::Tools
::upid_encode
({
827 node
=> $node, pid
=> $workerpuid, pstart
=> $pstart,
828 starttime
=> $starttime, type
=> $dtype, id
=> $id, user
=> $user });
832 if (!$cpid) { # child
837 $SIG{INT
} = $SIG{QUIT
} = $SIG{TERM
} = sub { die "received interrupt\n"; };
839 $SIG{CHLD
} = $SIG{PIPE
} = 'DEFAULT';
841 # set sess/process group - we want to be able to kill the
842 # whole process group
845 POSIX
::close ($psync[0]);
846 POSIX
::close ($csync[1]);
848 $outfh = $sync ?
$psync[1] : undef;
851 PVE
::INotify
::inotify_close
();
853 if (my $atfork = $self->{atfork
}) {
857 # same algorythm as used inside SA
859 my $fd = fileno (STDIN
);
863 POSIX
::close(0) if $fd != 0;
865 die "unable to redirect STDIN - $!"
866 if !open(STDIN
, "</dev/null");
868 $outfh = PVE
::Tools
::upid_open
($upid);
873 $fd = fileno(STDOUT
);
875 POSIX
::close (1) if $fd != 1;
877 die "unable to redirect STDOUT - $!"
878 if !open(STDOUT
, ">&", $outfh);
880 STDOUT-
>autoflush (1);
882 # redirect STDERR to STDOUT
883 $fd = fileno (STDERR
);
885 POSIX
::close(2) if $fd != 2;
887 die "unable to redirect STDERR - $!"
888 if !open(STDERR
, ">&1");
890 STDERR-
>autoflush(1);
893 my $msg = "ERROR: $err";
894 POSIX
::write($psync[1], $msg, length ($msg));
895 POSIX
::close($psync[1]);
900 # sync with parent (signal that we are ready)
904 POSIX
::write($psync[1], $upid, length ($upid));
905 POSIX
::close($psync[1]);
909 # sync with parent (wait until parent is ready)
910 POSIX
::read($csync[0], $readbuf, 4096);
911 die "parent setup error\n" if $readbuf ne 'OK';
913 if ($self->{type
} eq 'ha') {
914 print "task started by HA resource agent\n";
916 eval { &$function($upid); };
922 print STDERR
"TASK ERROR: $err\n";
925 print STDERR
"TASK OK\n";
933 POSIX
::close ($psync[1]);
934 POSIX
::close ($csync[0]);
937 # sync with child (wait until child starts)
938 POSIX
::read($psync[0], $readbuf, 4096);
941 POSIX
::close($psync[0]);
942 &$register_worker($cpid, $user, $upid);
948 die "got no worker upid - start worker failed\n" if !$readbuf;
950 if ($readbuf =~ m/^ERROR:\s*(.+)$/m) {
951 die "starting worker failed: $1\n";
954 if ($readbuf ne $upid) {
955 die "got strange worker upid ('$readbuf' != '$upid') - start worker failed\n";
959 $outfh = PVE
::Tools
::upid_open
($upid);
966 POSIX
::write($csync[1], $msg, length ($msg));
967 POSIX
::close($csync[1]);
970 POSIX
::close($csync[1]);
971 kill(-9, $cpid); # make sure it gets killed
975 PVE
::Cluster
::log_msg
('info', $user, "starting task $upid");
977 my $tlist = active_workers
($upid, $sync);
978 PVE
::Cluster
::broadcast_tasklist
($tlist);
987 local $SIG{INT
} = local $SIG{QUIT
} = local $SIG{TERM
} = sub {
988 # always send signal to all pgrp members
990 if ($int_count < 3) {
991 kill(15, $kpid); # send TERM signal
993 kill(9, $kpid); # send KILL signal
997 local $SIG{PIPE
} = sub { die "broken pipe\n"; };
999 my $select = new IO
::Select
;
1000 my $fh = IO
::Handle-
>new_from_fd($psync[0], 'r');
1003 while ($select->count) {
1004 my @handles = $select->can_read(1);
1005 if (scalar(@handles)) {
1006 my $count = sysread ($handles[0], $readbuf, 4096);
1007 if (!defined ($count)) {
1009 die "sync pipe read error: $err\n";
1011 last if $count == 0; # eof
1013 $outbuf .= $readbuf;
1014 while ($outbuf =~ s/^(([^\010\r\n]*)(\r|\n|(\010)+|\r\n))//s) {
1017 if ($data =~ m/^TASK OK$/) {
1019 } elsif ($data =~ m/^TASK ERROR: (.+)$/) {
1020 print STDERR
"$1\n";
1030 # some commands daemonize without closing stdout
1031 last if !PVE
::ProcFSTools
::check_process_running
($cpid);
1037 POSIX
::close($psync[0]);
1039 if ($outbuf) { # just to be sure
1042 print $outfh $outbuf;
1048 print STDERR
"$err\n";
1050 print $outfh "TASK ERROR: $err\n";
1054 &$kill_process_group($cpid, $pstart); # make sure it gets killed
1060 &$log_task_result($upid, $user, $res);
1063 return wantarray ?
($upid, $res) : $upid;