fix perl syntax

[pve-access-control.git] / PVE / AccessControl.pm

diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm
index 3db2bff9e5dbaaf2e4cef014279fd9583d4543b5..6c04b47d550346d5fb938fb0da5cd697a194994b 100644 (file)
--- a/PVE/AccessControl.pm
+++ b/PVE/AccessControl.pm
@@ -351,7 +351,7 @@ sub authenticate_user {
 
     if (!user_enabled($usercfg, $username)) {
        sleep(2);
-       die "no such user ('$username')\n"
+       die "no such user ('$username')\n";
     }
 
     my $ctime = time();
@@ -899,7 +899,7 @@ sub write_domains {
                    $wrote_default = 1;
            } elsif (defined($formats->{$k})) {
                if (!$formats->{$k}) {
-                   $data .= "\t$k\n";
+                   $data .= "\t$k\n" if $v;
                } elsif ($v =~ m/^$formats->{$k}$/) {
                    $v = PVE::Tools::encode_text($v) if $k eq 'comment';
                    $data .= "\t$k $v\n";
@@ -994,6 +994,8 @@ sub parse_domains {
                warn "ignoring domain '$realm' - missing user attribute\n";
            } elsif (($entry->{type} eq "ldap") && !$entry->{base_dn}) {
                warn "ignoring domain '$realm' - missing base_dn attribute\n";
+           } elsif (($entry->{type} eq "ad") && !$entry->{domain}) {
+               warn "ignoring domain '$realm' - missing domain attribute\n";
            } else {
                $cfg->{$realm} = $entry;
            }