X-Git-Url: https://git.proxmox.com/?p=pve-access-control.git;a=blobdiff_plain;f=PVE%2FAccessControl.pm;h=d3f1cf6661b1fcc5221e2630a521d8b7cb8f9639;hp=82b379529b19f10c3d6e8df35d48be0c99793713;hb=66931b114112fc91d5bbffd357a7bf872ff03808;hpb=e3e6510c3ac32253a239993c203e144ee2c09194 diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index 82b3795..d3f1cf6 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -1,11 +1,17 @@ package PVE::AccessControl; use strict; +use warnings; use Encode; use Crypt::OpenSSL::Random; use Crypt::OpenSSL::RSA; +use Net::SSLeay; +use Net::IP; use MIME::Base64; use Digest::SHA; +use Digest::HMAC_SHA1; +use URI::Escape; +use LWP::UserAgent; use PVE::Tools qw(run_command lock_file file_get_contents split_list safe_print); use PVE::Cluster qw(cfs_register_file cfs_read_file cfs_write_file cfs_lock_file); use PVE::JSONSchema; @@ -37,8 +43,8 @@ my $ticket_lifetime = 3600*2; # 2 hours Crypt::OpenSSL::RSA->import_random_seed(); -cfs_register_file('user.cfg', - \&parse_user_config, +cfs_register_file('user.cfg', + \&parse_user_config, \&write_user_config); @@ -60,11 +66,11 @@ sub lock_user_config { } my $pve_auth_pub_key; -sub get_pubkey { +sub get_pubkey { return $pve_auth_pub_key if $pve_auth_pub_key; - my $input = PVE::Tools::file_get_contents($authpubkeyfn); + my $input = PVE::Tools::file_get_contents($authpubkeyfn); $pve_auth_pub_key = Crypt::OpenSSL::RSA->new_public_key($input); @@ -74,7 +80,7 @@ sub get_pubkey { my $csrf_prevention_secret; my $get_csrfr_secret = sub { if (!$csrf_prevention_secret) { - my $input = PVE::Tools::file_get_contents($pve_www_key_fn); + my $input = PVE::Tools::file_get_contents($pve_www_key_fn); $csrf_prevention_secret = Digest::SHA::sha1_base64($input); } return $csrf_prevention_secret; @@ -87,7 +93,7 @@ sub assemble_csrf_prevention_token { my $digest = Digest::SHA::sha1_base64("$timestamp:$username", &$get_csrfr_secret()); - return "$timestamp:$digest"; + return "$timestamp:$digest"; } sub verify_csrf_prevention_token { @@ -114,7 +120,7 @@ sub get_privkey { return $pve_auth_priv_key if $pve_auth_priv_key; - my $input = PVE::Tools::file_get_contents($authprivkeyfn); + my $input = PVE::Tools::file_get_contents($authprivkeyfn); $pve_auth_priv_key = Crypt::OpenSSL::RSA->new_private_key($input); @@ -213,16 +219,134 @@ sub verify_vnc_ticket { return undef; } +sub assemble_spice_ticket { + my ($username, $vmid, $node) = @_; + + my $rsa_priv = get_privkey(); + + my $timestamp = sprintf("%08x", time()); + + my $randomstr = "PVESPICE:$timestamp:$vmid:$node:" . rand(10); + + # this should be uses as one-time password + # max length is 60 chars (spice limit) + # we pass this to qemu set_pasword and limit lifetime there + # keep this secret + my $ticket = Digest::SHA::sha1_hex($rsa_priv->sign($randomstr)); + + # Note: spice proxy connects with HTTP, so $proxyticket is exposed to public + # we use a signature/timestamp to make sure nobody can fake such ticket + # an attacker can use this $proxyticket, but he will fail because $ticket is + # private. + # The proxy need to be able to extract/verify the ticket + # Note: data needs to be lower case only, because virt-viewer needs that + # Note: RSA signature are too long (>=256 charaters) and makes problems with remote-viewer + + my $secret = &$get_csrfr_secret(); + my $plain = "pvespiceproxy:$timestamp:$vmid:" . lc($node); + + # produces 40 characters + my $sig = unpack("H*", Digest::SHA::sha1($plain, &$get_csrfr_secret())); + + #my $sig = unpack("H*", $rsa_priv->sign($plain)); # this produce too long strings (512) + + my $proxyticket = $plain . "::" . $sig; + + return ($ticket, $proxyticket); +} + +sub verify_spice_connect_url { + my ($connect_str) = @_; + + # Note: we pass the spice ticket as 'host', so the + # spice viewer connects with "$ticket:$port" + + return undef if !$connect_str; + + if ($connect_str =~m/^pvespiceproxy:([a-z0-9]{8}):(\d+):(\S+)::([a-z0-9]{40}):(\d+)$/) { + my ($timestamp, $vmid, $node, $hexsig, $port) = ($1, $2, $3, $4, $5, $6); + my $ttime = hex($timestamp); + my $age = time() - $ttime; + + # use very limited lifetime - is this enough? + return undef if !(($age > -20) && ($age < 40)); + + my $plain = "pvespiceproxy:$timestamp:$vmid:$node"; + my $sig = unpack("H*", Digest::SHA::sha1($plain, &$get_csrfr_secret())); + + if ($sig eq $hexsig) { + return ($vmid, $node, $port); + } + } + + return undef; +} + +sub read_x509_subject_spice { + my ($filename) = @_; + + # read x509 subject + my $bio = Net::SSLeay::BIO_new_file($filename, 'r'); + my $x509 = Net::SSLeay::PEM_read_bio_X509($bio); + Net::SSLeay::BIO_free($bio); + my $nameobj = Net::SSLeay::X509_get_subject_name($x509); + my $subject = Net::SSLeay::X509_NAME_oneline($nameobj); + Net::SSLeay::X509_free($x509); + + # remote-viewer wants comma as seperator (not '/') + $subject =~ s!^/!!; + $subject =~ s!/(\w+=)!,$1!g; + + return $subject; +} + +# helper to generate SPICE remote-viewer configuration +sub remote_viewer_config { + my ($authuser, $vmid, $node, $proxy, $title, $port) = @_; + + if (!$proxy) { + my $host = `hostname -f` || PVE::INotify::nodename(); + chomp $host; + $proxy = $host; + } + + my ($ticket, $proxyticket) = assemble_spice_ticket($authuser, $vmid, $node); + + my $filename = "/etc/pve/local/pve-ssl.pem"; + my $subject = read_x509_subject_spice($filename); + + my $cacert = PVE::Tools::file_get_contents("/etc/pve/pve-root-ca.pem", 8192); + $cacert =~ s/\n/\\n/g; + + $proxy = "[$proxy]" if Net::IP::ip_is_ipv6($proxy); + my $config = { + 'secure-attention' => "Ctrl+Alt+Ins", + 'toggle-fullscreen' => "Shift+F11", + 'release-cursor' => "Ctrl+Alt+R", + type => 'spice', + title => $title, + host => $proxyticket, # this break tls hostname verification, so we need to use 'host-subject' + proxy => "http://$proxy:3128", + 'tls-port' => $port, + 'host-subject' => $subject, + ca => $cacert, + password => $ticket, + 'delete-this-file' => 1, + }; + + return ($ticket, $proxyticket, $config); +} + sub check_user_exist { my ($usercfg, $username, $noerr) = @_; $username = PVE::Auth::Plugin::verify_username($username, $noerr); return undef if !$username; - + return $usercfg->{users}->{$username} if $usercfg && $usercfg->{users}->{$username}; die "no such user ('$username')\n" if !$noerr; - + return undef; } @@ -234,50 +358,62 @@ sub check_user_enabled { return 1 if $data->{enable}; - return 1 if $username eq 'root@pam'; # root is always enabled - die "user '$username' is disabled\n" if !$noerr; - + return undef; } +sub verify_one_time_pw { + my ($usercfg, $username, $tfa_cfg, $otp) = @_; + + my $type = $tfa_cfg->{type}; + + die "missing one time password for Factor-two authentication '$type'\n" if !$otp; + + # fixme: proxy support? + my $proxy; + + if ($type eq 'yubico') { + my $keys = $usercfg->{users}->{$username}->{keys}; + yubico_verify_otp($otp, $keys, $tfa_cfg->{url}, $tfa_cfg->{id}, $tfa_cfg->{key}, $proxy); + } elsif ($type eq 'oath') { + my $keys = $usercfg->{users}->{$username}->{keys}; + oath_verify_otp($otp, $keys, $tfa_cfg->{step}, $tfa_cfg->{digits}); + } else { + die "unknown tfa type '$type'\n"; + } +} + # password should be utf8 encoded +# Note: some pluging delay/sleep if auth fails sub authenticate_user { - my ($username, $password) = @_; + my ($username, $password, $otp) = @_; die "no username specified\n" if !$username; - + my ($ruid, $realm); ($username, $ruid, $realm) = PVE::Auth::Plugin::verify_username($username); my $usercfg = cfs_read_file('user.cfg'); - eval { check_user_enabled($usercfg, $username); }; - if (my $err = $@) { - sleep(2); - die $err; - } + check_user_enabled($usercfg, $username); my $ctime = time(); my $expire = $usercfg->{users}->{$username}->{expire}; - if ($expire && ($expire < $ctime)) { - sleep(2); - die "account expired\n" - } + die "account expired\n" if $expire && ($expire < $ctime); my $domain_cfg = cfs_read_file('domains.cfg'); - eval { - my $cfg = $domain_cfg->{ids}->{$realm}; - die "auth domain '$realm' does not exists\n" if !$cfg; - my $plugin = PVE::Auth::Plugin->lookup($cfg->{type}); - $plugin->authenticate_user($cfg, $realm, $ruid, $password); - }; - if (my $err = $@) { - sleep(2); # timeout after failed auth - die $err; + my $cfg = $domain_cfg->{ids}->{$realm}; + die "auth domain '$realm' does not exists\n" if !$cfg; + my $plugin = PVE::Auth::Plugin->lookup($cfg->{type}); + $plugin->authenticate_user($cfg, $realm, $ruid, $password); + + if ($cfg->{tfa}) { + my $tfa_cfg = PVE::Auth::Plugin::parse_tfa_config($cfg->{tfa}); + verify_one_time_pw($usercfg, $username, $tfa_cfg, $otp); } return $username; @@ -297,55 +433,48 @@ sub domain_set_password { } sub add_user_group { - my ($username, $usercfg, $group) = @_; + $usercfg->{users}->{$username}->{groups}->{$group} = 1; $usercfg->{groups}->{$group}->{users}->{$username} = 1; } sub delete_user_group { - my ($username, $usercfg) = @_; - + foreach my $group (keys %{$usercfg->{groups}}) { - delete ($usercfg->{groups}->{$group}->{users}->{$username}) + delete ($usercfg->{groups}->{$group}->{users}->{$username}) if $usercfg->{groups}->{$group}->{users}->{$username}; } } sub delete_user_acl { - my ($username, $usercfg) = @_; foreach my $acl (keys %{$usercfg->{acl}}) { - delete ($usercfg->{acl}->{$acl}->{users}->{$username}) + delete ($usercfg->{acl}->{$acl}->{users}->{$username}) if $usercfg->{acl}->{$acl}->{users}->{$username}; } } sub delete_group_acl { - my ($group, $usercfg) = @_; foreach my $acl (keys %{$usercfg->{acl}}) { - delete ($usercfg->{acl}->{$acl}->{groups}->{$group}) + delete ($usercfg->{acl}->{$acl}->{groups}->{$group}) if $usercfg->{acl}->{$acl}->{groups}->{$group}; } } sub delete_pool_acl { - my ($pool, $usercfg) = @_; my $path = "/pool/$pool"; - foreach my $aclpath (keys %{$usercfg->{acl}}) { - delete ($usercfg->{acl}->{$aclpath}) - if $usercfg->{acl}->{$aclpath} eq 'path'; - } + delete ($usercfg->{acl}->{$path}) } # we automatically create some predefined roles by splitting privs @@ -356,36 +485,37 @@ sub delete_pool_acl { my $privgroups = { VM => { root => [], - admin => [ - 'VM.Config.Disk', - 'VM.Config.CPU', - 'VM.Config.Memory', - 'VM.Config.Network', + admin => [ + 'VM.Config.Disk', + 'VM.Config.CPU', + 'VM.Config.Memory', + 'VM.Config.Network', 'VM.Config.HWType', - 'VM.Config.Options', # covers all other things - 'VM.Allocate', + 'VM.Config.Options', # covers all other things + 'VM.Allocate', + 'VM.Clone', 'VM.Migrate', - 'VM.Monitor', - 'VM.Snapshot', + 'VM.Monitor', + 'VM.Snapshot', ], user => [ 'VM.Config.CDROM', # change CDROM media - 'VM.Console', + 'VM.Console', 'VM.Backup', 'VM.PowerMgmt', ], - audit => [ + audit => [ 'VM.Audit', ], }, Sys => { root => [ - 'Sys.PowerMgmt', + 'Sys.PowerMgmt', 'Sys.Modify', # edit/change node settings ], admin => [ 'Permissions.Modify', - 'Sys.Console', + 'Sys.Console', 'Sys.Syslog', ], user => [], @@ -413,7 +543,7 @@ my $privgroups = { admin => [ 'User.Modify', 'Group.Allocate', # edit/change group settings - 'Realm.AllocateUser', + 'Realm.AllocateUser', ], user => [], audit => [], @@ -439,7 +569,7 @@ sub create_roles { foreach my $cat (keys %$privgroups) { my $cd = $privgroups->{$cat}; - foreach my $p (@{$cd->{root}}, @{$cd->{admin}}, + foreach my $p (@{$cd->{root}}, @{$cd->{admin}}, @{$cd->{user}}, @{$cd->{audit}}) { $valid_privs->{$p} = 1; } @@ -457,6 +587,8 @@ sub create_roles { $special_roles->{"PVEAuditor"}->{$p} = 1; } } + + $special_roles->{"PVETemplateUser"} = { 'VM.Clone' => 1, 'VM.Audit' => 1 }; }; create_roles(); @@ -473,8 +605,8 @@ sub add_role_privs { $usercfg->{roles}->{$role}->{$priv} = 1; } else { die "invalid priviledge '$priv'\n"; - } - } + } + } } sub normalize_path { @@ -488,10 +620,10 @@ sub normalize_path { $path = "/$path" if $path !~ m|^/|; - return undef if $path !~ m|^[[:alnum:]\-\_\/]+$|; + return undef if $path !~ m|^[[:alnum:]\.\-\_\/]+$|; return $path; -} +} PVE::JSONSchema::register_format('pve-groupid', \&verify_groupname); @@ -504,7 +636,7 @@ sub verify_groupname { return undef; } - + return $groupname; } @@ -518,7 +650,7 @@ sub verify_rolename { return undef; } - + return $rolename; } @@ -532,7 +664,7 @@ sub verify_poolname { return undef; } - + return $poolname; } @@ -545,7 +677,7 @@ sub verify_privname { return undef; } - + return $priv; } @@ -556,10 +688,10 @@ sub userconfig_force_defaults { $cfg->{roles}->{$r} = $special_roles->{$r}; } - # fixme: remove 'root' group (not required)? - - # add root user - $cfg->{users}->{'root@pam'}->{enable} = 1; + # add root user if not exists + if (!$cfg->{users}->{'root@pam'}) { + $cfg->{users}->{'root@pam'}->{enable} = 1; + } } sub parse_user_config { @@ -569,15 +701,13 @@ sub parse_user_config { userconfig_force_defaults($cfg); - while ($raw && $raw =~ s/^(.*?)(\n|$)//) { + $raw = '' if !defined($raw); + while ($raw =~ /^\s*(.+?)\s*$/gm) { my $line = $1; - - next if $line =~ m/^\s*$/; # skip empty lines - my @data; foreach my $d (split (/:/, $line)) { - $d =~ s/^\s+//; + $d =~ s/^\s+//; $d =~ s/\s+$//; push @data, $d } @@ -585,7 +715,7 @@ sub parse_user_config { my $et = shift @data; if ($et eq 'user') { - my ($user, $enable, $expire, $firstname, $lastname, $email, $comment) = @data; + my ($user, $enable, $expire, $firstname, $lastname, $email, $comment, $keys) = @data; my (undef, undef, $realm) = PVE::Auth::Plugin::verify_username($user, 1); if (!$realm) { @@ -617,6 +747,8 @@ sub parse_user_config { $cfg->{users}->{$user}->{email} = $email; $cfg->{users}->{$user}->{comment} = PVE::Tools::decode_text($comment) if $comment; $cfg->{users}->{$user}->{expire} = $expire; + # keys: allowed yubico key ids or oath secrets (base32 encoded) + $cfg->{users}->{$user}->{keys} = $keys if $keys; #$cfg->{users}->{$user}->{groups}->{$group} = 1; #$cfg->{groups}->{$group}->{$user} = 1; @@ -641,7 +773,7 @@ sub parse_user_config { next; } - if ($cfg->{users}->{$user}) { # user exists + if ($cfg->{users}->{$user}) { # user exists $cfg->{users}->{$user}->{groups}->{$group} = 1; $cfg->{groups}->{$group}->{users}->{$user} = 1; } else { @@ -651,7 +783,7 @@ sub parse_user_config { } elsif ($et eq 'role') { my ($role, $privlist) = @data; - + if (!verify_rolename($role, 1)) { warn "user config - ignore role '$role' - invalid characters in role name\n"; next; @@ -665,15 +797,15 @@ sub parse_user_config { $cfg->{roles}->{$role}->{$priv} = 1; } else { warn "user config - ignore invalid priviledge '$priv'\n"; - } + } } - + } elsif ($et eq 'acl') { my ($propagate, $pathtxt, $uglist, $rolelist) = @data; if (my $path = normalize_path($pathtxt)) { foreach my $role (split_list($rolelist)) { - + if (!verify_rolename($role, 1)) { warn "user config - ignore invalid role name '$role' in acl\n"; next; @@ -682,13 +814,13 @@ sub parse_user_config { foreach my $ug (split_list($uglist)) { if ($ug =~ m/^@(\S+)$/) { my $group = $1; - if ($cfg->{groups}->{$group}) { # group exists + if ($cfg->{groups}->{$group}) { # group exists $cfg->{acl}->{$path}->{groups}->{$group}->{$role} = $propagate; } else { warn "user config - ignore invalid acl group '$group'\n"; } } elsif (PVE::Auth::Plugin::verify_username($ug, 1)) { - if ($cfg->{users}->{$ug}) { # user exists + if ($cfg->{users}->{$ug}) { # user exists $cfg->{acl}->{$path}->{users}->{$ug}->{$role} = $propagate; } else { warn "user config - ignore invalid acl member '$ug'\n"; @@ -727,7 +859,7 @@ sub parse_user_config { } $cfg->{pools}->{$pool}->{vms}->{$vmid} = 1; - + # record vmid ==> pool relation $cfg->{vms}->{$vmid} = $pool; } @@ -762,7 +894,8 @@ sub write_user_config { my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; my $expire = int($d->{expire} || 0); my $enable = $d->{enable} ? 1 : 0; - $data .= "user:$user:$enable:$expire:$firstname:$lastname:$email:$comment:\n"; + my $keys = $d->{keys} ? $d->{keys} : ''; + $data .= "user:$user:$enable:$expire:$firstname:$lastname:$email:$comment:$keys:\n"; } $data .= "\n"; @@ -770,7 +903,7 @@ sub write_user_config { foreach my $group (keys %{$cfg->{groups}}) { my $d = $cfg->{groups}->{$group}; my $list = join (',', keys %{$d->{users}}); - my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; + my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; $data .= "group:$group:$list:$comment:\n"; } @@ -780,7 +913,7 @@ sub write_user_config { my $d = $cfg->{pools}->{$pool}; my $vmlist = join (',', keys %{$d->{vms}}); my $storelist = join (',', keys %{$d->{storage}}); - my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; + my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; $data .= "pool:$pool:$comment:$vmlist:$storelist:\n"; } @@ -820,7 +953,7 @@ sub write_user_config { foreach my $user (keys %{$d->{users}}) { # no need to save, because root is always 'Administartor' - next if $user eq 'root@pam'; + next if $user eq 'root@pam'; my $l0 = ''; my $l1 = ''; @@ -854,7 +987,7 @@ sub write_user_config { sub roles { my ($cfg, $user, $path) = @_; - # NOTE: we do not consider pools here. + # NOTE: we do not consider pools here. # You need to use $rpcenv->roles() instead if you want that. return 'Administrator' if $user eq 'root@pam'; # root can do anything @@ -909,7 +1042,7 @@ sub roles { return ('NoAccess') if defined ($perm->{NoAccess}); #return () if defined ($perm->{NoAccess}); - + #print "permission $user $path = " . Dumper ($perm); my @ra = keys %$perm; @@ -918,7 +1051,7 @@ sub roles { return @ra; } - + sub permission { my ($cfg, $user, $path) = @_; @@ -926,7 +1059,7 @@ sub permission { return {} if !$user; my @ra = roles($cfg, $user, $path); - + my $privs = {}; foreach my $role (@ra) { @@ -956,4 +1089,185 @@ sub check_permissions { return 1; } +sub remove_vm_access { + my ($vmid) = @_; + my $delVMaccessFn = sub { + my $usercfg = cfs_read_file("user.cfg"); + + if (my $acl = $usercfg->{acl}->{'/vms/'.$vmid}) { + delete $usercfg->{acl}->{'/vms/'.$vmid}; + cfs_write_file("user.cfg", $usercfg); + } + if (my $pool = $usercfg->{vms}->{$vmid}) { + if (my $data = $usercfg->{pools}->{$pool}) { + delete $data->{vms}->{$vmid}; + delete $usercfg->{vms}->{$vmid}; + cfs_write_file("user.cfg", $usercfg); + } + } + }; + + lock_user_config($delVMaccessFn, "access permissions cleanup for VM $vmid failed"); +} + +sub add_vm_to_pool { + my ($vmid, $pool) = @_; + + my $addVMtoPoolFn = sub { + my $usercfg = cfs_read_file("user.cfg"); + if (my $data = $usercfg->{pools}->{$pool}) { + $data->{vms}->{$vmid} = 1; + $usercfg->{vms}->{$vmid} = $pool; + cfs_write_file("user.cfg", $usercfg); + } + }; + + lock_user_config($addVMtoPoolFn, "can't add VM $vmid to pool '$pool'"); +} + +sub remove_vm_from_pool { + my ($vmid) = @_; + + my $delVMfromPoolFn = sub { + my $usercfg = cfs_read_file("user.cfg"); + if (my $pool = $usercfg->{vms}->{$vmid}) { + if (my $data = $usercfg->{pools}->{$pool}) { + delete $data->{vms}->{$vmid}; + delete $usercfg->{vms}->{$vmid}; + cfs_write_file("user.cfg", $usercfg); + } + } + }; + + lock_user_config($delVMfromPoolFn, "pool cleanup for VM $vmid failed"); +} + +# experimental code for yubico OTP verification + +sub yubico_compute_param_sig { + my ($param, $api_key) = @_; + + my $paramstr = ''; + foreach my $key (sort keys %$param) { + $paramstr .= '&' if $paramstr; + $paramstr .= "$key=$param->{$key}"; + } + + my $sig = uri_escape(encode_base64(Digest::HMAC_SHA1::hmac_sha1($paramstr, decode_base64($api_key || '')), '')); + + return ($paramstr, $sig); +} + +sub yubico_verify_otp { + my ($otp, $keys, $url, $api_id, $api_key, $proxy) = @_; + + die "yubico: missing password\n" if !defined($otp); + die "yubico: missing API ID\n" if !defined($api_id); + die "yubico: missing API KEY\n" if !defined($api_key); + die "yubico: no associated yubico keys\n" if $keys =~ m/^\s+$/; + + die "yubico: wrong OTP lenght\n" if (length($otp) < 32) || (length($otp) > 48); + + # we always use http, because https cert verification always make problem, and + # some proxies does not work with https. + + $url = 'http://api2.yubico.com/wsapi/2.0/verify' if !defined($url); + + my $params = { + nonce => Digest::HMAC_SHA1::hmac_sha1_hex(time(), rand()), + id => $api_id, + otp => uri_escape($otp), + timestamp => 1, + }; + + my ($paramstr, $sig) = yubico_compute_param_sig($params, $api_key); + + $paramstr .= "&h=$sig" if $api_key; + + my $req = HTTP::Request->new('GET' => "$url?$paramstr"); + + my $ua = LWP::UserAgent->new(protocols_allowed => ['http'], timeout => 30); + + if ($proxy) { + $ua->proxy(['http'], $proxy); + } else { + $ua->env_proxy; + } + + my $response = $ua->request($req); + my $code = $response->code; + + if ($code != 200) { + my $msg = $response->message || 'unknown'; + die "Invalid response from server: $code $msg\n"; + } + + my $raw = $response->decoded_content; + + my $result = {}; + foreach my $kvpair (split(/\n/, $raw)) { + chomp $kvpair; + if($kvpair =~ /^\S+=/) { + my ($k, $v) = split(/=/, $kvpair, 2); + $v =~ s/\s//g; + $result->{$k} = $v; + } + } + + my $rsig = $result->{h}; + delete $result->{h}; + + if ($api_key) { + my ($datastr, $vsig) = yubico_compute_param_sig($result, $api_key); + $vsig = uri_unescape($vsig); + die "yubico: result signature verification failed\n" if $rsig ne $vsig; + } + + die "yubico auth failed: $result->{status}\n" if $result->{status} ne 'OK'; + + my $publicid = $result->{publicid} = substr(lc($result->{otp}), 0, 12); + + my $found; + foreach my $k (PVE::Tools::split_list($keys)) { + if ($k eq $publicid) { + $found = 1; + last; + } + } + + die "yubico auth failed: key does not belong to user\n" if !$found; + + return $result; +} + +sub oath_verify_otp { + my ($otp, $keys, $step, $digits) = @_; + + die "oath: missing password\n" if !defined($otp); + die "oath: no associated oath keys\n" if $keys =~ m/^\s+$/; + + $step = 30 if !$step; + $digits = 6 if !$digits; + + my $found; + + my $parser = sub { + my $line = shift; + + if ($line =~ m/^\d{6}$/) { + $found = 1 if $otp eq $line; + } + }; + + foreach my $k (PVE::Tools::split_list($keys)) { + # Note: we generate 3 values to allow small time drift + my $now = localtime(time() - $step); + my $cmd = ['oathtool', '--totp', '--digits', $digits, '-N', $now, '-s', $step, '-w', '2', '-b', $k]; + eval { run_command($cmd, outfunc => $parser, errfunc => sub {}); }; + last if $found; + } + + die "oath auth failed\n" if !$found; +} + 1;