]> git.proxmox.com Git - pve-access-control.git/commitdiff
update tfa cleanup when deleting users
authorWolfgang Bumiller <w.bumiller@proxmox.com>
Tue, 9 Nov 2021 11:27:03 +0000 (12:27 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 10 Nov 2021 10:13:21 +0000 (11:13 +0100)
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
src/PVE/API2/User.pm
src/PVE/AccessControl.pm

index 3d4d4e08d02775a36b5bb66299065647e66ffb9a..244264e88e4136d52bbc27eb36e47b411eae6624 100644 (file)
@@ -453,7 +453,7 @@ __PACKAGE__->register_method ({
 
            my $partial_deletion = '';
            eval {
-               PVE::AccessControl::user_set_tfa($userid, $realm, undef, undef, $usercfg, $domain_cfg);
+               PVE::AccessControl::user_remove_tfa($userid);
                $partial_deletion = ' - but deleted related TFA';
 
                PVE::AccessControl::delete_user_group($userid, $usercfg);
index cd46507ba2fe0dbc9fbcb70b4855ff8ed5341376..0b0084787ca7a2f4f77f215fa231628398dcecec 100644 (file)
@@ -1740,6 +1740,16 @@ sub assert_new_tfa_config_available() {
     # FIXME: Assert cluster-wide new-tfa-config support!
 }
 
+sub user_remove_tfa : prototype($) {
+    my ($userid) = @_;
+
+    assert_new_tfa_config_available();
+
+    my $tfa_cfg = cfs_read_file('priv/tfa.cfg');
+    $tfa_cfg->remove_user($userid);
+    cfs_write_file('priv/tfa.cfg', $tfa_cfg);
+}
+
 sub user_get_tfa : prototype($$$) {
     my ($username, $realm, $new_format) = @_;