From: Daniel Krambrock via pve-devel <pve-devel@lists.proxmox.com>
Date: Thu, 11 Apr 2024 08:09:09 +0000 (+0200)
Subject: fix #5335: sort ACL entries in user.cfg
X-Git-Url: https://git.proxmox.com/?p=pve-access-control.git;a=commitdiff_plain

fix #5335: sort ACL entries in user.cfg

Stable sorting in user.cfg config file allows tracking changes by
checking into git or when using automation like ansible.

Signed-off-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
Tested-by: Folge Gleumes <f.gleumes@proxmox.com>
---

diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
index 21f93ff..47f2d38 100644
--- a/src/PVE/AccessControl.pm
+++ b/src/PVE/AccessControl.pm
@@ -951,7 +951,7 @@ sub iterate_acl_tree {
 
     my $children = $node->{children};
 
-    foreach my $child (keys %$children) {
+    foreach my $child (sort keys %$children) {
 	iterate_acl_tree("$path/$child", $children->{$child}, $code);
     }
 }