From 4fb3cc5841d7b7ba08d108182b19882b23a58fa3 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Mon, 6 Feb 2012 12:04:21 +0100 Subject: [PATCH 1/1] remove buggy check_storage_perm Storage permissions are automatically inherited from pool, so this method is more or less useless. --- PVE/RPCEnvironment.pm | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/PVE/RPCEnvironment.pm b/PVE/RPCEnvironment.pm index d382dcb..14e6849 100644 --- a/PVE/RPCEnvironment.pm +++ b/PVE/RPCEnvironment.pm @@ -282,18 +282,6 @@ sub check_vm_perm { return $self->check_full($user, "/vms/$vmid", $privs, $any, $noerr); }; -sub check_storage_perm { - my ($self, $user, $vmid, $pool, $storeid, $privs, $any, $noerr) = @_; - - my $cfg = $self->{user_cfg}; - - if ($pool && $cfg->{pools}->{$pool} && - $cfg->{pools}->{$pool}->{storage}->{$storeid}) { - return if $self->check_full($user, "/pool/$pool", $privs, $any, 1); - } - return $self->check_full($user, "/storage/$storeid", $privs, $any, $noerr); -}; - sub is_group_member { my ($self, $group, $user) = @_; -- 2.39.2