From a5ec58ea9a87ba32b6faa7935734ed52568ecfdd Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fabian=20Gr=C3=BCnbichler?= Date: Thu, 21 Nov 2019 15:43:20 +0100 Subject: [PATCH] user.cfg: sort group and pool members, role privs MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit makes no functional difference, but keeps the output/written config more stable. Signed-off-by: Fabian Grünbichler --- PVE/AccessControl.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index 2a4fe14..1ba1596 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -1067,7 +1067,7 @@ sub write_user_config { foreach my $group (sort keys %{$cfg->{groups}}) { my $d = $cfg->{groups}->{$group}; - my $list = join (',', keys %{$d->{users}}); + my $list = join (',', sort keys %{$d->{users}}); my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; $data .= "group:$group:$list:$comment:\n"; } @@ -1076,8 +1076,8 @@ sub write_user_config { foreach my $pool (sort keys %{$cfg->{pools}}) { my $d = $cfg->{pools}->{$pool}; - my $vmlist = join (',', keys %{$d->{vms}}); - my $storelist = join (',', keys %{$d->{storage}}); + my $vmlist = join (',', sort keys %{$d->{vms}}); + my $storelist = join (',', sort keys %{$d->{storage}}); my $comment = $d->{comment} ? PVE::Tools::encode_text($d->{comment}) : ''; $data .= "pool:$pool:$comment:$vmlist:$storelist:\n"; } @@ -1088,7 +1088,7 @@ sub write_user_config { next if $special_roles->{$role}; my $d = $cfg->{roles}->{$role}; - my $list = join (',', keys %$d); + my $list = join (',', sort keys %$d); $data .= "role:$role:$list:\n"; } -- 2.39.2