From: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Date: Mon, 27 Nov 2017 09:18:48 +0000 (+0100)
Subject: cleanup Net::SSLeay error handling
X-Git-Url: https://git.proxmox.com/?p=pve-apiclient.git;a=commitdiff_plain;h=1d40f3c38c00225df29784ac3277f0413fab65fc;hp=adbda0b73e98c41dbb5771caa39f843b58e86116

cleanup Net::SSLeay error handling

X509_get_fingerprint does not die - it only returns undef in case of
errors (or segfaults if the $cert pointer is invalid).
---

diff --git a/PVE/APIClient/LWP.pm b/PVE/APIClient/LWP.pm
index 2ae8c1a..36e1b06 100755
--- a/PVE/APIClient/LWP.pm
+++ b/PVE/APIClient/LWP.pm
@@ -258,11 +258,8 @@ my $verify_cert_callback = sub {
 
     # check server certificate against cache of pinned FPs
     # get fingerprint of server certificate
-    my $fp;
-    eval {
-	$fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
-    };
-    return 0 if $@ || !defined($fp) || $fp eq ''; # error
+    my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
+    return 0 !defined($fp) || $fp eq ''; # error
 
     my $valid = $self->{cached_fingerprints}->{$fp};
     return $valid if defined($valid); # return cached result