From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Fri, 4 Dec 2020 11:18:45 +0000 (+0100)
Subject: improve protocol selection heuristic
X-Git-Url: https://git.proxmox.com/?p=pve-apiclient.git;a=commitdiff_plain;h=44c53c4be74cf700d340e2f7edfae2e9ae623259

improve protocol selection heuristic

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/PVE/APIClient/LWP.pm b/PVE/APIClient/LWP.pm
index bc158e9..63f2177 100755
--- a/PVE/APIClient/LWP.pm
+++ b/PVE/APIClient/LWP.pm
@@ -353,7 +353,13 @@ sub new {
 	$self->{port} = $self->{host} eq 'localhost' ? 85 : 8006;
     }
     if (!$self->{protocol}) {
-	$self->{protocol} = $self->{host} eq 'localhost' ? 'http' : 'https';
+	# cope that PBS and PVE can be installed on the same host, and one may thus use
+	# 'localhost' then - so only default to http for privileged ports, in that case,
+	# as the HTTP daemons normally run with those (e.g., 85 or 87)
+	$self->{protocol} = $self->{host} eq 'localhost' && $self->{port} < 1024
+	    ? 'http'
+	    : 'https'
+	    ;
     }
 
     $self->{useragent} = LWP::UserAgent->new(