X-Git-Url: https://git.proxmox.com/?p=pve-client.git;a=blobdiff_plain;f=PVE%2FAPIClient%2FCommands%2Fremote.pm;h=0f465eac489a49753b77112e2824d02fbe42a142;hp=8cedf083e3df2d29a163f86820a0ecf4476bfcbf;hb=654a262843b28140f4b3dc6e10e6b6447f95e27f;hpb=06039c7f9bb20ba7259cdf5dbc4f6fff5fd05efc

diff --git a/PVE/APIClient/Commands/remote.pm b/PVE/APIClient/Commands/remote.pm
index 8cedf08..0f465ea 100644
--- a/PVE/APIClient/Commands/remote.pm
+++ b/PVE/APIClient/Commands/remote.pm
@@ -3,54 +3,144 @@ package PVE::APIClient::Commands::remote;
 use strict;
 use warnings;
 
-use PVE::JSONSchema qw(register_standard_option get_standard_option);
+use PVE::JSONSchema qw(get_standard_option);
+use PVE::Tools qw(extract_param);
 use PVE::APIClient::Config;
 
 use PVE::CLIHandler;
 
+use PVE::APIClient::LWP;
+use PVE::PTY ();
+
 use base qw(PVE::CLIHandler);
 
-my $complete_remote_name = sub {
+sub read_password {
+   return PVE::PTY::read_password("Remote password: ")
+}
 
-    my $config = PVE::APIClient::Config->new();
-    my $known_remotes = $config->remotes;
+__PACKAGE__->register_method ({
+    name => 'list',
+    path => 'list',
+    method => 'GET',
+    description => "List remotes from your config file.",
+    parameters => {
+	additionalProperties => 0,
+    },
+    returns => { type => 'null' },
+    code => sub {
+	my $config = PVE::APIClient::Config->load();
 
-    return [keys %{$known_remotes}];
-};
+	printf("%10s %10s %10s %10s %100s\n", "Name", "Host", "Port", "Username", "Fingerprint");
+	for my $name (keys %{$config->{ids}}) {
+	    my $data = $config->{ids}->{$name};
+	    next if $data->{type} ne 'remote';
+	    printf("%10s %10s %10s %10s %100s\n", $name, $data->{'host'},
+		   $data->{'port'} // '-', $data->{'username'}, $data->{'fingerprint'} // '-');
+	}
 
-register_standard_option('pveclient-remote-name', {
-    description => "The name of the remote.",
-    type => 'string',
-    pattern => qr([\w\d\.\-\_]+),
-    completion => $complete_remote_name,
-});
+	return undef;
+    }});
 
 __PACKAGE__->register_method ({
     name => 'add',
     path => 'add',
     method => 'POST',
     description => "Add a remote to your config file.",
-    parameters => {
-	additionalProperties => 0,
-	properties => {
-	    name => get_standard_option('pveclient-remote-name', { completion => sub {} }),
-	    host => {
-		description => "The host, either host, host:port or https://host:port",
-		type => 'string',
-	    },
-	    username => {
-		description => "The username.",
-		type => 'string',
-		optional => 1,
-	    },
-	},
-    },
+    parameters => PVE::APIClient::RemoteConfig->createSchema(1),
+    returns => { type => 'null'},
+    code => sub {
+	my ($param) = @_;
+
+	# fixme: lock config file
+
+	my $remote = $param->{name};
+
+	my $config = PVE::APIClient::Config->load();
+
+	die "Remote '$remote' already exists\n"
+	    if $config->{ids}->{$remote};
+
+	my $last_fp = 0;
+
+	my $password = $param->{password};
+	if (!defined($password)) {
+	    $password = PVE::PTY::read_password("Remote password: ");
+	}
+
+	my $setup = {
+	    username                => $param->{username},
+	    password                => $password,
+	    host                    => $param->{host},
+	    port                    => $param->{port} // 8006,
+	};
+
+	if ($param->{fingerprint}) {
+	    $setup->{cached_fingerprints} = {
+		$param->{fingerprint} => 1,
+	    };
+	} else {
+	    $setup->{manual_verification} = 1;
+	    $setup->{register_fingerprint_cb} = sub {
+		my $fp = shift @_;
+		$last_fp = $fp;
+	    };
+	}
+
+	my $api = PVE::APIClient::LWP->new(%$setup);
+	$api->login();
+
+	$param->{fingerprint} = $last_fp if !defined($param->{fingerprint});
+	my $plugin = PVE::APIClient::Config->lookup('remote');
+	my $opts = $plugin->check_config($remote, $param, 1, 1);
+	$config->{ids}->{$remote} = $opts;
+
+	PVE::APIClient::Config->save($config);
+
+	return undef;
+    }});
+
+__PACKAGE__->register_method ({
+    name => 'update',
+    path => 'update',
+    method => 'PUT',
+    description => "Update a remote configuration.",
+    parameters => PVE::APIClient::RemoteConfig->updateSchema(1),
     returns => { type => 'null'},
     code => sub {
 	my ($param) = @_;
 
-	die "implement me";
+	# fixme: lock config file
+
+	my $name = extract_param($param, 'name');
+	my $digest = extract_param($param, 'digest');
+	my $delete = extract_param($param, 'delete');
+
+	my $config = PVE::APIClient::Config->load();
+	my $remote = PVE::APIClient::Config->lookup_remote($config, $name);
+
+	my $plugin = PVE::APIClient::Config->lookup('remote');
+	my $opts = $plugin->check_config($name, $param, 0, 1);
 
+	foreach my $k (%$opts) {
+	    $remote->{$k} = $opts->{$k};
+	}
+
+	if ($delete) {
+	    my $options = $plugin->private()->{options}->{'remote'};
+	    foreach my $k (PVE::Tools::split_list($delete)) {
+		my $d = $options->{$k} ||
+		    die "no such option '$k'\n";
+		die "unable to delete required option '$k'\n"
+		    if !$d->{optional};
+		die "unable to delete fixed option '$k'\n"
+		    if $d->{fixed};
+		delete $remote->{$k};
+	    }
+	}
+
+	PVE::APIClient::Config->save($config);
+
+	return undef;
     }});
 
 __PACKAGE__->register_method ({
@@ -68,13 +158,20 @@ __PACKAGE__->register_method ({
     code => sub {
 	my ($param) = @_;
 
-	die "implement me";
+	# fixme: lock config
+
+	my $config = PVE::APIClient::Config->load();
+	delete $config->{ids}->{$param->{name}};
+	PVE::APIClient::Config->save($config);
 
+	return undef;
     }});
 
 our $cmddef = {
-    add => [ __PACKAGE__, 'add', ['name', 'host']],
+    add => [ __PACKAGE__, 'add', ['name', 'host', 'username']],
+    update => [ __PACKAGE__, 'update', ['name']],
     remove => [ __PACKAGE__, 'remove', ['name']],
+    list => [__PACKAGE__, 'list'],
 };
 
 1;