]> git.proxmox.com Git - pve-cluster.git/commit
pmxcfs: workaround dumb g_string_free behaviour
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 24 Jun 2019 10:44:51 +0000 (12:44 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 24 Jun 2019 10:44:54 +0000 (12:44 +0200)
commit3f1c7eb172c9d21fc65a4725e79a4f22a654c75c
tree8e4ea489fde154974febbb5c31e618582bf12004
parent5b17ee167172f2afd3dd162587ad415f91f56265
pmxcfs: workaround dumb g_string_free behaviour

While GLib mentions that this method is nullable[0][1] (i.e., can be passed
and can return null) its use of the, a bit misleading,
g_return_val_if_fail[2] voids that, as passing NULL emits an
warning[2] which looks pretty grave (assertion failure), albeit is
just noise..

[0]: https://developer.gnome.org/glib/stable/glib-Strings.html#g-string-free
[1]: https://salsa.debian.org/gnome-team/glib/blob/debian/2.58.3-2/glib/gstring.c#L196
[2]: https://developer.gnome.org/glib/stable/glib-Warnings-and-Assertions.html#g-return-val-if-fail

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
data/src/status.c