vlan fixups: remove existing vlan ids

[pve-common.git] / src / PVE / Network.pm

diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm
index 63476d3d98dc1a42aa799e69fd660fcef0af7793..405f14ba17afa44e0823f5e9469c60c075e4a1e9 100644 (file)
--- a/src/PVE/Network.pm
+++ b/src/PVE/Network.pm
@@ -181,8 +181,10 @@ my $bridge_add_interface = sub {
 
    if ($vlan_aware) {
        if ($tag) {
-           system("/sbin/bridge vlan add dev $iface vid $tag pvid untagged") == 0 ||
-           die "unable to add vlan $tag to interface $iface\n";
+           system({'/sbin/bridge'} 'bridge', 'vlan', 'del', 'dev', $iface, 'vid', '1-4094') == 0
+               or die "failed to remove default vlan tags of $iface\n";
+           system({'/sbin/bridge'} 'bridge', 'vlan', 'add', 'dev', $iface, 'vid', $tag, 'pvid', 'untagged') == 0
+               or die "unable to add vlan $tag to interface $iface\n";
 
            warn "Caution: Setting VLAN ID 1 on a VLAN aware bridge may be dangerous\n" if $tag == 1;
        } else {