random_ether_addr: code cleanups

[pve-common.git] / src / PVE / Tools.pm

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index cda0797ccc25a2b7c41784327892c3df60417e55..32f36ac2d6ac9a2fa9fa5cd9ce6bb21bd60ef422 100644 (file)
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -940,15 +940,10 @@ sub random_ether_addr {
 
     my $rand = Digest::SHA::sha1_hex($$, rand(), $seconds, $microseconds);
 
-# clear multicast, set local id
+    # clear multicast, set local id
     vec($rand, 0, 8) = (vec($rand, 0, 8) & 0xfe) | 2;
 
-    my $mac = sprintf("%02X:" x 6, unpack("C6", $rand));
-
-# remove superfluous ":" at end
-    chop($mac);
-
-    return $mac;
+    return sprintf("%02X:%02X:%02X:%02X:%02X:%02X", unpack("C6", $rand));
 }
 
 sub shellquote {