X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=blobdiff_plain;f=src%2FPVE%2FINotify.pm;h=60610ce507f467d20d66ea30a4e4ec6a38b1dbf1;hp=5fce0c8656f7405f48826ef894f56b63d9c72247;hb=aeac55e13854fe8d7aeeef545c3f5d65edc34971;hpb=516a50a4ac3b31fb1cfda672d25f99ec50f369e2

diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index 5fce0c8..60610ce 100644
--- a/src/PVE/INotify.pm
+++ b/src/PVE/INotify.pm
@@ -540,7 +540,7 @@ sub read_etc_resolv_conf {
 	chomp $line;
 	if ($line =~ m/^(search|domain)\s+(\S+)\s*/) {
 	    $res->{search} = $2;
-	} elsif ($line =~ m/^nameserver\s+(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})\s*/) {
+	} elsif ($line =~ m/^\s*nameserver\s+($PVE::Tools::IPRE)\s*/) {
 	    $nscount++;
 	    if ($nscount <= 3) {
 		$res->{"dns$nscount"} = $1;
@@ -874,6 +874,8 @@ sub __read_etc_network_interfaces {
 			}
 		    } elsif ($id eq 'bridge_fd') {
 			$d->{$id} = $value;
+		    } elsif ($id eq 'bridge_vlan_aware') {
+			$d->{$id} = 1;
 		    } elsif ($id eq 'bond_miimon') {
 			$d->{$id} = $value;
 		    } elsif ($id eq 'bond_xmit_hash_policy') {
@@ -959,6 +961,14 @@ sub __read_etc_network_interfaces {
 		$ifaces->{$1}->{exists} = 0;
 		$d->{exists} = 0;
 	    }
+	} elsif ($iface =~ m/^(\S+)\.\d+$/) {
+	    $d->{type} = 'vlan';
+	    if (defined ($ifaces->{$1})) {
+		$d->{exists} = $ifaces->{$1}->{exists};
+	    } else {
+		$ifaces->{$1}->{exists} = 0;
+		$d->{exists} = 0;
+	    }
 	} elsif ($iface =~ m/^eth\d+$/) {
 	    if (!$d->{ovs_type}) {
 		$d->{type} = 'eth';
@@ -1059,6 +1069,11 @@ sub __interface_to_string {
 	$v = defined($d->{bridge_fd}) ? $d->{bridge_fd} : 0;
 	$raw .= "\tbridge_fd $v\n";
 	$done->{bridge_fd} = 1;
+
+	if( defined($d->{bridge_vlan_aware})) {
+	    $raw .= "\tbridge_vlan_aware yes\n";
+	}
+	$done->{bridge_vlan_aware} = 1;
     
     } elsif ($d->{type} eq 'bond') {
 
@@ -1216,6 +1231,7 @@ sub __write_etc_network_interfaces {
 		my $n = $ifaces->{$p};
 		die "OVS bridge '$iface' - unable to find port '$p'\n"
 		    if !$n;
+		$n->{autostart} = 0;
 		if ($n->{type} eq 'eth') {
 		    $n->{type} = 'OVSPort';
 		    $n->{ovs_bridge} = $iface;		    
@@ -1260,60 +1276,60 @@ NETWORKDOC
     my $printed = {};
 
     my $if_type_hash = {
-	unknown => 0,
-	loopback => 10,
-	eth => 20,
-	bond => 30,
-	bridge => 40,
+	loopback => 100000,
+	eth => 200000,
+	bond => 300000,
+	bridge => 400000,
    };
 
     my $lookup_type_prio = sub {
 	my $iface = shift;
 
-	my $alias = 0;
-	if ($iface =~ m/^(\S+):\d+$/) {
+	my $child = 0;
+	if ($iface =~ m/^(\S+)(\.|:)\d+$/) {
 	    $iface = $1;
-	    $alias = 1;
+	    $child = 1;
 	}
 
 	my $pri;
 	if ($iface eq 'lo') {
 	    $pri = $if_type_hash->{loopback};
 	} elsif ($iface =~ m/^eth\d+$/) {
-	    $pri = $if_type_hash->{eth} + $alias;
+	    $pri = $if_type_hash->{eth} + $child;
 	} elsif ($iface =~ m/^bond\d+$/) {
-	    $pri = $if_type_hash->{bond} + $alias;
+	    $pri = $if_type_hash->{bond} + $child;
 	} elsif ($iface =~ m/^vmbr\d+$/) {
-	    $pri = $if_type_hash->{bridge} + $alias;
+	    $pri = $if_type_hash->{bridge} + $child;
 	}
 
-	return $pri || ($if_type_hash->{unknown} + $alias);
+	return $pri;
     };
 
     foreach my $iface (sort {
 	my $ref1 = $ifaces->{$a};
 	my $ref2 = $ifaces->{$b};
-	my $p1 = &$lookup_type_prio($a);
-	my $p2 = &$lookup_type_prio($b);
+	my $tp1 = &$lookup_type_prio($a);
+	my $tp2 = &$lookup_type_prio($b);
 
-	return $p1 <=> $p2 if $p1 != $p2;
+	# Only recognized types are in relation to each other. If one type
+	# is unknown then only consider the interfaces' priority attributes.
+	$tp1 = $tp2 = 0 if !defined($tp1) || !defined($tp2);
 
-	$p1 = $ref1->{priority} || 100000;
-	$p2 = $ref2->{priority} || 100000;
+	my $p1 = $tp1 + ($ref1->{priority} // 50000);
+	my $p2 = $tp2 + ($ref2->{priority} // 50000);
 
 	return $p1 <=> $p2 if $p1 != $p2;
 
 	return $a cmp $b;
-		       } keys %$ifaces) {
-
-	my $d = $ifaces->{$iface};
-
+    } keys %$ifaces) {
 	next if $printed->{$iface};
 
-	if (@options && $options[0]->[0] < $d->{priority}) {
+	my $d = $ifaces->{$iface};
+	my $pri = $d->{priority} // 0;
+	if (@options && $options[0]->[0] < $pri) {
 	    do {
 		$raw .= (shift @options)->[1] . "\n";
-	    } while (@options && $options[0]->[0] < $d->{priority});
+	    } while (@options && $options[0]->[0] < $pri);
 	    $raw .= "\n";
 	}