X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=blobdiff_plain;f=src%2FPVE%2FRESTHandler.pm;h=ca3f99b5b58e8a948cf9976db8ef4e76b94670ba;hp=ad76b01e410c85587692b4b232b98a4a237a1180;hb=2c2a5fd3df9c12f69aa1e8e36f4badd4fde92458;hpb=4845032a4636260385b59b55aabdb05c700fea2f diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm index ad76b01..ca3f99b 100644 --- a/src/PVE/RESTHandler.pm +++ b/src/PVE/RESTHandler.pm @@ -36,8 +36,8 @@ sub api_clone_schema { if ($p =~ m/^([a-z]+)(\d+)$/) { if ($2 == 0) { $p = "$1\[n\]"; - } else { - next; + } elsif (defined($d->{$1.'0'})) { + next; # only handle once for -xx0, but only if -xx0 exists } } $res->{$k}->{$p} = ref($pd) ? clone($pd) : $pd; @@ -407,7 +407,7 @@ sub handle { # $name: option name # $display_name: for example "-$name" of "<$name>", pass undef to use "$name:" # $phash: json schema property hash -# $format: 'asciidoc', 'pod' or 'text' +# $format: 'asciidoc', 'short', 'long' or 'full' # $style: 'config', 'arg' or 'fixed' my $get_property_description = sub { my ($name, $style, $phash, $format, $hidepw, $fileparams) = @_; @@ -466,7 +466,7 @@ my $get_property_description = sub { } $res .= "\n"; - } elsif ($format eq 'pod' || $format eq 'text') { + } elsif ($format eq 'short' || $format eq 'long' || $format eq 'full') { my $defaulttxt = ''; if (defined(my $dv = $phash->{default})) { @@ -512,9 +512,9 @@ my $get_property_description = sub { # on the command line (or single parameter name for lists) # $fixed_param ... do not generate and info about those parameters # $format: -# 'long' ... default (list all options) -# 'short' ... command line only (one line) -# 'full' ... also include description +# 'long' ... default (text, list all options) +# 'short' ... command line only (text, one line) +# 'full' ... text, include description # 'asciidoc' ... generate asciidoc for man pages (like 'full') # $hidepw ... hide password option (use this if you provide a read passwork callback) # $stringfilemap ... mapping for string parameters to file path parameters @@ -552,7 +552,7 @@ sub usage_str { foreach my $k (@$arg_param) { next if defined($fixed_param->{$k}); # just to be sure next if !$prop->{$k}; # just to be sure - $argdescr .= &$get_property_description($k, 'fixed', $prop->{$k}, 'text', 0); + $argdescr .= &$get_property_description($k, 'fixed', $prop->{$k}, $format, 0); } my $idx_param = {}; # -vlan\d+ -scsi\d+ @@ -574,8 +574,9 @@ sub usage_str { $base = "${name}[n]"; } - $opts .= &$get_property_description($base, 'arg', $prop->{$k}, 'text', - $hidepw, &$stringfilemap($name)); + my $mapping = defined($stringfilemap) ? &$stringfilemap($name) : undef; + $opts .= &$get_property_description($base, 'arg', $prop->{$k}, $format, + $hidepw, $mapping); if (!$prop->{$k}->{optional}) { $args .= " " if $args; @@ -639,6 +640,7 @@ sub dump_properties { $raw .= &$get_property_description($base, $style, $phash, $format, 0); } + return $raw; }