]> git.proxmox.com Git - pve-common.git/commit
inotify: network: improve "allow-hotplug" & "auto" interaction
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 24 Sep 2021 10:29:46 +0000 (12:29 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 29 Sep 2021 07:57:59 +0000 (09:57 +0200)
commit0dc7fd7b50918368ea3bed603eb2bb9a5cbdc982
tree991b486d8bd208656649abdeff59bbbafe4f5d14
parented946606164a7e035e5b8d90d15e4e5be61aa95d
inotify: network: improve "allow-hotplug" & "auto" interaction

commit c86cfb8bbd9b505d06b580582297fa670561437b dropped allow-hotplug
from the primary interfaces file completely on write, but that breaks
setups that come from plain Debian.

Instead, as stop-gap measurement, transform "allow-hotplug" to auto
in the PVE controlled config.

That avoids conflict and improves installing PVE on top of plain
Debian, as the interface still comes up after the first reboot.

But it is not ideal auto is not the same as hotplug, so we need to
also track that difference in the future, but that needs some
adaptions in the API too (change autostart from boolean to
string+enum or so=

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
src/PVE/INotify.pm
test/etc_network_interfaces/base-allow-hotplug [new file with mode: 0644]
test/etc_network_interfaces/base-auto-allow-hotplug [new file with mode: 0644]
test/etc_network_interfaces/t.base-auto-allow-hotplug.pl [new file with mode: 0644]