]> git.proxmox.com Git - pve-common.git/commit
network: get_local_ip_from_cidr: return unique IPs
authorFabian Ebner <f.ebner@proxmox.com>
Mon, 22 Feb 2021 13:24:07 +0000 (14:24 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 25 Feb 2021 11:30:24 +0000 (12:30 +0100)
commit1e55a6cd22fb24710dfedc7dfc87076f883e7579
treefbd3041d6958dabe24ec10a5c4e7eb2d11b8864d
parent3fae4d24a98e8ddef43e65b34f029c9ddcd6c4ed
network: get_local_ip_from_cidr: return unique IPs

to avoid erroring out when "multiple" addresses are configured on live
migration, when in fact it's the same IP multiple times.

Seems like the same problem for a caller in pve-cluster was fixed by checking
the uniqueness afterwards, see commit 266041169beb36c8892ca54265e2d91335307ffb
in pve-cluster. But there doesn't seem to be any caller relying on the current
behavior, and no additional information other than the addresses are returned,
so fix it here.

Reported here:
https://forum.proxmox.com/threads/live-migration-of-vms-via-full-mesh-network-could-not-get-ip-multiple-addresses-configured-on-local-node-for-network.84585/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
src/PVE/Network.pm