From: Dominik Csapak <d.csapak@proxmox.com>
Date: Wed, 18 May 2016 09:18:29 +0000 (+0200)
Subject: show warning when using VLAN 1 on a VLAN aware bridge
X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=commitdiff_plain;h=5d662b31b74ac171cb03378df4acc57a71d1c8e2;ds=sidebyside

show warning when using VLAN 1 on a VLAN aware bridge

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm
index 0a984ad..71af2b8 100644
--- a/src/PVE/Network.pm
+++ b/src/PVE/Network.pm
@@ -179,6 +179,8 @@ my $bridge_add_interface = sub {
 	if ($tag) {
 	    system("/sbin/bridge vlan add dev $iface vid $tag pvid untagged") == 0 ||
 	    die "unable to add vlan $tag to interface $iface\n";
+
+	    warn "Caution: Setting VLAN ID 1 on a VLAN aware bridge may be dangerous\n" if $tag == 1;
 	} else {
 	    system("/sbin/bridge vlan add dev $iface vid 2-4094") == 0 ||
 	    die "unable to add default vlan tags to interface $iface\n" if !$trunks;