From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Fri, 30 Oct 2015 09:31:00 +0000 (+0100)
Subject: Tools: make unshare behave like other perl syscalls
X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=commitdiff_plain;h=817c6be02c878f6a5b75669e3f70455675b51b7e

Tools: make unshare behave like other perl syscalls

Most syscall wrappers in perl return 1 on success and our
current use of Tools::unshare isn't using the return value
(yet), so let's fix this while we can.

Also it seems to make sense to use prototyping on syscalls
to add some compile-time argument checking.
---

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index c52a3d0..b6849f2 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1169,9 +1169,9 @@ sub parse_host_and_port {
     return; # nothing
 }
 
-sub unshare {
+sub unshare($) {
     my ($flags) = @_;
-    syscall 272, $flags;
+    return 0 == syscall(272, $flags);
 }
 
 1;