From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Fri, 15 Dec 2017 16:00:29 +0000 (+0100)
Subject: fork_worker: refactor passing $upid to parent for sync
X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=commitdiff_plain;h=95109cc44eb72e0b1b1a66b800a3f3cb99980eea

fork_worker: refactor passing $upid to parent for sync

STDOUT and $psync[1] are the same here, so no need to differ.
Also we do this only for letting the parent know tha we're ready, the
parent knows the UPID already as it was generated before forking.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index bab4a2e..0ad6dba 100644
--- a/src/PVE/RESTEnvironment.pm
+++ b/src/PVE/RESTEnvironment.pm
@@ -482,12 +482,8 @@ sub fork_worker {
 	}
 
 	# sync with parent (signal that we are ready)
-	if ($sync) {
-	    print "$upid\n";
-	} else {
-	    POSIX::write($psync[1], $upid, length ($upid));
-	    POSIX::close($psync[1]);
-	}
+	POSIX::write($psync[1], $upid, length ($upid));
+	POSIX::close($psync[1]) if !$sync; # don't need output pipe if async
 
 	my $readbuf = '';
 	# sync with parent (wait until parent is ready)