From: Dietmar Maurer <dietmar@proxmox.com>
Date: Fri, 2 Jan 2015 13:06:46 +0000 (+0100)
Subject: Daemon: new option to change user/group (setuid/setgid)
X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=commitdiff_plain;h=c4ad45cf200bc95db0b70c5a4f9b2b82cf27a4f8;ds=sidebyside

Daemon: new option to change user/group (setuid/setgid)
---

diff --git a/data/PVE/Daemon.pm b/data/PVE/Daemon.pm
index b069b99..9c001e8 100644
--- a/data/PVE/Daemon.pm
+++ b/data/PVE/Daemon.pm
@@ -12,9 +12,12 @@ package PVE::Daemon;
 # * handle worker processes (option 'max_workers')
 # * allow to restart while workers are still runningl
 #   (option 'leave_children_open_on_reload')
+# * run as different user using setuid/setgid
  
 use strict;
 use warnings;
+use English;
+
 use PVE::SafeSyslog;
 use PVE::INotify;
 
@@ -427,11 +430,30 @@ sub new {
 		$self->{$opt} = $value;
 	    } elsif ($opt eq 'leave_children_open_on_reload') {
 		$self->{$opt} = $value;
+	    } elsif ($opt eq 'setgid') {
+		$self->{$opt} = $value;
+	    } elsif ($opt eq 'setuid') {
+		$self->{$opt} = $value;
 	    } else {
 		die "unknown daemon option '$opt'\n";
 	    }
 	}
 	
+	if (my $gidstr = $self->{setgid}) {
+	    my $gid = getgrnam($gidstr) || die "getgrnam failed - $!\n";
+	    POSIX::setgid($gid) || die "setgid $gid failed - $!\n";
+	    $EGID = "$gid $gid"; # this calls setgroups
+	    # just to be sure
+	    die "detected strange gid\n" if !($GID eq "$gid $gid" && $EGID eq "$gid $gid");
+	}
+
+	if (my $uidstr = $self->{setuid}) {
+	    my $uid = getpwnam($uidstr) || die "getpwnam failed - $!\n";
+	    POSIX::setuid($uid) || die "setuid $uid failed - $!\n";
+	    # just to be sure
+	    die "detected strange uid\n" if !($UID == $uid && $EUID == $uid);
+	}
+
 	if ($restart && $self->{max_workers}) {
 	    if (my $wpids = $ENV{PVE_DAEMON_WORKER_PIDS}) {
 		foreach my $pid (split(':', $wpids)) {