From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Tue, 5 Jul 2016 10:40:23 +0000 (+0200)
Subject: fix mac address generation limitation
X-Git-Url: https://git.proxmox.com/?p=pve-common.git;a=commitdiff_plain;h=d743b69c4b16bab91a703a5a51c2ff65fb0fe31c

fix mac address generation limitation

Commit de9a267 introduced vec() to optimize the generation
by using binary operations instead of converting back and
forth between hex and strings, but forgot to switch over to
the binary sha1 method. This resulted in only the first 6
hex digits of the output string making up the address.
---

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 68c4e68..0d03b04 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -983,7 +983,7 @@ sub random_ether_addr {
 
     my ($seconds, $microseconds) = gettimeofday;
 
-    my $rand = Digest::SHA::sha1_hex($$, rand(), $seconds, $microseconds);
+    my $rand = Digest::SHA::sha1($$, rand(), $seconds, $microseconds);
 
     # clear multicast, set local id
     vec($rand, 0, 8) = (vec($rand, 0, 8) & 0xfe) | 2;