From 016d20715b5789030f8ed6a985cf692a206c31da Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 11 Apr 2023 15:09:20 +0200 Subject: [PATCH] cli handler: contain no-stricture scope to please perlcritic's highest severity level and as it makes just sense to contain such things to the smallest possible scope. Signed-off-by: Thomas Lamprecht --- src/PVE/CLIHandler.pm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 64de8f7..f96bcf6 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -538,11 +538,12 @@ sub generate_asciidoc_synopsis { $exename = &$get_exe_name($class); - no strict 'refs'; - my $def = ${"${class}::cmddef"}; - $cmddef = $def; + { + no strict 'refs'; ## no critic (ProhibitNoStrict) + $cmddef = ${"${class}::cmddef"}; + } - if (ref($def) eq 'ARRAY') { + if (ref($cmddef) eq 'ARRAY') { print_simple_asciidoc_synopsis(); } else { $cmddef->{help} = [ __PACKAGE__, 'help', ['cmd'] ]; @@ -660,8 +661,10 @@ sub run_cli_handler { my $logid = $ENV{PVE_LOG_ID} || $exename; initlog($logid); - no strict 'refs'; - $cmddef = ${"${class}::cmddef"}; + { + no strict 'refs'; ## no critic (ProhibitNoStrict) + $cmddef = ${"${class}::cmddef"}; + } if (ref($cmddef) eq 'ARRAY') { $handle_simple_cmd->(\@ARGV, $preparefunc, $param_cb); -- 2.39.2