From b15e50dda13024d631ff1659dbfee90442a928c8 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 8 Nov 2019 12:47:16 +0100 Subject: [PATCH] network: cleanup get_local_ip_from_cidr Signed-off-by: Thomas Lamprecht --- src/PVE/Network.pm | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index cc75445..e91aeb2 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -585,19 +585,12 @@ sub is_ip_in_cidr { sub get_local_ip_from_cidr { my ($cidr) = @_; - my $cmd = ['/sbin/ip', 'address', 'show', 'to', $cidr, 'up']; - my $IPs = []; - - my $code = sub { - my $line = shift; - - if ($line =~ m!^\s*inet(?:6)?\s+($PVE::Tools::IPRE)(?:/\d+|\s+peer\s+)!) { + run_command(['/sbin/ip', 'address', 'show', 'to', $cidr, 'up'], outfunc => sub { + if ($_[0] =~ m!^\s*inet(?:6)?\s+($PVE::Tools::IPRE)(?:/\d+|\s+peer\s+)!) { push @$IPs, $1; } - }; - - PVE::Tools::run_command($cmd, outfunc => $code); + }); return $IPs; } -- 2.39.2