From 390fc10dc4a696dd30646cbdd018ad08d855175f Mon Sep 17 00:00:00 2001 From: Oguz Bektas Date: Wed, 24 Mar 2021 14:20:36 +0100 Subject: [PATCH] daemon: create_reusable_socket: listen on IPv6 and IPv4 When the 'Domain' configuration of IO::Socket::IP is set to PF_INET6, it will prefer IPv6, but since we don't set 'V6Only' it will also listen on IPv4 interfaces[0]. Drop the now obsoleted '$family' parameter. [0]: https://perldoc.perl.org/IO::Socket::IP#REPLACING-IO::Socket-DEFAULT-BEHAVIOUR Signed-off-by: Oguz Bektas Signed-off-by: Thomas Lamprecht --- src/PVE/Daemon.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm index 64f8126..905635a 100644 --- a/src/PVE/Daemon.pm +++ b/src/PVE/Daemon.pm @@ -799,7 +799,7 @@ sub register_status_command { # some useful helper sub create_reusable_socket { - my ($self, $port, $host, $family) = @_; + my ($self, $port, $host) = @_; die "no port specifed" if !$port; @@ -820,10 +820,10 @@ sub create_reusable_socket { } else { $socket = IO::Socket::IP->new( - LocalAddr => $host, + Domain => PF_INET6, + LocalHost => $host, LocalPort => $port, Listen => SOMAXCONN, - Family => $family, Proto => 'tcp', GetAddrInfoFlags => 0, ReuseAddr => 1) || -- 2.39.2