From 85d5625a15f23743c7a117d2784989bf1457efae Mon Sep 17 00:00:00 2001
From: Dietmar Maurer <dietmar@proxmox.com>
Date: Fri, 9 Oct 2015 11:48:25 +0200
Subject: [PATCH] random_ether_addr: code cleanups

---
 src/PVE/Tools.pm | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index cda0797..32f36ac 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -940,15 +940,10 @@ sub random_ether_addr {
 
     my $rand = Digest::SHA::sha1_hex($$, rand(), $seconds, $microseconds);
 
-# clear multicast, set local id
+    # clear multicast, set local id
     vec($rand, 0, 8) = (vec($rand, 0, 8) & 0xfe) | 2;
 
-    my $mac = sprintf("%02X:" x 6, unpack("C6", $rand));
-
-# remove superfluous ":" at end
-    chop($mac);
-
-    return $mac;
+    return sprintf("%02X:%02X:%02X:%02X:%02X:%02X", unpack("C6", $rand));
 }
 
 sub shellquote {
-- 
2.39.2