From a45a1df1edfca28af24b6f617ca9b8f95152280a Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Thu, 13 Jan 2022 14:50:14 +0100 Subject: [PATCH] small code/comment cleanups Signed-off-by: Thomas Lamprecht --- src/PVE/Daemon.pm | 4 +--- src/PVE/RESTHandler.pm | 3 +-- src/PVE/Tools.pm | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm index 2ab4f35..032cb27 100644 --- a/src/PVE/Daemon.pm +++ b/src/PVE/Daemon.pm @@ -243,8 +243,7 @@ sub setup { initlog($self->{name}); - my $restart = $ENV{RESTART_PVE_DAEMON}; - delete $ENV{RESTART_PVE_DAEMON}; + my $restart = delete $ENV{RESTART_PVE_DAEMON}; $self->{env_restart_pve_daemon} = $restart; my $lockfd = $ENV{PVE_DAEMON_LOCK_FD}; @@ -573,7 +572,6 @@ my $read_pid = sub { # checks if the process was started by systemd my $init_ppid = sub { - if (getppid() == 1) { return 1; } else { diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm index b9e27e9..4f1458b 100644 --- a/src/PVE/RESTHandler.pm +++ b/src/PVE/RESTHandler.pm @@ -69,8 +69,7 @@ sub api_clone_schema { } } my $tmp = ref($pd) ? clone($pd) : $pd; - # NOTE: add typetext property for more complex types, to - # make the web api viewer code simpler + # NOTE: add typetext property for complexer types, to make the web api-viewer code simpler if (!$no_typetext && !(defined($tmp->{enum}) || defined($tmp->{pattern}))) { my $typetext = PVE::JSONSchema::schema_get_type_text($tmp); if ($tmp->{type} && ($tmp->{type} ne $typetext)) { diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 787942a..dac0a2b 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -1210,8 +1210,7 @@ sub decode_text { return Encode::decode("utf8", uri_unescape($data)); } -# depreciated - do not use! -# we now decode all parameters by default +# NOTE: deprecated - do not use! we now decode all parameters by default sub decode_utf8_parameters { my ($param) = @_; -- 2.39.2