From f44838ff41533c18db98ec1a39bb7bd696b4343d Mon Sep 17 00:00:00 2001 From: Oguz Bektas Date: Tue, 15 Mar 2022 12:52:39 +0100 Subject: [PATCH] RESTenv: fork worker: fallback to 'root@pam' for task log user-id The fallback had a "typo" in the realm and used 'root@pve' (pve vs. pam) since initial import from SVN, but off-list talks with Dietmar suggest that 'root@pam' was always the intended fallback value. Call sites without a defined user parameter (found only push_file and pull_file from pve-container) were logging the task-owner user as 'root@pve' which isn't a default one, so it wouldn't exist in most setups. For clarity, add a comment that this is only used for the task logs. Signed-off-by: Oguz Bektas [ T: Reword/add to commit message slightly ] Signed-off-by: Thomas Lamprecht --- src/PVE/RESTEnvironment.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm index 1b2af08..abe388b 100644 --- a/src/PVE/RESTEnvironment.pm +++ b/src/PVE/RESTEnvironment.pm @@ -492,7 +492,8 @@ sub fork_worker { $dtype = 'unknown' if !defined ($dtype); $id = '' if !defined ($id); - $user = 'root@pve' if !defined ($user); + # note: below is only used for the task log entry + $user = $self->get_user(1) // 'root@pam' if !defined($user); my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0; -- 2.39.2