From 2e8f585778181306a90accbc9bf355b8e61c442e Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 21 Oct 2022 15:20:34 +0200 Subject: [PATCH] lxc: fix perl-prototyep of mountpoint_hotplug The original commit b2de4c048ee50094593f4f8ffd18b6c346f7157a copy-pasta'd the wrong prototype, missing two scalar $ arguments. Until recently perl did not care as those things are only checked _somewhat_ on "compile" (module load) times, and the one (single?) call site in PVE::LXC::Config missed the `use PVE::LXC` statement, and so the module-load did not see the wrong prototype and thus did not cared, on runtime all is different anyway (what a mess). The recent commit 11066f6bfdca5225a6f872d5664e6637ccb58dd6 added that use statement and made package compilation implode, almost like spooky actions in the time-space distance... Fixes: b2de4c048ee50094593f4f8ffd18b6c346f7157a Signed-off-by: Thomas Lamprecht --- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index fe63087..333286a 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1814,7 +1814,7 @@ sub __mountpoint_mount { die "unsupported storage"; } -sub mountpoint_hotplug($$$) { +sub mountpoint_hotplug :prototype($$$$$) { my ($vmid, $conf, $opt, $mp, $storage_cfg) = @_; my (undef, $rootuid, $rootgid) = PVE::LXC::parse_id_maps($conf); -- 2.39.2