From 44f286589830cb7af5efb772b0415bfe420b7def Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Thu, 15 Sep 2022 11:45:44 +0200 Subject: [PATCH] d/scripts/prepare-changes: make argument check more robust set -u aborts if we access any undefined variable, which $1 can be if no argument got passed.. Signed-off-by: Thomas Lamprecht --- debian/scripts/prepare-changes.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/debian/scripts/prepare-changes.sh b/debian/scripts/prepare-changes.sh index b22404e..f523b61 100755 --- a/debian/scripts/prepare-changes.sh +++ b/debian/scripts/prepare-changes.sh @@ -2,7 +2,8 @@ set -eu -o pipefail -if [[ $1 =~ ^-(h|-help)$ ]]; then +arg="${1:-}" +if [[ $arg =~ ^-(h|-help)$ ]]; then echo "usage: $0 []" echo "" echo "Filter out irrelevant entries (sponsors, chore, docs) from the upstream changelog." @@ -24,8 +25,8 @@ sed -i '/ ci: /Id' "$cfn" sed -i '/ build: /Id' "$cfn" sed -i '/ESLint Jenkins/Id' "$cfn" -if [[ $1 ]]; then - version="$1" +if [[ $arg ]]; then + version="$arg" sed -i "/^$version -/Q" "$cfn" sed -i '/^\+ /!d' "$cfn" fi -- 2.39.2