PVE/Firewall.pm

   1 package PVE::Firewall;
   2
   3 use warnings;
   4 use strict;
   5 use Data::Dumper;
   6 use Digest::SHA;
   7 use PVE::Tools;
   8 use PVE::QemuServer;
   9 use File::Path;
  10 use IO::File;
  11 use Net::IP;
  12 use PVE::Tools qw(run_command lock_file);
  13
  14 use Data::Dumper;
  15
  16 my $pve_fw_lock_filename = "/var/lock/pvefw.lck";
  17
  18 # todo: define more MACROS
  19 # imported/converted from: /usr/share/shorewall/macro.*
  20 my $pve_fw_macros = {
  21     'Amanda' => [
  22         { action => 'PARAM', proto => 'udp', dport => '10080' },
  23         { action => 'PARAM', proto => 'tcp', dport => '10080' },
  24     ],
  25     'Auth' => [
  26         { action => 'PARAM', proto => 'tcp', dport => '113' },
  27     ],
  28     'BGP' => [
  29         { action => 'PARAM', proto => 'tcp', dport => '179' },
  30     ],
  31     'BitTorrent' => [
  32         { action => 'PARAM', proto => 'tcp', dport => '6881:6889' },
  33         { action => 'PARAM', proto => 'udp', dport => '6881' },
  34     ],
  35     'BitTorrent32' => [
  36         { action => 'PARAM', proto => 'tcp', dport => '6881:6999' },
  37         { action => 'PARAM', proto => 'udp', dport => '6881' },
  38     ],
  39     'CVS' => [
  40         { action => 'PARAM', proto => 'tcp', dport => '2401' },
  41     ],
  42     'Citrix' => [
  43         { action => 'PARAM', proto => 'tcp', dport => '1494' },
  44         { action => 'PARAM', proto => 'udp', dport => '1604' },
  45         { action => 'PARAM', proto => 'tcp', dport => '2598' },
  46     ],
  47     'DAAP' => [
  48         { action => 'PARAM', proto => 'tcp', dport => '3689' },
  49         { action => 'PARAM', proto => 'udp', dport => '3689' },
  50     ],
  51     'DCC' => [
  52         { action => 'PARAM', proto => 'tcp', dport => '6277' },
  53     ],
  54     'DHCPfwd' => [
  55         { action => 'PARAM', proto => 'udp', dport => '67:68', sport => '67:68' },
  56         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '67:68', sport => '67:68' },
  57     ],
  58     'DNS' => [
  59         { action => 'PARAM', proto => 'udp', dport => '53' },
  60         { action => 'PARAM', proto => 'tcp', dport => '53' },
  61     ],
  62     'Distcc' => [
  63         { action => 'PARAM', proto => 'tcp', dport => '3632' },
  64     ],
  65     'Edonkey' => [
  66         { action => 'PARAM', proto => 'tcp', dport => '4662' },
  67         { action => 'PARAM', proto => 'udp', dport => '4665' },
  68     ],
  69     'FTP' => [
  70         { action => 'PARAM', proto => 'tcp', dport => '21' },
  71     ],
  72     'Finger' => [
  73         { action => 'PARAM', proto => 'tcp', dport => '79' },
  74     ],
  75     'GNUnet' => [
  76         { action => 'PARAM', proto => 'tcp', dport => '2086' },
  77         { action => 'PARAM', proto => 'udp', dport => '2086' },
  78         { action => 'PARAM', proto => 'tcp', dport => '1080' },
  79         { action => 'PARAM', proto => 'udp', dport => '1080' },
  80     ],
  81     'GRE' => [
  82         { action => 'PARAM', proto => '47' },
  83         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '47' },
  84     ],
  85     'Git' => [
  86         { action => 'PARAM', proto => 'tcp', dport => '9418' },
  87     ],
  88     'Gnutella' => [
  89         { action => 'PARAM', proto => 'tcp', dport => '6346' },
  90         { action => 'PARAM', proto => 'udp', dport => '6346' },
  91     ],
  92     'HKP' => [
  93         { action => 'PARAM', proto => 'tcp', dport => '11371' },
  94     ],
  95     'HTTP' => [
  96         { action => 'PARAM', proto => 'tcp', dport => '80' },
  97     ],
  98     'HTTPS' => [
  99         { action => 'PARAM', proto => 'tcp', dport => '443' },
 100     ],
 101     'ICPV2' => [
 102         { action => 'PARAM', proto => 'udp', dport => '3130' },
 103     ],
 104     'ICQ' => [
 105         { action => 'PARAM', proto => 'tcp', dport => '5190' },
 106     ],
 107     'IMAP' => [
 108         { action => 'PARAM', proto => 'tcp', dport => '143' },
 109     ],
 110     'IMAPS' => [
 111         { action => 'PARAM', proto => 'tcp', dport => '993' },
 112     ],
 113     'IPIP' => [
 114         { action => 'PARAM', proto => '94' },
 115         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '94' },
 116     ],
 117     'IPP' => [
 118         { action => 'PARAM', proto => 'tcp', dport => '631' },
 119     ],
 120     'IPPbrd' => [
 121         { action => 'PARAM', proto => 'udp', dport => '631' },
 122     ],
 123     'IPPserver' => [
 124         { action => 'PARAM', source => 'SOURCE', dest => 'DEST', proto => 'tcp', dport => '631' },
 125         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '631' },
 126     ],
 127     'IPsec' => [
 128         { action => 'PARAM', proto => 'udp', dport => '500', sport => '500' },
 129         { action => 'PARAM', proto => '50' },
 130         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '500', sport => '500' },
 131         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '50' },
 132     ],
 133     'IPsecah' => [
 134         { action => 'PARAM', proto => 'udp', dport => '500', sport => '500' },
 135         { action => 'PARAM', proto => '51' },
 136         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '500', sport => '500' },
 137         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '51' },
 138     ],
 139     'IPsecnat' => [
 140         { action => 'PARAM', proto => 'udp', dport => '500' },
 141         { action => 'PARAM', proto => 'udp', dport => '4500' },
 142         { action => 'PARAM', proto => '50' },
 143         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '500' },
 144         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '4500' },
 145         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '50' },
 146     ],
 147     'IRC' => [
 148         { action => 'PARAM', proto => 'tcp', dport => '6667' },
 149     ],
 150     'JabberPlain' => [
 151         { action => 'PARAM', proto => 'tcp', dport => '5222' },
 152     ],
 153     'JabberSecure' => [
 154         { action => 'PARAM', proto => 'tcp', dport => '5223' },
 155     ],
 156     'Jabberd' => [
 157         { action => 'PARAM', proto => 'tcp', dport => '5269' },
 158     ],
 159     'Jetdirect' => [
 160         { action => 'PARAM', proto => 'tcp', dport => '9100' },
 161     ],
 162     'L2TP' => [
 163         { action => 'PARAM', proto => 'udp', dport => '1701' },
 164         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '1701' },
 165     ],
 166     'LDAP' => [
 167         { action => 'PARAM', proto => 'tcp', dport => '389' },
 168     ],
 169     'LDAPS' => [
 170         { action => 'PARAM', proto => 'tcp', dport => '636' },
 171     ],
 172     'MSNP' => [
 173         { action => 'PARAM', proto => 'tcp', dport => '1863' },
 174     ],
 175     'MSSQL' => [
 176         { action => 'PARAM', proto => 'tcp', dport => '1433' },
 177     ],
 178     'Mail' => [
 179         { action => 'PARAM', proto => 'tcp', dport => '25' },
 180         { action => 'PARAM', proto => 'tcp', dport => '465' },
 181         { action => 'PARAM', proto => 'tcp', dport => '587' },
 182     ],
 183     'Munin' => [
 184         { action => 'PARAM', proto => 'tcp', dport => '4949' },
 185     ],
 186     'MySQL' => [
 187         { action => 'PARAM', proto => 'tcp', dport => '3306' },
 188     ],
 189     'NNTP' => [
 190         { action => 'PARAM', proto => 'tcp', dport => '119' },
 191     ],
 192     'NNTPS' => [
 193         { action => 'PARAM', proto => 'tcp', dport => '563' },
 194     ],
 195     'NTP' => [
 196         { action => 'PARAM', proto => 'udp', dport => '123' },
 197     ],
 198     'NTPbi' => [
 199         { action => 'PARAM', proto => 'udp', dport => '123' },
 200         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '123' },
 201     ],
 202     'NTPbrd' => [
 203         { action => 'PARAM', proto => 'udp', dport => '123' },
 204         { action => 'PARAM', proto => 'udp', dport => '1024:65535', sport => '123' },
 205     ],
 206     'OSPF' => [
 207         { action => 'PARAM', proto => '89' },
 208     ],
 209     'OpenVPN' => [
 210         { action => 'PARAM', proto => 'udp', dport => '1194' },
 211     ],
 212     'PCA' => [
 213         { action => 'PARAM', proto => 'udp', dport => '5632' },
 214         { action => 'PARAM', proto => 'tcp', dport => '5631' },
 215     ],
 216     'POP3' => [
 217         { action => 'PARAM', proto => 'tcp', dport => '110' },
 218     ],
 219     'POP3S' => [
 220         { action => 'PARAM', proto => 'tcp', dport => '995' },
 221     ],
 222     'PPtP' => [
 223         { action => 'PARAM', proto => '47' },
 224         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '47' },
 225         { action => 'PARAM', proto => 'tcp', dport => '1723' },
 226     ],
 227     'Ping' => [
 228         { action => 'PARAM', proto => 'icmp', dport => '8' },
 229     ],
 230     'PostgreSQL' => [
 231         { action => 'PARAM', proto => 'tcp', dport => '5432' },
 232     ],
 233     'Printer' => [
 234         { action => 'PARAM', proto => 'tcp', dport => '515' },
 235     ],
 236     'RDP' => [
 237         { action => 'PARAM', proto => 'tcp', dport => '3389' },
 238     ],
 239     'RIPbi' => [
 240         { action => 'PARAM', proto => 'udp', dport => '520' },
 241         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '520' },
 242     ],
 243     'RNDC' => [
 244         { action => 'PARAM', proto => 'tcp', dport => '953' },
 245     ],
 246     'Razor' => [
 247         { action => 'ACCEPT', proto => 'tcp', dport => '2703' },
 248     ],
 249     'Rdate' => [
 250         { action => 'PARAM', proto => 'tcp', dport => '37' },
 251     ],
 252     'Rsync' => [
 253         { action => 'PARAM', proto => 'tcp', dport => '873' },
 254     ],
 255     'SANE' => [
 256         { action => 'PARAM', proto => 'tcp', dport => '6566' },
 257     ],
 258     'SMB' => [
 259         { action => 'PARAM', proto => 'udp', dport => '135,445' },
 260         { action => 'PARAM', proto => 'udp', dport => '137:139' },
 261         { action => 'PARAM', proto => 'udp', dport => '1024:65535', sport => '137' },
 262         { action => 'PARAM', proto => 'tcp', dport => '135,139,445' },
 263     ],
 264     'SMBBI' => [
 265         { action => 'PARAM', proto => 'udp', dport => '135,445' },
 266         { action => 'PARAM', proto => 'udp', dport => '137:139' },
 267         { action => 'PARAM', proto => 'udp', dport => '1024:65535', sport => '137' },
 268         { action => 'PARAM', proto => 'tcp', dport => '135,139,445' },
 269         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '135,445' },
 270         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '137:139' },
 271         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '1024:65535', sport => '137' },
 272         { action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'tcp', dport => '135,139,445' },
 273     ],
 274     'SMBswat' => [
 275         { action => 'PARAM', proto => 'tcp', dport => '901' },
 276     ],
 277     'SMTP' => [
 278         { action => 'PARAM', proto => 'tcp', dport => '25' },
 279     ],
 280     'SMTPS' => [
 281         { action => 'PARAM', proto => 'tcp', dport => '465' },
 282     ],
 283     'SNMP' => [
 284         { action => 'PARAM', proto => 'udp', dport => '161:162' },
 285         { action => 'PARAM', proto => 'tcp', dport => '161' },
 286     ],
 287     'SPAMD' => [
 288         { action => 'PARAM', proto => 'tcp', dport => '783' },
 289     ],
 290     'SSH' => [
 291         { action => 'PARAM', proto => 'tcp', dport => '22' },
 292     ],
 293     'SVN' => [
 294         { action => 'PARAM', proto => 'tcp', dport => '3690' },
 295     ],
 296     'SixXS' => [
 297         { action => 'PARAM', proto => 'tcp', dport => '3874' },
 298         { action => 'PARAM', proto => 'udp', dport => '3740' },
 299         { action => 'PARAM', proto => '41' },
 300         { action => 'PARAM', proto => 'udp', dport => '5072,8374' },
 301     ],
 302     'Squid' => [
 303         { action => 'PARAM', proto => 'tcp', dport => '3128' },
 304     ],
 305     'Submission' => [
 306         { action => 'PARAM', proto => 'tcp', dport => '587' },
 307     ],
 308     'Syslog' => [
 309         { action => 'PARAM', proto => 'udp', dport => '514' },
 310         { action => 'PARAM', proto => 'tcp', dport => '514' },
 311     ],
 312     'TFTP' => [
 313         { action => 'PARAM', proto => 'udp', dport => '69' },
 314     ],
 315     'Telnet' => [
 316         { action => 'PARAM', proto => 'tcp', dport => '23' },
 317     ],
 318     'Telnets' => [
 319         { action => 'PARAM', proto => 'tcp', dport => '992' },
 320     ],
 321     'Time' => [
 322         { action => 'PARAM', proto => 'tcp', dport => '37' },
 323     ],
 324     'Trcrt' => [
 325         { action => 'PARAM', proto => 'udp', dport => '33434:33524' },
 326         { action => 'PARAM', proto => 'icmp', dport => '8' },
 327     ],
 328     'VNC' => [
 329         { action => 'PARAM', proto => 'tcp', dport => '5900:5909' },
 330     ],
 331     'VNCL' => [
 332         { action => 'PARAM', proto => 'tcp', dport => '5500' },
 333     ],
 334     'Web' => [
 335         { action => 'PARAM', proto => 'tcp', dport => '80' },
 336         { action => 'PARAM', proto => 'tcp', dport => '443' },
 337     ],
 338     'Webcache' => [
 339         { action => 'PARAM', proto => 'tcp', dport => '8080' },
 340     ],
 341     'Webmin' => [
 342         { action => 'PARAM', proto => 'tcp', dport => '10000' },
 343     ],
 344     'Whois' => [
 345         { action => 'PARAM', proto => 'tcp', dport => '43' },
 346     ],
 347 };
 348
 349 my $pve_fw_parsed_macros;
 350 my $pve_fw_preferred_macro_names = {};
 351
 352 sub get_firewall_macros {
 353
 354     return $pve_fw_parsed_macros if $pve_fw_parsed_macros;
 355
 356     $pve_fw_parsed_macros = {};
 357
 358     foreach my $k (keys %$pve_fw_macros) {
 359         my $name = lc($k);
 360
 361         my $macro =  $pve_fw_macros->{$k};
 362         $pve_fw_preferred_macro_names->{$name} = $k;
 363         $pve_fw_parsed_macros->{$name} = $macro;
 364     }
 365
 366     return $pve_fw_parsed_macros;
 367 }
 368
 369 my $etc_services;
 370
 371 sub get_etc_services {
 372
 373     return $etc_services if $etc_services;
 374
 375     my $filename = "/etc/services";
 376
 377     my $fh = IO::File->new($filename, O_RDONLY);
 378     if (!$fh) {
 379         warn "unable to read '$filename' - $!\n";
 380         return {};
 381     }
 382
 383     my $services = {};
 384
 385     while (my $line = <$fh>) {
 386         chomp ($line);
 387         next if $line =~m/^#/;
 388         next if ($line =~m/^\s*$/);
 389
 390         if ($line =~ m!^(\S+)\s+(\S+)/(tcp|udp).*$!) {
 391             $services->{byid}->{$2}->{name} = $1;
 392             $services->{byid}->{$2}->{$3} = 1;
 393             $services->{byname}->{$1} = $services->{byid}->{$2};
 394         }
 395     }
 396
 397     close($fh);
 398
 399     $etc_services = $services;
 400
 401
 402     return $etc_services;
 403 }
 404
 405 my $etc_protocols;
 406
 407 sub get_etc_protocols {
 408     return $etc_protocols if $etc_protocols;
 409
 410     my $filename = "/etc/protocols";
 411
 412     my $fh = IO::File->new($filename, O_RDONLY);
 413     if (!$fh) {
 414         warn "unable to read '$filename' - $!\n";
 415         return {};
 416     }
 417
 418     my $protocols = {};
 419
 420     while (my $line = <$fh>) {
 421         chomp ($line);
 422         next if $line =~m/^#/;
 423         next if ($line =~m/^\s*$/);
 424
 425         if ($line =~ m!^(\S+)\s+(\d+)\s+.*$!) {
 426             $protocols->{byid}->{$2}->{name} = $1;
 427             $protocols->{byname}->{$1} = $protocols->{byid}->{$2};
 428         }
 429     }
 430
 431     close($fh);
 432
 433     $etc_protocols = $protocols;
 434
 435     return $etc_protocols;
 436 }
 437
 438 sub parse_address_list {
 439     my ($str) = @_;
 440
 441     my $nbaor = 0;
 442     foreach my $aor (split(/,/, $str)) {
 443         if (!Net::IP->new($aor)) {
 444             my $err = Net::IP::Error();
 445             die "invalid IP address: $err\n";
 446         }else{
 447             $nbaor++;
 448         }
 449     }
 450     return $nbaor;
 451 }
 452
 453 sub parse_port_name_number_or_range {
 454     my ($str) = @_;
 455
 456     my $services = PVE::Firewall::get_etc_services();
 457     my $nbports = 0;
 458     foreach my $item (split(/,/, $str)) {
 459         my $portlist = "";
 460         foreach my $pon (split(':', $item, 2)) {
 461             if ($pon =~ m/^\d+$/){
 462                 die "invalid port '$pon'\n" if $pon < 0 && $pon > 65535;
 463             }else{
 464                 die "invalid port $services->{byname}->{$pon}\n" if !$services->{byname}->{$pon};
 465             }
 466             $nbports++;
 467         }
 468     }
 469
 470     return ($nbports);
 471 }
 472
 473 my $bridge_firewall_enabled = 0;
 474
 475 sub enable_bridge_firewall {
 476
 477     return if $bridge_firewall_enabled; # only once
 478
 479     system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-iptables");
 480     system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-ip6tables");
 481
 482     $bridge_firewall_enabled = 1;
 483 }
 484
 485 my $rule_format = "%-15s %-30s %-30s %-15s %-15s %-15s\n";
 486
 487 sub iptables {
 488     my ($cmd) = @_;
 489
 490     run_command("/sbin/iptables $cmd", outfunc => sub {}, errfunc => sub {});
 491 }
 492
 493 sub iptables_restore_cmdlist {
 494     my ($cmdlist) = @_;
 495
 496     run_command("/sbin/iptables-restore -n", input => $cmdlist);
 497 }
 498
 499 sub iptables_get_chains {
 500
 501     my $res = {};
 502
 503     # check what chains we want to track
 504     my $is_pvefw_chain = sub {
 505         my $name = shift;
 506
 507         return 1 if $name =~ m/^PVEFW-\S+$/;
 508
 509         return 1 if $name =~ m/^tap\d+i\d+-(:?IN|OUT)$/;
 510         return 1 if $name =~ m/^vmbr\d+-(:?IN|OUT)$/;
 511         return 1 if $name =~ m/^GROUP-(:?[^\s\-]+)-(:?IN|OUT)$/;
 512
 513         return undef;
 514     };
 515
 516     my $table = '';
 517
 518     my $parser = sub {
 519         my $line = shift;
 520
 521         return if $line =~ m/^#/;
 522         return if $line =~ m/^\s*$/;
 523
 524         if ($line =~ m/^\*(\S+)$/) {
 525             $table = $1;
 526             return;
 527         }
 528
 529         return if $table ne 'filter';
 530
 531         if ($line =~ m/^:(\S+)\s/) {
 532             my $chain = $1;
 533             return if !&$is_pvefw_chain($chain);
 534             $res->{$chain} = "unknown";
 535         } elsif ($line =~ m/^-A\s+(\S+)\s.*--comment\s+\"PVESIG:(\S+)\"/) {
 536             my ($chain, $sig) = ($1, $2);
 537             return if !&$is_pvefw_chain($chain);
 538             $res->{$chain} = $sig;
 539         } else {
 540             # simply ignore the rest
 541             return;
 542         }
 543     };
 544
 545     run_command("/sbin/iptables-save", outfunc => $parser);
 546
 547     return $res;
 548 }
 549
 550 sub iptables_chain_exist {
 551     my ($chain) = @_;
 552
 553     eval{
 554         iptables("-n --list $chain");
 555     };
 556     return undef if $@;
 557
 558     return 1;
 559 }
 560
 561 sub iptables_rule_exist {
 562     my ($rule) = @_;
 563
 564     eval{
 565         iptables("-C $rule");
 566     };
 567     return undef if $@;
 568
 569     return 1;
 570 }
 571
 572 sub ruleset_generate_rule {
 573     my ($ruleset, $chain, $rule, $goto) = @_;
 574
 575     my $cmd = '';
 576
 577     $cmd .= " -m iprange --src-range" if $rule->{nbsource} && $rule->{nbsource} > 1;
 578     $cmd .= " -s $rule->{source}" if $rule->{source};
 579     $cmd .= " -m iprange --dst-range" if $rule->{nbdest} && $rule->{nbdest} > 1;
 580     $cmd .= " -d $rule->{dest}" if $rule->{dest};
 581     $cmd .= " -p $rule->{proto}" if $rule->{proto};
 582     $cmd .= "  --match multiport" if $rule->{nbdport} && $rule->{nbdport} > 1;
 583     $cmd .= " --dport $rule->{dport}" if $rule->{dport};
 584     $cmd .= "  --match multiport" if $rule->{nbsport} && $rule->{nbsport} > 1;
 585     $cmd .= " --sport $rule->{sport}" if $rule->{sport};
 586
 587     if (my $action = $rule->{action}) {
 588         $goto = 1 if !defined($goto) && $action eq 'PVEFW-SET-ACCEPT-MARK';
 589         $cmd .= $goto ? " -g $action" : " -j $action";
 590     };
 591
 592     ruleset_addrule($ruleset, $chain, $cmd) if $cmd;
 593 }
 594
 595 sub ruleset_create_chain {
 596     my ($ruleset, $chain) = @_;
 597
 598     die "Invalid chain name '$chain' (28 char max)\n" if length($chain) > 28;
 599
 600     die "chain '$chain' already exists\n" if $ruleset->{$chain};
 601
 602     $ruleset->{$chain} = [];
 603 }
 604
 605 sub ruleset_chain_exist {
 606     my ($ruleset, $chain) = @_;
 607
 608     return $ruleset->{$chain} ? 1 : undef;
 609 }
 610
 611 sub ruleset_addrule {
 612    my ($ruleset, $chain, $rule) = @_;
 613
 614    die "no such chain '$chain'\n" if !$ruleset->{$chain};
 615
 616    push @{$ruleset->{$chain}}, "-A $chain $rule";
 617 }
 618
 619 sub ruleset_insertrule {
 620    my ($ruleset, $chain, $rule) = @_;
 621
 622    die "no such chain '$chain'\n" if !$ruleset->{$chain};
 623
 624    unshift @{$ruleset->{$chain}}, "-A $chain $rule";
 625 }
 626
 627 sub generate_bridge_chains {
 628     my ($ruleset, $bridge) = @_;
 629
 630     if (!ruleset_chain_exist($ruleset, "PVEFW-BRIDGE-IN")){
 631         ruleset_create_chain($ruleset, "PVEFW-BRIDGE-IN");
 632     }
 633
 634     if (!ruleset_chain_exist($ruleset, "PVEFW-BRIDGE-OUT")){
 635         ruleset_create_chain($ruleset, "PVEFW-BRIDGE-OUT");
 636     }
 637
 638     if (!ruleset_chain_exist($ruleset, "PVEFW-FORWARD")){
 639         ruleset_create_chain($ruleset, "PVEFW-FORWARD");
 640
 641         ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m state --state RELATED,ESTABLISHED -j ACCEPT");
 642         ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m physdev --physdev-is-in --physdev-is-bridged -j PVEFW-BRIDGE-OUT");
 643         ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m physdev --physdev-is-out --physdev-is-bridged -j PVEFW-BRIDGE-IN");
 644     }
 645
 646     if (!ruleset_chain_exist($ruleset, "$bridge-IN")) {
 647         ruleset_create_chain($ruleset, "$bridge-IN");
 648         ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j DROP");  # disable interbridge routing
 649         ruleset_addrule($ruleset, "PVEFW-BRIDGE-IN", "-j $bridge-IN");
 650         ruleset_addrule($ruleset, "$bridge-IN", "-j ACCEPT");
 651     }
 652
 653     if (!ruleset_chain_exist($ruleset, "$bridge-OUT")) {
 654         ruleset_create_chain($ruleset, "$bridge-OUT");
 655         ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j DROP"); # disable interbridge routing
 656         ruleset_addrule($ruleset, "PVEFW-BRIDGE-OUT", "-j $bridge-OUT");
 657     }
 658 }
 659
 660 sub generate_tap_rules_direction {
 661     my ($ruleset, $group_rules, $iface, $netid, $macaddr, $rules, $bridge, $direction) = @_;
 662
 663     my $tapchain = "$iface-$direction";
 664
 665     ruleset_create_chain($ruleset, $tapchain);
 666
 667     ruleset_addrule($ruleset, $tapchain, "-m state --state INVALID -j DROP");
 668     ruleset_addrule($ruleset, $tapchain, "-m state --state RELATED,ESTABLISHED -j ACCEPT");
 669
 670     if ($direction eq 'OUT' && defined($macaddr)) {
 671         ruleset_addrule($ruleset, $tapchain, "-m mac ! --mac-source $macaddr -j DROP");
 672     }
 673
 674     if ($rules) {
 675         foreach my $rule (@$rules) {
 676             next if $rule->{iface} && $rule->{iface} ne $netid;
 677             # we go to $bridge-IN if accept in out rules
 678             if($rule->{action}  =~ m/^(GROUP-(\S+))$/){
 679                 $rule->{action} .= "-$direction";
 680                 # generate empty group rule if don't exist
 681                 if(!ruleset_chain_exist($ruleset, $rule->{action})){
 682                     generate_group_rules($ruleset, $group_rules, $2);
 683                 }
 684                 ruleset_generate_rule($ruleset, $tapchain, $rule);
 685                 ruleset_addrule($ruleset, $tapchain, "-m mark --mark 1 -g $bridge-IN")
 686                     if $direction eq 'OUT';
 687             } else {
 688                 $rule->{action} = "$bridge-IN" if $rule->{action} eq 'ACCEPT' && $direction eq 'OUT';
 689                 ruleset_generate_rule($ruleset, $tapchain, $rule);
 690             }
 691         }
 692     }
 693
 694     ruleset_addrule($ruleset, $tapchain, "-j LOG --log-prefix \"$tapchain-dropped: \" --log-level 4");
 695     ruleset_addrule($ruleset, $tapchain, "-j DROP");
 696
 697     # plug the tap chain to bridge chain
 698     my $physdevdirection = $direction eq 'IN' ? "out" : "in";
 699     my $rule = "-m physdev --physdev-$physdevdirection $iface --physdev-is-bridged -j $tapchain";
 700     ruleset_insertrule($ruleset, "$bridge-$direction", $rule);
 701
 702     if ($direction eq 'OUT'){
 703         # add tap->host rules
 704         my $rule = "-m physdev --physdev-$physdevdirection $iface -j $tapchain";
 705         ruleset_addrule($ruleset, "PVEFW-INPUT", $rule);
 706     }
 707 }
 708
 709 sub enablehostfw {
 710     my ($ruleset, $rules, $group_rules) = @_;
 711
 712     # fixme: allow security groups
 713
 714     # host inbound firewall
 715     my $chain = "PVEFW-HOST-IN";
 716     ruleset_create_chain($ruleset, $chain);
 717
 718     ruleset_addrule($ruleset, $chain, "-m state --state INVALID -j DROP");
 719     ruleset_addrule($ruleset, $chain, "-m state --state RELATED,ESTABLISHED -j ACCEPT");
 720     ruleset_addrule($ruleset, $chain, "-i lo -j ACCEPT");
 721     ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
 722     ruleset_addrule($ruleset, $chain, "-p udp -m state --state NEW -m multiport --dports 5404,5405 -j ACCEPT");
 723     ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT");  #corosync
 724
 725     if ($rules->{in}) {
 726         foreach my $rule (@{$rules->{in}}) {
 727             # we use RETURN because we need to check also tap rules
 728             $rule->{action} = 'RETURN' if $rule->{action} eq 'ACCEPT';
 729             ruleset_generate_rule($ruleset, $chain, $rule);
 730         }
 731     }
 732
 733     ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-IN dropped: \" --log-level 4");
 734     ruleset_addrule($ruleset, $chain, "-j DROP");
 735
 736     # host outbound firewall
 737     $chain = "PVEFW-HOST-OUT";
 738     ruleset_create_chain($ruleset, $chain);
 739
 740     ruleset_addrule($ruleset, $chain, "-m state --state INVALID -j DROP");
 741     ruleset_addrule($ruleset, $chain, "-m state --state RELATED,ESTABLISHED -j ACCEPT");
 742     ruleset_addrule($ruleset, $chain, "-o lo -j ACCEPT");
 743     ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
 744     ruleset_addrule($ruleset, $chain, "-p udp -m state --state NEW -m multiport --dports 5404,5405 -j ACCEPT");
 745     ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
 746
 747     if ($rules->{out}) {
 748         foreach my $rule (@{$rules->{out}}) {
 749             # we use RETURN because we need to check also tap rules
 750             $rule->{action} = 'RETURN' if $rule->{action} eq 'ACCEPT';
 751             ruleset_generate_rule($ruleset, $chain, $rule);
 752         }
 753     }
 754
 755     ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-OUT dropped: \" --log-level 4");
 756     ruleset_addrule($ruleset, $chain, "-j DROP");
 757
 758     ruleset_addrule($ruleset, "PVEFW-OUTPUT", "-j PVEFW-HOST-OUT");
 759     ruleset_addrule($ruleset, "PVEFW-INPUT", "-j PVEFW-HOST-IN");
 760 }
 761
 762 sub generate_group_rules {
 763     my ($ruleset, $group_rules, $group) = @_;
 764
 765     my $rules = $group_rules->{$group};
 766
 767     die "no such security group '$group'\n" if !$rules;
 768
 769     my $chain = "GROUP-${group}-IN";
 770
 771     ruleset_create_chain($ruleset, $chain);
 772
 773     if ($rules->{in}) {
 774         foreach my $rule (@{$rules->{in}}) {
 775             ruleset_generate_rule($ruleset, $chain, $rule);
 776         }
 777     }
 778
 779     $chain = "GROUP-${group}-OUT";
 780
 781     ruleset_create_chain($ruleset, $chain);
 782     ruleset_addrule($ruleset, $chain, "-j MARK --set-mark 0"); # clear mark
 783
 784     if ($rules->{out}) {
 785         foreach my $rule (@{$rules->{out}}) {
 786             # we go the PVEFW-SET-ACCEPT-MARK Instead of ACCEPT) because we need to
 787             # check also other tap rules (and group rules can be set on any bridge,
 788             # so we can't go to VMBRXX-IN)
 789             $rule->{action} = 'PVEFW-SET-ACCEPT-MARK' if $rule->{action} eq 'ACCEPT';
 790             ruleset_generate_rule($ruleset, $chain, $rule);
 791         }
 792     }
 793 }
 794
 795 my $MAX_NETS = 32;
 796 my $valid_netdev_names = {};
 797 for (my $i = 0; $i < $MAX_NETS; $i++)  {
 798     $valid_netdev_names->{"net$i"} = 1;
 799 }
 800
 801 sub parse_fw_rule {
 802     my ($line, $need_iface, $allow_groups) = @_;
 803
 804     my $macros = get_firewall_macros();
 805     my $protocols = get_etc_protocols();
 806
 807     my ($action, $iface, $source, $dest, $proto, $dport, $sport);
 808
 809     $line =~ s/#.*$//;
 810
 811     my @data = split(/\s+/, $line);
 812     my $expected_elements = $need_iface ? 7 : 6;
 813
 814     die "wrong number of rule elements\n" if scalar(@data) > $expected_elements;
 815
 816     if ($need_iface) {
 817         ($action, $iface, $source, $dest, $proto, $dport, $sport) = @data
 818     } else {
 819         ($action, $source, $dest, $proto, $dport, $sport) =  @data;
 820     }
 821
 822     die "incomplete rule\n" if !$action;
 823
 824     my $macro;
 825     my $macro_name;
 826
 827     if ($action =~ m/^(ACCEPT|DROP|REJECT)$/) {
 828         # OK
 829     } elsif ($allow_groups && $action =~ m/^GROUP-(:?\S+)$/) {
 830         # OK
 831     } elsif ($action =~ m/^(\S+)\((ACCEPT|DROP|REJECT)\)$/) {
 832         ($macro_name, $action) = ($1, $2);
 833         my $lc_macro_name = lc($macro_name);
 834         my $preferred_name = $pve_fw_preferred_macro_names->{$lc_macro_name};
 835         $macro_name = $preferred_name if $preferred_name;
 836         $macro = $macros->{$lc_macro_name};
 837         die "unknown macro '$macro_name'\n" if !$macro;
 838     } else {
 839         die "unknown action '$action'\n";
 840     }
 841
 842     if ($need_iface) {
 843         $iface = undef if $iface && $iface eq '-';
 844         die "unknown interface '$iface'\n"
 845             if defined($iface) && !$valid_netdev_names->{$iface};
 846     }
 847
 848     $proto = undef if $proto && $proto eq '-';
 849     die "unknown protokol '$proto'\n" if $proto &&
 850         !(defined($protocols->{byname}->{$proto}) ||
 851           defined($protocols->{byid}->{$proto}));
 852
 853     $source = undef if $source && $source eq '-';
 854     $dest = undef if $dest && $dest eq '-';
 855
 856     $dport = undef if $dport && $dport eq '-';
 857     $sport = undef if $sport && $sport eq '-';
 858
 859     my $nbsource = undef;
 860     my $nbdest = undef;
 861
 862     $nbsource = parse_address_list($source) if $source;
 863     $nbdest = parse_address_list($dest) if $dest;
 864
 865     my $rules = [];
 866
 867     my $param = {
 868         action => $action,
 869         iface => $iface,
 870         source => $source,
 871         dest => $dest,
 872         nbsource => $nbsource,
 873         nbdest => $nbdest,
 874         proto => $proto,
 875         dport => $dport,
 876         sport => $sport,
 877     };
 878
 879     if ($macro) {
 880         foreach my $templ (@$macro) {
 881             my $rule = {};
 882             foreach my $k (keys %$templ) {
 883                 my $v = $templ->{$k};
 884                 if ($v eq 'PARAM') {
 885                     $v = $param->{$k};
 886                 } elsif ($v eq 'DEST') {
 887                     $v = $param->{dest};
 888                 } elsif ($v eq 'SOURCE') {
 889                     $v = $param->{source};
 890                 }
 891
 892                 die "missing parameter '$k' in macro '$macro_name'\n" if !defined($v);
 893                 $rule->{$k} = $v;
 894             }
 895             push @$rules, $rule;
 896         }
 897     } else {
 898         push @$rules, $param;
 899     }
 900
 901     foreach my $rule (@$rules) {
 902         $rule->{nbdport} = parse_port_name_number_or_range($rule->{dport})
 903             if defined($rule->{dport});
 904         $rule->{nbsport} = parse_port_name_number_or_range($rule->{sport})
 905             if defined($rule->{sport});
 906     }
 907
 908     return $rules;
 909 }
 910
 911 sub parse_vm_fw_rules {
 912     my ($filename, $fh) = @_;
 913
 914     my $res = { in => [], out => [] };
 915
 916     my $section;
 917
 918     while (defined(my $line = <$fh>)) {
 919         next if $line =~ m/^#/;
 920         next if $line =~ m/^\s*$/;
 921
 922         my $linenr = $fh->input_line_number();
 923         my $prefix = "$filename (line $linenr)";
 924
 925         if ($line =~ m/^\[(in|out)\]\s*$/i) {
 926             $section = lc($1);
 927             next;
 928         }
 929         if (!$section) {
 930             warn "$prefix: skip line - no section";
 931             next;
 932         }
 933
 934         my $rules;
 935         eval { $rules = parse_fw_rule($line, 1, 1); };
 936         if (my $err = $@) {
 937             warn "$prefix: $err";
 938             next;
 939         }
 940
 941         push @{$res->{$section}}, @$rules;
 942     }
 943
 944     return $res;
 945 }
 946
 947 sub parse_host_fw_rules {
 948     my ($filename, $fh) = @_;
 949
 950     my $res = { in => [], out => [] };
 951
 952     my $section;
 953
 954     while (defined(my $line = <$fh>)) {
 955         next if $line =~ m/^#/;
 956         next if $line =~ m/^\s*$/;
 957
 958         my $linenr = $fh->input_line_number();
 959         my $prefix = "$filename (line $linenr)";
 960
 961         if ($line =~ m/^\[(in|out)\]\s*$/i) {
 962             $section = lc($1);
 963             next;
 964         }
 965         if (!$section) {
 966             warn "$prefix: skip line - no section";
 967             next;
 968         }
 969
 970         my $rules;
 971         eval { $rules = parse_fw_rule($line, 1, 1); };
 972         if (my $err = $@) {
 973             warn "$prefix: $err";
 974             next;
 975         }
 976
 977         push @{$res->{$section}}, @$rules;
 978     }
 979
 980     return $res;
 981 }
 982
 983 sub parse_group_fw_rules {
 984     my ($filename, $fh) = @_;
 985
 986     my $section;
 987     my $group;
 988
 989     my $res = { in => [], out => [] };
 990
 991     while (defined(my $line = <$fh>)) {
 992         next if $line =~ m/^#/;
 993         next if $line =~ m/^\s*$/;
 994
 995         my $linenr = $fh->input_line_number();
 996         my $prefix = "$filename (line $linenr)";
 997
 998         if ($line =~ m/^\[(in|out):(\S+)\]\s*$/i) {
 999             $section = lc($1);
1000             $group = lc($2);
1001             next;
1002         }
1003         if (!$section || !$group) {
1004             warn "$prefix: skip line - no section";
1005             next;
1006         }
1007
1008         my $rules;
1009         eval { $rules = parse_fw_rule($line, 0, 0); };
1010         if (my $err = $@) {
1011             warn "$prefix: $err";
1012             next;
1013         }
1014
1015         push @{$res->{$group}->{$section}}, @$rules;
1016     }
1017
1018     return $res;
1019 }
1020
1021 sub run_locked {
1022     my ($code, @param) = @_;
1023
1024     my $timeout = 10;
1025
1026     my $res = lock_file($pve_fw_lock_filename, $timeout, $code, @param);
1027
1028     die $@ if $@;
1029
1030     return $res;
1031 }
1032
1033 sub read_local_vm_config {
1034
1035     my $openvz = {};
1036
1037     my $qemu = {};
1038
1039     my $list = PVE::QemuServer::config_list();
1040
1041     foreach my $vmid (keys %$list) {
1042         my $cfspath = PVE::QemuServer::cfs_config_path($vmid);
1043         if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
1044             $qemu->{$vmid} = $conf;
1045         }
1046     }
1047
1048     my $vmdata = { openvz => $openvz, qemu => $qemu };
1049
1050     return $vmdata;
1051 };
1052
1053 sub read_vm_firewall_rules {
1054     my ($vmdata) = @_;
1055     my $rules = {};
1056     foreach my $vmid (keys %{$vmdata->{qemu}}, keys %{$vmdata->{openvz}}) {
1057         my $filename = "/etc/pve/firewall/$vmid.fw";
1058         my $fh = IO::File->new($filename, O_RDONLY);
1059         next if !$fh;
1060
1061         $rules->{$vmid} = parse_vm_fw_rules($filename, $fh);
1062     }
1063
1064     return $rules;
1065 }
1066
1067 sub compile {
1068     my $vmdata = read_local_vm_config();
1069     my $rules = read_vm_firewall_rules($vmdata);
1070
1071     my $group_rules = {};
1072     my $filename = "/etc/pve/firewall/groups.fw";
1073     if (my $fh = IO::File->new($filename, O_RDONLY)) {
1074         $group_rules = parse_group_fw_rules($filename, $fh);
1075     }
1076
1077     #print Dumper($rules);
1078
1079     my $ruleset = {};
1080
1081     # setup host firewall rules
1082     ruleset_create_chain($ruleset, "PVEFW-INPUT");
1083     ruleset_create_chain($ruleset, "PVEFW-OUTPUT");
1084
1085     ruleset_create_chain($ruleset, "PVEFW-SET-ACCEPT-MARK");
1086     ruleset_addrule($ruleset, "PVEFW-SET-ACCEPT-MARK", "-j MARK --set-mark 1");
1087
1088     $filename = "/etc/pve/local/host.fw";
1089     if (my $fh = IO::File->new($filename, O_RDONLY)) {
1090         my $host_rules = parse_host_fw_rules($filename, $fh);
1091         enablehostfw($ruleset, $host_rules, $group_rules);
1092     }
1093
1094     # generate firewall rules for QEMU VMs
1095     foreach my $vmid (keys %{$vmdata->{qemu}}) {
1096         my $conf = $vmdata->{qemu}->{$vmid};
1097         next if !$rules->{$vmid};
1098
1099         foreach my $netid (keys %$conf) {
1100             next if $netid !~ m/^net(\d+)$/;
1101             my $net = PVE::QemuServer::parse_net($conf->{$netid});
1102             next if !$net;
1103             my $iface = "tap${vmid}i$1";
1104
1105             my $bridge = $net->{bridge};
1106             next if !$bridge; # fixme: ?
1107
1108             $bridge .= "v$net->{tag}" if $net->{tag};
1109
1110             generate_bridge_chains($ruleset, $bridge);
1111
1112             my $macaddr = $net->{macaddr};
1113             generate_tap_rules_direction($ruleset, $group_rules, $iface, $netid, $macaddr, $rules->{$vmid}->{in}, $bridge, 'IN');
1114             generate_tap_rules_direction($ruleset, $group_rules, $iface, $netid, $macaddr, $rules->{$vmid}->{out}, $bridge, 'OUT');
1115         }
1116     }
1117     return $ruleset;
1118 }
1119
1120 sub get_ruleset_status {
1121     my ($ruleset, $verbose) = @_;
1122
1123     my $active_chains = iptables_get_chains();
1124
1125     my $statushash = {};
1126
1127     foreach my $chain (sort keys %$ruleset) {
1128         my $digest = Digest::SHA->new('sha1');
1129         foreach my $cmd (@{$ruleset->{$chain}}) {
1130              $digest->add("$cmd\n");
1131         }
1132         my $sig = $digest->b64digest;
1133         $statushash->{$chain}->{sig} = $sig;
1134
1135         my $oldsig = $active_chains->{$chain};
1136         if (!defined($oldsig)) {
1137             $statushash->{$chain}->{action} = 'create';
1138         } else {
1139             if ($oldsig eq $sig) {
1140                 $statushash->{$chain}->{action} = 'exists';
1141             } else {
1142                 $statushash->{$chain}->{action} = 'update';
1143             }
1144         }
1145         print "$statushash->{$chain}->{action} $chain ($sig)\n" if $verbose;
1146         foreach my $cmd (@{$ruleset->{$chain}}) {
1147             print "\t$cmd\n" if $verbose;
1148         }
1149     }
1150
1151     foreach my $chain (sort keys %$active_chains) {
1152         if (!defined($ruleset->{$chain})) {
1153             my $sig = $active_chains->{$chain};
1154             $statushash->{$chain}->{action} = 'delete';
1155             $statushash->{$chain}->{sig} = $sig;
1156             print "delete $chain ($sig)\n" if $verbose;
1157         }
1158     }
1159
1160     return $statushash;
1161 }
1162
1163 sub print_ruleset {
1164     my ($ruleset) = @_;
1165
1166     get_ruleset_status($ruleset, 1);
1167 }
1168
1169 sub print_sig_rule {
1170     my ($chain, $sig) = @_;
1171
1172     # We just use this to store a SHA1 checksum used to detect changes
1173     return "-A $chain -m comment --comment \"PVESIG:$sig\"\n";
1174 }
1175
1176 sub apply_ruleset {
1177     my ($ruleset, $verbose) = @_;
1178
1179     enable_bridge_firewall();
1180
1181     my $cmdlist = "*filter\n"; # we pass this to iptables-restore;
1182
1183     my $statushash = get_ruleset_status($ruleset, $verbose);
1184
1185     # create missing chains first
1186     foreach my $chain (sort keys %$ruleset) {
1187         my $stat = $statushash->{$chain};
1188         die "internal error" if !$stat;
1189         next if $stat->{action} ne 'create';
1190
1191         $cmdlist .= ":$chain - [0:0]\n";
1192     }
1193
1194     my $rule = "INPUT -j PVEFW-INPUT";
1195     if (!PVE::Firewall::iptables_rule_exist($rule)) {
1196         $cmdlist .= "-A $rule\n";
1197     }
1198     $rule = "OUTPUT -j PVEFW-OUTPUT";
1199     if (!PVE::Firewall::iptables_rule_exist($rule)) {
1200         $cmdlist .= "-A $rule\n";
1201     }
1202
1203     $rule = "FORWARD -j PVEFW-FORWARD";
1204     if (!PVE::Firewall::iptables_rule_exist($rule)) {
1205         $cmdlist .= "-A $rule\n";
1206     }
1207
1208     foreach my $chain (sort keys %$ruleset) {
1209         my $stat = $statushash->{$chain};
1210         die "internal error" if !$stat;
1211
1212         if ($stat->{action} eq 'update' || $stat->{action} eq 'create') {
1213             $cmdlist .= "-F $chain\n";
1214             foreach my $cmd (@{$ruleset->{$chain}}) {
1215                 $cmdlist .= "$cmd\n";
1216             }
1217             $cmdlist .= print_sig_rule($chain, $stat->{sig});
1218         } elsif ($stat->{action} eq 'delete') {
1219             die "internal error"; # this should not happen
1220         } elsif ($stat->{action} eq 'exists') {
1221             # do nothing
1222         } else {
1223             die "internal error - unknown status '$stat->{action}'";
1224         }
1225     }
1226
1227     foreach my $chain (keys %$statushash) {
1228         next if $statushash->{$chain}->{action} ne 'delete';
1229         $cmdlist .= "-F $chain\n";
1230     }
1231     foreach my $chain (keys %$statushash) {
1232         next if $statushash->{$chain}->{action} ne 'delete';
1233         $cmdlist .= "-X $chain\n";
1234     }
1235
1236     $cmdlist .= "COMMIT\n";
1237
1238     print $cmdlist if $verbose;
1239
1240     iptables_restore_cmdlist($cmdlist);
1241
1242     # test: re-read status and check if everything is up to date
1243     $statushash = get_ruleset_status($ruleset);
1244
1245     my $errors;
1246     foreach my $chain (sort keys %$ruleset) {
1247         my $stat = $statushash->{$chain};
1248         if ($stat->{action} ne 'exists') {
1249             warn "unable to update chain '$chain'\n";
1250             $errors = 1;
1251         }
1252     }
1253
1254     die "unable to apply firewall changes\n" if $errors;
1255 }
1256
1257 1;