use warnings;
use strict;
use Data::Dumper;
+use Digest::SHA;
use PVE::Tools;
use PVE::QemuServer;
use File::Path;
use IO::File;
+use Net::IP;
+use PVE::Tools qw(run_command lock_file);
+
use Data::Dumper;
+my $pve_fw_lock_filename = "/var/lock/pvefw.lck";
+
my $macros;
-sub get_shorewall_macros {
+
+# todo: implement some kind of MACROS, like shorewall /usr/share/shorewall/macro.*
+sub get_firewall_macros {
return $macros if $macros;
- foreach my $path (</usr/share/shorewall/macro.*>) {
- if ($path =~ m|/macro\.(\S+)$|) {
- $macros->{$1} = 1;
- }
- }
+ #foreach my $path (</usr/share/shorewall/macro.*>) {
+ # if ($path =~ m|/macro\.(\S+)$|) {
+ # $macros->{$1} = 1;
+ # }
+ #}
+
+ $macros = {}; # fixme: implemet me
+
return $macros;
}
+my $etc_services;
-my $rule_format = "%-15s %-30s %-30s %-15s %-15s %-15s\n";
-
-my $generate_input_rule = sub {
- my ($zoneinfo, $rule, $net, $netid) = @_;
+sub get_etc_services {
- my $zone = $net->{zone} || die "internal error";
- my $zid = $zoneinfo->{$zone}->{zoneref} || die "internal error";
- my $tap = $net->{tap} || die "internal error";
+ return $etc_services if $etc_services;
- my $dest = "$zid:$tap";
+ my $filename = "/etc/services";
- if ($rule->{dest}) {
- $dest .= ":$rule->{dest}";
+ my $fh = IO::File->new($filename, O_RDONLY);
+ if (!$fh) {
+ warn "unable to read '$filename' - $!\n";
+ return {};
}
- my $action = $rule->{service} ?
- "$rule->{service}($rule->{action})" : $rule->{action};
+ my $services = {};
- my $source;
+ while (my $line = <$fh>) {
+ chomp ($line);
+ next if $line =~m/^#/;
+ next if ($line =~m/^\s*$/);
- if ($zoneinfo->{$zone}->{type} eq 'bport') {
- my $bridge_zone = $zoneinfo->{$zone}->{bridge_zone} || die "internal error";
- my $bridge_ext_zone = $zoneinfo->{$bridge_zone}->{bridge_ext_zone} || die "internal error";
- my $zoneref = $zoneinfo->{$bridge_ext_zone}->{zoneref} || die "internal error";
- if (!$rule->{source}) {
- # $source = "${zoneref}";
- $source = 'all';
- } else {
- # 'all' does not work
- $source = "${zoneref}:$rule->{source}";
+ if ($line =~ m!^(\S+)\s+(\S+)/(tcp|udp).*$!) {
+ $services->{byid}->{$2}->{name} = $1;
+ $services->{byid}->{$2}->{$3} = 1;
+ $services->{byname}->{$1} = $services->{byid}->{$2};
}
- } else {
- $source = "all:$rule->{source}";
}
- return sprintf($rule_format, $action, $source, $dest, $rule->{proto} || '-',
- $rule->{dport} || '-', $rule->{sport} || '-');
-};
+ close($fh);
+
+ $etc_services = $services;
+
-my $generate_output_rule = sub {
- my ($zoneinfo, $rule, $net, $netid) = @_;
+ return $etc_services;
+}
- my $zone = $net->{zone} || die "internal error";
- my $zid = $zoneinfo->{$zone}->{zoneref} || die "internal error";
- my $tap = $net->{tap} || die "internal error";
+my $etc_protocols;
- my $action = $rule->{service} ?
- "$rule->{service}($rule->{action})" : $rule->{action};
-
- my $dest;
+sub get_etc_protocols {
+ return $etc_protocols if $etc_protocols;
- if (!$rule->{dest}) {
- $dest = 'all';
- } else {
- $dest = "all:$rule->{dest}";
+ my $filename = "/etc/protocols";
+
+ my $fh = IO::File->new($filename, O_RDONLY);
+ if (!$fh) {
+ warn "unable to read '$filename' - $!\n";
+ return {};
}
- return sprintf($rule_format, $action, "$zid:$tap", $dest,
- $rule->{proto} || '-', $rule->{dport} || '-', $rule->{sport} || '-');
-};
+ my $protocols = {};
+
+ while (my $line = <$fh>) {
+ chomp ($line);
+ next if $line =~m/^#/;
+ next if ($line =~m/^\s*$/);
+
+ if ($line =~ m!^(\S+)\s+(\d+)\s+.*$!) {
+ $protocols->{byid}->{$2}->{name} = $1;
+ $protocols->{byname}->{$1} = $protocols->{byid}->{$2};
+ }
+ }
+
+ close($fh);
+
+ $etc_protocols = $protocols;
+
+ return $etc_protocols;
+}
-# we need complete VM configuration of all VMs (openvz/qemu)
-# in vmdata
+sub parse_address_list {
+ my ($str) = @_;
-my $compile_shorewall = sub {
- my ($targetdir, $vmdata, $rules) = @_;
+ my $nbaor = 0;
+ foreach my $aor (split(/,/, $str)) {
+ if (!Net::IP->new($aor)) {
+ my $err = Net::IP::Error();
+ die "invalid IP address: $err\n";
+ }else{
+ $nbaor++;
+ }
+ }
+ return $nbaor;
+}
- # remove existing data ?
- foreach my $file (qw(params zones rules interfaces maclist policy)) {
- unlink "$targetdir/$file";
+sub parse_port_name_number_or_range {
+ my ($str) = @_;
+
+ my $services = PVE::Firewall::get_etc_services();
+ my $nbports = 0;
+ foreach my $item (split(/,/, $str)) {
+ my $portlist = "";
+ foreach my $pon (split(':', $item, 2)) {
+ if ($pon =~ m/^\d+$/){
+ die "invalid port '$pon'\n" if $pon < 0 && $pon > 65536;
+ }else{
+ die "invalid port $services->{byname}->{$pon}\n" if !$services->{byname}->{$pon};
+ }
+ $nbports++;
+ }
}
- my $netinfo;
+ return ($nbports);
+}
- my $zoneinfo = {
- fw => { type => 'firewall' },
- };
+my $bridge_firewall_enabled = 0;
- my $maclist = {};
+sub enable_bridge_firewall {
- my $register_bridge;
+ return if $bridge_firewall_enabled; # only once
- $register_bridge = sub {
- my ($bridge, $vlan) = @_;
+ system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-iptables");
+ system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-ip6tables");
- my $zone = 'z' . $bridge;
+ $bridge_firewall_enabled = 1;
+}
- return $zone if $zoneinfo->{$zone};
+my $rule_format = "%-15s %-30s %-30s %-15s %-15s %-15s\n";
- my $ext_zone = "z${bridge}ext";
+sub iptables {
+ my ($cmd) = @_;
- $zoneinfo->{$zone} = {
- type => 'bridge',
- bridge => $bridge,
- bridge_ext_zone => $ext_zone,
- };
+ run_command("/sbin/iptables $cmd", outfunc => sub {}, errfunc => sub {});
+}
- # physical input devices
- my $dir = "/sys/class/net/$bridge/brif";
- my $physical = {};
- PVE::Tools::dir_glob_foreach($dir, '((eth|bond).+)', sub {
- my ($slave) = @_;
- $physical->{$slave} = 1;
- });
-
- $zoneinfo->{$ext_zone} = {
- type => 'bport',
- bridge_zone => $zone,
- ifaces => $physical,
- };
+sub iptables_restore_cmdlist {
+ my ($cmdlist) = @_;
- return &$register_bridge("${bridge}v${vlan}") if defined($vlan);
-
- return $zone;
- };
+ run_command("/sbin/iptables-restore -n", input => $cmdlist);
+}
- my $register_bridge_port = sub {
- my ($bridge, $vlan, $vmzone, $tap) = @_;
+sub iptables_get_chains {
- my $bridge_zone = &$register_bridge($bridge, $vlan);
- my $zone = $bridge_zone . $vmzone;
+ my $res = {};
- if (!$zoneinfo->{$zone}) {
- $zoneinfo->{$zone} = {
- type => 'bport',
- bridge_zone => $bridge_zone,
- ifaces => {},
- };
- }
+ # check what chains we want to track
+ my $is_pvefw_chain = sub {
+ my $name = shift;
+
+ return 1 if $name =~ m/^PVEFW-\S+$/;
+
+ return 1 if $name =~ m/^tap\d+i\d+-(:?IN|OUT)$/;
+ return 1 if $name =~ m/^vmbr\d+-(:?IN|OUT)$/;
+ return 1 if $name =~ m/^GROUP-(:?[^\s\-]+)-(:?IN|OUT)$/;
- $zoneinfo->{$zone}->{ifaces}->{$tap} = 1;
-
- return $zone;
+ return undef;
};
- foreach my $vmid (keys %{$vmdata->{qemu}}) {
- $netinfo->{$vmid} = {};
- my $conf = $vmdata->{qemu}->{$vmid};
- foreach my $opt (keys %$conf) {
- next if $opt !~ m/^net(\d+)$/;
- my $netnum = $1;
- my $net = PVE::QemuServer::parse_net($conf->{$opt});
- next if !$net;
- die "implement me" if !$net->{bridge};
+ my $table = '';
- my $vmzone = $conf->{zone} || "vm$vmid";
- $net->{tap} = "tap${vmid}i${netnum}";
- $maclist->{$net->{tap}} = $net->{macaddr} || die "internal error";
- $net->{zone} = &$register_bridge_port($net->{bridge}, $net->{tag}, $vmzone, $net->{tap});
- $netinfo->{$vmid}->{$opt} = $net;
+ my $parser = sub {
+ my $line = shift;
+
+ return if $line =~ m/^#/;
+ return if $line =~ m/^\s*$/;
+
+ if ($line =~ m/^\*(\S+)$/) {
+ $table = $1;
+ return;
}
- }
- #print Dumper($netinfo);
+ return if $table ne 'filter';
- # NOTE: zone names have length limit, so we need to
- # translate them into shorter names
+ if ($line =~ m/^:(\S+)\s/) {
+ my $chain = $1;
+ return if !&$is_pvefw_chain($chain);
+ $res->{$chain} = "unknown";
+ } elsif ($line =~ m/^-A\s+(\S+)\s.*--comment\s+\"PVESIG:(\S+)\"/) {
+ my ($chain, $sig) = ($1, $2);
+ return if !&$is_pvefw_chain($chain);
+ $res->{$chain} = $sig;
+ } else {
+ # simply ignore the rest
+ return;
+ }
+ };
+
+ run_command("/sbin/iptables-save", outfunc => $parser);
+
+ return $res;
+}
+
+sub iptables_chain_exist {
+ my ($chain) = @_;
- my $zoneid = 0;
- my $zonemap = { fw => 'fw' };
+ eval{
+ iptables("-n --list $chain");
+ };
+ return undef if $@;
- my $lookup_zonename = sub {
- my ($zone) = @_;
+ return 1;
+}
- return $zonemap->{$zone} if defined($zonemap->{$zone});
- $zonemap->{$zone} = 'z' . $zoneid++;
+sub iptables_rule_exist {
+ my ($rule) = @_;
- return $zonemap->{$zone};
+ eval{
+ iptables("-C $rule");
};
+ return undef if $@;
+
+ return 1;
+}
+
+sub ruleset_generate_rule {
+ my ($ruleset, $chain, $rule) = @_;
+
+ my $cmd = '';
+
+ $cmd .= " -m iprange --src-range" if $rule->{nbsource} && $rule->{nbsource} > 1;
+ $cmd .= " -s $rule->{source}" if $rule->{source};
+ $cmd .= " -m iprange --dst-range" if $rule->{nbdest} && $rule->{nbdest} > 1;
+ $cmd .= " -d $rule->{dest}" if $rule->{destination};
+ $cmd .= " -p $rule->{proto}" if $rule->{proto};
+ $cmd .= " --match multiport" if $rule->{nbdport} && $rule->{nbdport} > 1;
+ $cmd .= " --dport $rule->{dport}" if $rule->{dport};
+ $cmd .= " --match multiport" if $rule->{nbsport} && $rule->{nbsport} > 1;
+ $cmd .= " --sport $rule->{sport}" if $rule->{sport};
+ $cmd .= " -j $rule->{action}" if $rule->{action};
+
+ ruleset_addrule($ruleset, $chain, $cmd) if $cmd;
+}
+
+sub ruleset_create_chain {
+ my ($ruleset, $chain) = @_;
+
+ die "Invalid chain name '$chain' (28 char max)\n" if length($chain) > 28;
+
+ die "chain '$chain' already exists\n" if $ruleset->{$chain};
+
+ $ruleset->{$chain} = [];
+}
+
+sub ruleset_chain_exist {
+ my ($ruleset, $chain) = @_;
+
+ return $ruleset->{$chain} ? 1 : undef;
+}
+
+sub ruleset_addrule {
+ my ($ruleset, $chain, $rule) = @_;
+
+ die "no such chain '$chain'\n" if !$ruleset->{$chain};
+
+ push @{$ruleset->{$chain}}, "-A $chain $rule";
+}
+
+sub ruleset_insertrule {
+ my ($ruleset, $chain, $rule) = @_;
+
+ die "no such chain '$chain'\n" if !$ruleset->{$chain};
+
+ unshift @{$ruleset->{$chain}}, "-A $chain $rule";
+}
+
+sub generate_bridge_chains {
+ my ($ruleset, $bridge) = @_;
+
+ if (!ruleset_chain_exist($ruleset, "PVEFW-BRIDGE-IN")){
+ ruleset_create_chain($ruleset, "PVEFW-BRIDGE-IN");
+ }
- foreach my $z (sort keys %$zoneinfo) {
- $zoneinfo->{$z}->{id} = &$lookup_zonename($z);
- $zoneinfo->{$z}->{zonevar} = uc($z);
- $zoneinfo->{$z}->{zoneref} = '$' . $zoneinfo->{$z}->{zonevar};
+ if (!ruleset_chain_exist($ruleset, "PVEFW-BRIDGE-OUT")){
+ ruleset_create_chain($ruleset, "PVEFW-BRIDGE-OUT");
}
- my $out;
+ if (!ruleset_chain_exist($ruleset, "PVEFW-FORWARD")){
+ ruleset_create_chain($ruleset, "PVEFW-FORWARD");
- # dump params file
- $out = "# PVE zones\n";
- foreach my $z (sort keys %$zoneinfo) {
- $out .= "$zoneinfo->{$z}->{zonevar}=$zoneinfo->{$z}->{id}\n";
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m state --state RELATED,ESTABLISHED -j ACCEPT");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m physdev --physdev-is-in --physdev-is-bridged -j PVEFW-BRIDGE-OUT");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m physdev --physdev-is-out --physdev-is-bridged -j PVEFW-BRIDGE-IN");
}
- PVE::Tools::file_set_contents("$targetdir/params", $out);
- # dump zone file
+ if (!ruleset_chain_exist($ruleset, "$bridge-IN")) {
+ ruleset_create_chain($ruleset, "$bridge-IN");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j DROP"); # disable interbridge routing
+ ruleset_addrule($ruleset, "PVEFW-BRIDGE-IN", "-j $bridge-IN");
+ ruleset_addrule($ruleset, "$bridge-IN", "-j ACCEPT");
+ }
- my $format = "%-30s %-10s %-15s\n";
- $out = sprintf($format, '#ZONE', 'TYPE', 'OPTIONS');
-
- foreach my $z (sort keys %$zoneinfo) {
- my $zid = $zoneinfo->{$z}->{zoneref};
- if ($zoneinfo->{$z}->{type} eq 'firewall') {
- $out .= sprintf($format, $zid, $zoneinfo->{$z}->{type}, '');
- } elsif ($zoneinfo->{$z}->{type} eq 'bridge') {
- $out .= sprintf($format, $zid, 'ipv4', '');
- } elsif ($zoneinfo->{$z}->{type} eq 'bport') {
- my $bridge_zone = $zoneinfo->{$z}->{bridge_zone} || die "internal error";
- my $bzid = $zoneinfo->{$bridge_zone}->{zoneref} || die "internal error";
- $out .= sprintf($format, "$zid:$bzid", 'bport', '');
- } else {
- die "internal error";
- }
+ if (!ruleset_chain_exist($ruleset, "$bridge-OUT")) {
+ ruleset_create_chain($ruleset, "$bridge-OUT");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j DROP"); # disable interbridge routing
+ ruleset_addrule($ruleset, "PVEFW-BRIDGE-OUT", "-j $bridge-OUT");
+ }
+}
+
+sub generate_tap_rules_direction {
+ my ($ruleset, $iface, $netid, $macaddr, $rules, $bridge, $direction) = @_;
+
+ my $tapchain = "$iface-$direction";
+
+ ruleset_create_chain($ruleset, $tapchain);
+
+ ruleset_addrule($ruleset, $tapchain, "-m state --state INVALID -j DROP");
+ ruleset_addrule($ruleset, $tapchain, "-m state --state RELATED,ESTABLISHED -j ACCEPT");
+
+ if ($direction eq 'OUT' && defined($macaddr)) {
+ ruleset_addrule($ruleset, $tapchain, "-m mac ! --mac-source $macaddr -j DROP");
}
- $out .= sprintf("#LAST LINE - ADD YOUR ENTRIES ABOVE THIS ONE - DO NOT REMOVE\n");
-
- PVE::Tools::file_set_contents("$targetdir/zones", $out);
-
- # dump interfaces
-
- $format = "%-25s %-20s %-10s %-15s\n";
- $out = sprintf($format, '#ZONE', 'INTERFACE', 'BROADCAST', 'OPTIONS');
-
- my $maclist_format = "%-15s %-15s %-15s\n";
- my $macs = sprintf($maclist_format, '#DISPOSITION', 'INTERFACE', 'MACZONE');
-
- foreach my $z (sort keys %$zoneinfo) {
- my $zid = $zoneinfo->{$z}->{zoneref};
- if ($zoneinfo->{$z}->{type} eq 'firewall') {
- # do nothing;
- } elsif ($zoneinfo->{$z}->{type} eq 'bridge') {
- my $bridge = $zoneinfo->{$z}->{bridge} || die "internal error";
- $out .= sprintf($format, $zid, $bridge, 'detect', 'bridge,optional');
- } elsif ($zoneinfo->{$z}->{type} eq 'bport') {
- my $ifaces = $zoneinfo->{$z}->{ifaces};
- foreach my $iface (sort keys %$ifaces) {
- my $bridge_zone = $zoneinfo->{$z}->{bridge_zone} || die "internal error";
- my $bridge = $zoneinfo->{$bridge_zone}->{bridge} || die "internal error";
- my $iftxt = "$bridge:$iface";
-
- if ($maclist->{$iface}) {
- $out .= sprintf($format, $zid, $iftxt, '-', 'maclist');
- $macs .= sprintf($maclist_format, 'ACCEPT', $iface, $maclist->{$iface});
- } else {
- $out .= sprintf($format, $zid, $iftxt, '-', '');
+ if ($rules) {
+ foreach my $rule (@$rules) {
+ next if $rule->{iface} && $rule->{iface} ne $netid;
+ if($rule->{action} =~ m/^(GROUP-(\S+))$/){
+ $rule->{action} .= "-$direction";
+ # generate empty group rule if don't exist
+ if(!ruleset_chain_exist($ruleset, $rule->{action})){
+ generate_group_rules($ruleset, $2);
}
}
- } else {
- die "internal error";
- }
+ # we go to vmbr-IN if accept in out rules
+ $rule->{action} = "$bridge-IN" if $rule->{action} eq 'ACCEPT' && $direction eq 'OUT';
+ ruleset_generate_rule($ruleset, $tapchain, $rule);
+ }
}
- $out .= sprintf("#LAST LINE - ADD YOUR ENTRIES ABOVE THIS ONE - DO NOT REMOVE\n");
+ ruleset_addrule($ruleset, $tapchain, "-j LOG --log-prefix \"$tapchain-dropped: \" --log-level 4");
+ ruleset_addrule($ruleset, $tapchain, "-j DROP");
+
+ # plug the tap chain to bridge chain
+ my $physdevdirection = $direction eq 'IN' ? "out" : "in";
+ my $rule = "-m physdev --physdev-$physdevdirection $iface --physdev-is-bridged -j $tapchain";
+ ruleset_insertrule($ruleset, "$bridge-$direction", $rule);
+
+ if ($direction eq 'OUT'){
+ # add tap->host rules
+ my $rule = "-m physdev --physdev-$physdevdirection $iface -j $tapchain";
+ ruleset_addrule($ruleset, "PVEFW-INPUT", $rule);
+ }
+}
- PVE::Tools::file_set_contents("$targetdir/interfaces", $out);
+sub enablehostfw {
+ my ($ruleset) = @_;
- # dump maclist
- PVE::Tools::file_set_contents("$targetdir/maclist", $macs);
+ my $filename = "/etc/pve/local/host.fw";
+ my $fh = IO::File->new($filename, O_RDONLY);
+ return if !$fh;
- # dump policy
+ my $rules = parse_fw_rules($filename, $fh);
- $format = "%-15s %-15s %-15s %s\n";
- $out = sprintf($format, '#SOURCE', 'DEST', 'POLICY', 'LOG');
- $out .= sprintf($format, 'fw', 'all', 'ACCEPT', '');
+ # host inbound firewall
+ my $chain = "PVEFW-HOST-IN";
+ ruleset_create_chain($ruleset, $chain);
- # we need to disable intra-zone traffic on bridges. Else traffic
- # from untracked interfaces simply pass the firewall
- foreach my $z (sort keys %$zoneinfo) {
- my $zid = $zoneinfo->{$z}->{zoneref};
- if ($zoneinfo->{$z}->{type} eq 'bridge') {
- $out .= sprintf($format, $zid, $zid, 'REJECT', 'info');
- }
+ ruleset_addrule($ruleset, $chain, "-m state --state INVALID -j DROP");
+ ruleset_addrule($ruleset, $chain, "-m state --state RELATED,ESTABLISHED -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-i lo -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m state --state NEW -m multiport --dports 5404,5405 -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
+
+ if ($rules->{in}) {
+ foreach my $rule (@{$rules->{in}}) {
+ # we use RETURN because we need to check also tap rules
+ $rule->{action} = 'RETURN' if $rule->{action} eq 'ACCEPT';
+ ruleset_generate_rule($ruleset, $chain, $rule);
+ }
}
- $out .= sprintf($format, 'all', 'all', 'REJECT', 'info');
- PVE::Tools::file_set_contents("$targetdir/policy", $out);
+ ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-IN dropped: \" --log-level 4");
+ ruleset_addrule($ruleset, $chain, "-j DROP");
+
+ # host outbound firewall
+ $chain = "PVEFW-HOST-OUT";
+ ruleset_create_chain($ruleset, $chain);
+
+ ruleset_addrule($ruleset, $chain, "-m state --state INVALID -j DROP");
+ ruleset_addrule($ruleset, $chain, "-m state --state RELATED,ESTABLISHED -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-o lo -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m state --state NEW -m multiport --dports 5404,5405 -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
+
+ if ($rules->{out}) {
+ foreach my $rule (@{$rules->{out}}) {
+ # we use RETURN because we need to check also tap rules
+ $rule->{action} = 'RETURN' if $rule->{action} eq 'ACCEPT';
+ ruleset_generate_rule($ruleset, $chain, $rule);
+ }
+ }
- # dump rules
- $out = '';
+ ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-OUT dropped: \" --log-level 4");
+ ruleset_addrule($ruleset, $chain, "-j DROP");
+
+ ruleset_addrule($ruleset, "PVEFW-OUTPUT", "-j PVEFW-HOST-OUT");
+ ruleset_addrule($ruleset, "PVEFW-INPUT", "-j PVEFW-HOST-IN");
+}
- $out = sprintf($rule_format, '#ACTION', 'SOURCE', 'DEST', 'PROTO', 'DPORT', 'SPORT');
- foreach my $vmid (sort keys %$rules) {
- my $inrules = $rules->{$vmid}->{in};
- my $outrules = $rules->{$vmid}->{out};
+sub generate_group_rules {
+ my ($ruleset, $group) = @_;
- if (scalar(@$inrules)) {
- $out .= "# IN to VM $vmid\n";
- foreach my $rule (@$inrules) {
- foreach my $netid (keys %{$netinfo->{$vmid}}) {
- my $net = $netinfo->{$vmid}->{$netid};
- next if $rule->{iface} && $rule->{iface} ne $netid;
- $out .= &$generate_input_rule($zoneinfo, $rule, $net, $netid);
- }
- }
- }
+ my $filename = "/etc/pve/firewall/groups.fw";
+ my $fh = IO::File->new($filename, O_RDONLY);
+ return if !$fh;
- if (scalar(@$outrules)) {
- $out .= "# OUT from VM $vmid\n";
- foreach my $rule (@$outrules) {
- foreach my $netid (keys %{$netinfo->{$vmid}}) {
- my $net = $netinfo->{$vmid}->{$netid};
- next if $rule->{iface} && $rule->{iface} ne $netid;
- $out .= &$generate_output_rule($zoneinfo, $rule, $net, $netid);
- }
- }
- }
+ my $rules = parse_fw_rules($filename, $fh, $group);
+
+ my $chain = "GROUP-${group}-IN";
+
+ ruleset_create_chain($ruleset, $chain);
+
+ if ($rules->{in}) {
+ foreach my $rule (@{$rules->{in}}) {
+ ruleset_generate_rule($ruleset, $chain, $rule);
+ }
}
- PVE::Tools::file_set_contents("$targetdir/rules", $out);
-};
+ $chain = "GROUP-${group}-OUT";
+
+ ruleset_create_chain($ruleset, $chain);
+ if ($rules->{out}) {
+ foreach my $rule (@{$rules->{out}}) {
+ # we go the PVEFW-BRIDGE-IN because we need to check also other tap rules
+ # (and group rules can be set on any bridge, so we can't go to VMBRXX-IN)
+ $rule->{action} = 'PVEFW-BRIDGE-IN' if $rule->{action} eq 'ACCEPT';
+ ruleset_generate_rule($rule, $chain, $rule);
+ }
+ }
+}
sub parse_fw_rules {
- my ($filename, $fh) = @_;
+ my ($filename, $fh, $group) = @_;
my $section;
+ my $securitygroup;
+ my $securitygroupexist;
my $res = { in => [], out => [] };
- my $macros = PVE::Firewall::get_shorewall_macros();
-
+ my $macros = get_firewall_macros();
+ my $protocols = get_etc_protocols();
+
while (defined(my $line = <$fh>)) {
next if $line =~ m/^#/;
next if $line =~ m/^\s*$/;
- if ($line =~ m/^\[(in|out)\]\s*$/i) {
+ if ($line =~ m/^\[(in|out)(:(\S+))?\]\s*$/i) {
$section = lc($1);
+ $securitygroup = lc($3) if $3;
+ $securitygroupexist = 1 if $securitygroup && $securitygroup eq $group;
next;
}
next if !$section;
+ next if $group && $securitygroup ne $group;
my ($action, $iface, $source, $dest, $proto, $dport, $sport) =
split(/\s+/, $line);
}
my $service;
- if ($action =~ m/^(ACCEPT|DROP|REJECT)$/) {
+ if ($action =~ m/^(ACCEPT|DROP|REJECT|GROUP-(\S+))$/) {
# OK
} elsif ($action =~ m/^(\S+)\((ACCEPT|DROP|REJECT)\)$/) {
($service, $action) = ($1, $2);
}
$proto = undef if $proto && $proto eq '-';
- if ($proto && $proto !~ m/^(icmp|tcp|udp)$/) {
+ if ($proto && !(defined($protocols->{byname}->{$proto}) ||
+ defined($protocols->{byid}->{$proto}))) {
warn "unknown protokol '$proto'\n";
next;
}
$source = undef if $source && $source eq '-';
-
-# if ($source !~ m/^(XYZ)$/) {
-# warn "unknown source '$source'\n";
-# next;
-# }
-
$dest = undef if $dest && $dest eq '-';
-# if ($dest !~ m/^XYZ)$/) {
-# warn "unknown destination '$dest'\n";
-# next;
-# }
$dport = undef if $dport && $dport eq '-';
$sport = undef if $sport && $sport eq '-';
+ my $nbdport = undef;
+ my $nbsport = undef;
+ my $nbsource = undef;
+ my $nbdest = undef;
+
+ eval {
+ $nbsource = parse_address_list($source) if $source;
+ $nbdest = parse_address_list($dest) if $dest;
+ $nbdport = parse_port_name_number_or_range($dport) if $dport;
+ $nbsport = parse_port_name_number_or_range($sport) if $sport;
+ };
+ if (my $err = $@) {
+ warn $err;
+ next;
+
+ }
+
my $rule = {
action => $action,
iface => $iface,
source => $source,
dest => $dest,
+ nbsource => $nbsource,
+ nbdest => $nbdest,
proto => $proto,
dport => $dport,
sport => $sport,
+ nbdport => $nbdport,
+ nbsport => $nbsport,
+
};
push @{$res->{$section}}, $rule;
}
+ die "security group $group don't exist" if $group && !$securitygroupexist;
+ return $res;
+}
+
+sub run_locked {
+ my ($code, @param) = @_;
+
+ my $timeout = 10;
+
+ my $res = lock_file($pve_fw_lock_filename, $timeout, $code, @param);
+
+ die $@ if $@;
+
return $res;
}
my $list = PVE::QemuServer::config_list();
foreach my $vmid (keys %$list) {
- # next if $vmid ne '100';
my $cfspath = PVE::QemuServer::cfs_config_path($vmid);
if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
$qemu->{$vmid} = $conf;
}
sub compile {
-
my $vmdata = read_local_vm_config();
my $rules = read_vm_firewall_rules($vmdata);
- # print Dumper($vmdata);
+ #print Dumper($rules);
+
+ my $ruleset = {};
- my $swdir = '/etc/shorewall';
- mkdir $swdir;
+ # setup host firewall rules
+ ruleset_create_chain($ruleset, "PVEFW-INPUT");
+ ruleset_create_chain($ruleset, "PVEFW-OUTPUT");
+
+ enablehostfw($ruleset);
+
+ # generate firewall rules for QEMU VMs
+ foreach my $vmid (keys %{$vmdata->{qemu}}) {
+ my $conf = $vmdata->{qemu}->{$vmid};
+ next if !$rules->{$vmid};
+
+ foreach my $netid (keys %$conf) {
+ next if $netid !~ m/^net(\d+)$/;
+ my $net = PVE::QemuServer::parse_net($conf->{$netid});
+ next if !$net;
+ my $iface = "tap${vmid}i$1";
- &$compile_shorewall($swdir, $vmdata, $rules);
+ my $bridge = $net->{bridge};
+ next if !$bridge; # fixme: ?
- PVE::Tools::run_command(['shorewall', 'compile']);
+ $bridge .= "v$net->{tag}" if $net->{tag};
+
+ generate_bridge_chains($ruleset, $bridge);
+
+ my $macaddr = $net->{macaddr};
+ generate_tap_rules_direction($ruleset, $iface, $netid, $macaddr, $rules->{$vmid}->{in}, $bridge, 'IN');
+ generate_tap_rules_direction($ruleset, $iface, $netid, $macaddr, $rules->{$vmid}->{out}, $bridge, 'OUT');
+ }
+ }
+ return $ruleset;
+}
+
+sub get_ruleset_status {
+ my ($ruleset, $verbose) = @_;
+
+ my $active_chains = iptables_get_chains();
+
+ my $statushash = {};
+
+ foreach my $chain (sort keys %$ruleset) {
+ my $digest = Digest::SHA->new('sha1');
+ foreach my $cmd (@{$ruleset->{$chain}}) {
+ $digest->add("$cmd\n");
+ }
+ my $sig = $digest->b64digest;
+ $statushash->{$chain}->{sig} = $sig;
+
+ my $oldsig = $active_chains->{$chain};
+ if (!defined($oldsig)) {
+ $statushash->{$chain}->{action} = 'create';
+ } else {
+ if ($oldsig eq $sig) {
+ $statushash->{$chain}->{action} = 'exists';
+ } else {
+ $statushash->{$chain}->{action} = 'update';
+ }
+ }
+ print "$statushash->{$chain}->{action} $chain ($sig)\n" if $verbose;
+ foreach my $cmd (@{$ruleset->{$chain}}) {
+ print "\t$cmd\n" if $verbose;
+ }
+ }
+
+ foreach my $chain (sort keys %$active_chains) {
+ if (!defined($ruleset->{$chain})) {
+ my $sig = $active_chains->{$chain};
+ $statushash->{$chain}->{action} = 'delete';
+ $statushash->{$chain}->{sig} = $sig;
+ print "delete $chain ($sig)\n" if $verbose;
+ }
+ }
+
+ return $statushash;
}
-sub compile_and_start {
- my ($restart) = @_;
+sub print_ruleset {
+ my ($ruleset) = @_;
+
+ get_ruleset_status($ruleset, 1);
+}
- compile();
+sub print_sig_rule {
+ my ($chain, $sig) = @_;
- PVE::Tools::run_command(['shorewall', $restart ? 'restart' : 'start']);
+ # We just use this to store a SHA1 checksum used to detect changes
+ return "-A $chain -m comment --comment \"PVESIG:$sig\"\n";
}
+sub apply_ruleset {
+ my ($ruleset, $verbose) = @_;
+
+ enable_bridge_firewall();
+
+ my $cmdlist = "*filter\n"; # we pass this to iptables-restore;
+
+ my $statushash = get_ruleset_status($ruleset, $verbose);
+
+ # create missing chains first
+ foreach my $chain (sort keys %$ruleset) {
+ my $stat = $statushash->{$chain};
+ die "internal error" if !$stat;
+ next if $stat->{action} ne 'create';
+
+ $cmdlist .= ":$chain - [0:0]\n";
+ }
+
+ my $rule = "INPUT -j PVEFW-INPUT";
+ if (!PVE::Firewall::iptables_rule_exist($rule)) {
+ $cmdlist .= "-A $rule\n";
+ }
+ $rule = "OUTPUT -j PVEFW-OUTPUT";
+ if (!PVE::Firewall::iptables_rule_exist($rule)) {
+ $cmdlist .= "-A $rule\n";
+ }
+
+ $rule = "FORWARD -j PVEFW-FORWARD";
+ if (!PVE::Firewall::iptables_rule_exist($rule)) {
+ $cmdlist .= "-A $rule\n";
+ }
+
+ foreach my $chain (sort keys %$ruleset) {
+ my $stat = $statushash->{$chain};
+ die "internal error" if !$stat;
+
+ if ($stat->{action} eq 'update' || $stat->{action} eq 'create') {
+ $cmdlist .= "-F $chain\n";
+ foreach my $cmd (@{$ruleset->{$chain}}) {
+ $cmdlist .= "$cmd\n";
+ }
+ $cmdlist .= print_sig_rule($chain, $stat->{sig});
+ } elsif ($stat->{action} eq 'delete') {
+ $cmdlist .= "-F $chain\n";
+ $cmdlist .= "-X $chain\n";
+ } elsif ($stat->{action} eq 'exists') {
+ # do nothing
+ } else {
+ die "internal error - unknown status '$stat->{action}'";
+ }
+ }
+
+ $cmdlist .= "COMMIT\n";
+
+ print $cmdlist if $verbose;
+
+ iptables_restore_cmdlist($cmdlist);
+
+ # test: re-read status and check if everything is up to date
+ $statushash = get_ruleset_status($ruleset);
+
+ my $errors;
+ foreach my $chain (sort keys %$ruleset) {
+ my $stat = $statushash->{$chain};
+ if ($stat->{action} ne 'exists') {
+ warn "unable to update chain '$chain'\n";
+ $errors = 1;
+ }
+ }
+
+ die "unable to apply firewall changes\n" if $errors;
+}
1;
projects / pve-firewall.git / blobdiff