use strict;
use Data::Dumper;
use Digest::SHA;
+use PVE::ProcFSTools;
use PVE::Tools;
use PVE::QemuServer;
use File::Basename;
return if $bridge_firewall_enabled; # only once
- system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-iptables");
- system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-ip6tables");
+ PVE::ProcFSTools::write_proc_entry("/proc/sys/net/bridge/bridge-nf-call-iptables", "1");
+ PVE::ProcFSTools::write_proc_entry("/proc/sys/net/bridge/bridge-nf-call-ip6tables", "1");
+
+ # make sure syncookies are enabled (which is default on newer 3.X kernels anyways)
+ PVE::ProcFSTools::write_proc_entry("/proc/sys/net/ipv4/tcp_syncookies", "1");
$bridge_firewall_enabled = 1;
}
}
sub generate_bridge_chains {
- my ($ruleset, $bridge) = @_;
+ my ($ruleset, $hostfw_conf, $bridge) = @_;
- if (!ruleset_chain_exist($ruleset, "PVEFW-FORWARD")){
- ruleset_create_chain($ruleset, "PVEFW-FORWARD");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
- }
+ my $options = $hostfw_conf->{options} || {};
+
+ # fixme: what log level should we use here?
+ my $loglevel = get_option_log_level($options, "log_level_out");
if (!ruleset_chain_exist($ruleset, "$bridge-FW")) {
ruleset_create_chain($ruleset, "$bridge-FW");
ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -m physdev --physdev-is-bridged -j $bridge-FW");
ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -m physdev --physdev-is-bridged -j $bridge-FW");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j DROP"); # disable interbridge routing
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j DROP"); # disable interbridge routing
+ # disable interbridge routing
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j PVEFW-Drop");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j PVEFW-Drop");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j LOG --log-prefix \"PVEFW-FORWARD-dropped \" --log-level $loglevel");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j LOG --log-prefix \"PVEFW-FORWARD-dropped \" --log-level $loglevel");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j DROP");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j DROP");
}
if (!ruleset_chain_exist($ruleset, "$bridge-OUT")) {
ruleset_create_chain($ruleset, "$bridge-OUT");
ruleset_addrule($ruleset, "$bridge-FW", "-m physdev --physdev-is-bridged --physdev-is-in -j $bridge-OUT");
+ ruleset_addrule($ruleset, "PVEFW-INPUT", "-i $bridge -m physdev --physdev-is-bridged --physdev-is-in -j $bridge-OUT");
}
if (!ruleset_chain_exist($ruleset, "$bridge-IN")) {
}
}
+sub ruleset_add_chain_policy {
+ my ($ruleset, $chain, $policy, $loglevel, $accept_action) = @_;
+
+ if ($policy eq 'ACCEPT') {
+
+ ruleset_generate_rule($ruleset, $chain, { action => 'ACCEPT' },
+ { ACCEPT => $accept_action});
+
+ } elsif ($policy eq 'DROP') {
+
+ ruleset_addrule($ruleset, $chain, "-j PVEFW-Drop");
+
+ ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"$chain-dropped: \" --log-level $loglevel")
+ if defined($loglevel);
+
+ ruleset_addrule($ruleset, $chain, "-j DROP");
+ } elsif ($policy eq 'REJECT') {
+ ruleset_addrule($ruleset, $chain, "-j PVEFW-Reject");
+
+ ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"$chain-reject: \" --log-level $loglevel")
+ if defined($loglevel);
+
+ ruleset_addrule($ruleset, $chain, "-g PVEFW-reject");
+ } else {
+ # should not happen
+ die "internal error: unknown policy '$policy'";
+ }
+}
+
sub generate_tap_rules_direction {
my ($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, $direction) = @_;
ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate INVALID -j DROP");
ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
- if ($direction eq 'OUT' && defined($macaddr) &&
- !(defined($options->{macfilter}) && $options->{macfilter} == 0)) {
- ruleset_addrule($ruleset, $tapchain, "-m mac ! --mac-source $macaddr -j DROP");
+ if ($direction eq 'OUT') {
+ if (defined($macaddr) && !(defined($options->{macfilter}) && $options->{macfilter} == 0)) {
+ ruleset_addrule($ruleset, $tapchain, "-m mac ! --mac-source $macaddr -j DROP");
+ }
+ ruleset_addrule($ruleset, $tapchain, "-j MARK --set-mark 0"); # clear mark
}
foreach my $rule (@$rules) {
if ($direction eq 'OUT') {
$policy = $options->{'policy-out'} || 'ACCEPT'; # allow everything by default
} else {
- $policy = $options->{'policy-in'} || 'DROP'; # allow everything by default
+ $policy = $options->{'policy-in'} || 'DROP'; # allow nothing by default
}
- if ($policy eq 'ACCEPT') {
- if ($direction eq 'OUT') {
- ruleset_addrule($ruleset, $tapchain, "-g PVEFW-SET-ACCEPT-MARK");
- } else {
- ruleset_addrule($ruleset, $tapchain, "-j ACCEPT");
- }
- } elsif ($policy eq 'DROP') {
-
- ruleset_addrule($ruleset, $tapchain, "-j PVEFW-Drop");
-
- ruleset_addrule($ruleset, $tapchain, "-j LOG --log-prefix \"$tapchain-dropped: \" --log-level $loglevel")
- if defined($loglevel);
-
- ruleset_addrule($ruleset, $tapchain, "-j DROP");
- } elsif ($policy eq 'REJECT') {
- ruleset_addrule($ruleset, $tapchain, "-j PVEFW-Reject");
-
- ruleset_addrule($ruleset, $tapchain, "-j LOG --log-prefix \"$tapchain-reject: \" --log-level $loglevel")
- if defined($loglevel);
-
- ruleset_addrule($ruleset, $tapchain, "-g PVEFW-reject");
- } else {
- # should not happen
- die "internal error: unknown policy '$policy'";
- }
+ my $accept_action = $direction eq 'OUT' ? "PVEFW-SET-ACCEPT-MARK" : "ACCEPT";
+ ruleset_add_chain_policy($ruleset, $tapchain, $policy, $loglevel, $accept_action);
# plug the tap chain to bridge chain
my $physdevdirection = $direction eq 'IN' ? "out" : "in";
my $rule = "-m physdev --physdev-$physdevdirection $iface --physdev-is-bridged -j $tapchain";
ruleset_insertrule($ruleset, "$bridge-$direction", $rule);
-
- if ($direction eq 'OUT'){
- # add tap->host rules
- my $rule = "-m physdev --physdev-$physdevdirection $iface -j $tapchain";
- ruleset_addrule($ruleset, "PVEFW-INPUT", $rule);
- }
}
-sub enablehostfw {
+sub enable_host_firewall {
my ($ruleset, $hostfw_conf, $groups_conf) = @_;
# fixme: allow security groups
ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW -m multiport --dports 5404,5405 -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
+ # we use RETURN because we need to check also tap rules
+ my $accept_action = 'RETURN';
+
foreach my $rule (@$rules) {
next if $rule->{type} ne 'in';
- # we use RETURN because we need to check also tap rules
- ruleset_generate_rule($ruleset, $chain, $rule, { ACCEPT => 'RETURN', REJECT => "PVEFW-reject" });
+ ruleset_generate_rule($ruleset, $chain, $rule, { ACCEPT => $accept_action, REJECT => "PVEFW-reject" });
}
- ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-IN dropped: \" --log-level $loglevel")
- if defined($loglevel);
-
- ruleset_addrule($ruleset, $chain, "-j DROP");
+ # implement input policy
+ my $policy = $options->{'policy-in'} || 'DROP'; # allow nothing by default
+ ruleset_add_chain_policy($ruleset, $chain, $policy, $loglevel, $accept_action);
# host outbound firewall
$chain = "PVEFW-HOST-OUT";
ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW -m multiport --dports 5404,5405 -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
+ # we use RETURN because we may want to check other thigs later
+ $accept_action = 'RETURN';
+
foreach my $rule (@$rules) {
next if $rule->{type} ne 'out';
- # we use RETURN because we need to check also tap rules
- ruleset_generate_rule($ruleset, $chain, $rule, { ACCEPT => 'RETURN', REJECT => "PVEFW-reject" });
+ ruleset_generate_rule($ruleset, $chain, $rule, { ACCEPT => $accept_action, REJECT => "PVEFW-reject" });
}
- ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-OUT dropped: \" --log-level $loglevel")
- if defined($loglevel);
-
- ruleset_addrule($ruleset, $chain, "-j DROP");
+ # implement output policy
+ $policy = $options->{'policy-out'} || 'ACCEPT'; # allow everything by default
+ ruleset_add_chain_policy($ruleset, $chain, $policy, $loglevel, $accept_action);
ruleset_addrule($ruleset, "PVEFW-OUTPUT", "-j PVEFW-HOST-OUT");
ruleset_addrule($ruleset, "PVEFW-INPUT", "-j PVEFW-HOST-IN");
} elsif ($line =~ m/^(policy-(in|out)):\s*(ACCEPT|DROP|REJECT)\s*$/i) {
$opt = lc($1);
$value = uc($3);
+ } elsif ($line =~ m/^(nf_conntrack_max):\s*(\d+)\s*$/i) {
+ $opt = lc($1);
+ $value = int($2);
} else {
chomp $line;
die "can't parse option '$line'\n"
return $vmdata;
};
-sub read_vm_firewall_rules {
+sub read_vm_firewall_configs {
my ($vmdata) = @_;
- my $rules = {};
+ my $vmfw_configs = {};
foreach my $vmid (keys %{$vmdata->{qemu}}, keys %{$vmdata->{openvz}}) {
my $filename = "/etc/pve/firewall/$vmid.fw";
my $fh = IO::File->new($filename, O_RDONLY);
next if !$fh;
- $rules->{$vmid} = parse_vm_fw_rules($filename, $fh);
+ $vmfw_configs->{$vmid} = parse_vm_fw_rules($filename, $fh);
}
- return $rules;
+ return $vmfw_configs;
}
sub get_option_log_level {
# same as shorewall smurflog.
if (defined($loglevel)) {
$pve_std_chains-> {'PVEFW-smurflog'} = [
- "-j LOG --log-prefix \"smurfs-dropped\" --log-level $loglevel",
+ "-j LOG --log-prefix \"smurfs-dropped: \" --log-level $loglevel",
"-j DROP",
];
} else {
$loglevel = get_option_log_level($options, 'tcp_flags_log_level');
if (defined($loglevel)) {
$pve_std_chains-> {'PVEFW-logflags'} = [
- "-j LOG --log-prefix \"logflags-dropped:\" --log-level $loglevel --log-ip-options",
+ "-j LOG --log-prefix \"logflags-dropped: \" --log-level $loglevel --log-ip-options",
"-j DROP",
];
} else {
sub compile {
my $vmdata = read_local_vm_config();
- my $rules = read_vm_firewall_rules($vmdata);
+ my $vmfw_configs = read_vm_firewall_configs($vmdata);
my $groups_conf = {};
my $filename = "/etc/pve/firewall/groups.fw";
ruleset_create_chain($ruleset, "PVEFW-INPUT");
ruleset_create_chain($ruleset, "PVEFW-OUTPUT");
+
ruleset_create_chain($ruleset, "PVEFW-FORWARD");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
my $hostfw_options = {};
- my $hostfw_conf;
+ my $hostfw_conf = {};
$filename = "/etc/pve/local/host.fw";
if (my $fh = IO::File->new($filename, O_RDONLY)) {
generate_std_chains($ruleset, $hostfw_options);
- my $hostfw_enable = $hostfw_conf &&
- !(defined($hostfw_options->{enable}) && ($hostfw_options->{enable} == 0));
+ my $hostfw_enable = !(defined($hostfw_options->{enable}) && ($hostfw_options->{enable} == 0));
- enablehostfw($ruleset, $hostfw_conf, $groups_conf) if $hostfw_enable;
+ enable_host_firewall($ruleset, $hostfw_conf, $groups_conf) if $hostfw_enable;
# generate firewall rules for QEMU VMs
foreach my $vmid (keys %{$vmdata->{qemu}}) {
my $conf = $vmdata->{qemu}->{$vmid};
- my $vmfw_conf = $rules->{$vmid};
+ my $vmfw_conf = $vmfw_configs->{$vmid};
next if !$vmfw_conf;
next if defined($vmfw_conf->{options}->{enable}) && ($vmfw_conf->{options}->{enable} == 0);
$bridge .= "v$net->{tag}" if $net->{tag};
- generate_bridge_chains($ruleset, $bridge);
+ generate_bridge_chains($ruleset, $hostfw_conf, $bridge);
my $macaddr = $net->{macaddr};
generate_tap_rules_direction($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, 'IN');
}
}
- if ($hostfw_enable) {
- # allow traffic from lo (ourself)
- ruleset_addrule($ruleset, "PVEFW-INPUT", "-i lo -j ACCEPT");
- }
-
- return $ruleset;
+ return wantarray ? ($ruleset, $hostfw_conf) : $ruleset;
}
sub get_ruleset_status {
die "unable to apply firewall changes\n" if $errors;
}
+sub update_nf_conntrack_max {
+ my ($hostfw_conf) = @_;
+
+ my $max = 65536; # reasonable default
+
+ my $options = $hostfw_conf->{options} || {};
+
+ if (defined($options->{nf_conntrack_max}) && ($options->{nf_conntrack_max} > $max)) {
+ $max = $options->{nf_conntrack_max};
+ $max = int(($max+ 8191)/8192)*8192; # round to multiples of 8192
+ }
+
+ my $filename_nf_conntrack_max = "/proc/sys/net/nf_conntrack_max";
+ my $filename_hashsize = "/sys/module/nf_conntrack/parameters/hashsize";
+
+ my $current = int(PVE::Tools::file_read_firstline($filename_nf_conntrack_max) || $max);
+
+ if ($current != $max) {
+ my $hashsize = int($max/4);
+ PVE::ProcFSTools::write_proc_entry($filename_hashsize, $hashsize);
+ PVE::ProcFSTools::write_proc_entry($filename_nf_conntrack_max, $max);
+ }
+}
+
sub update {
my ($start, $verbose) = @_;
my $code = sub {
my $status = read_pvefw_status();
- my $ruleset = PVE::Firewall::compile();
+ my ($ruleset, $hostfw_conf) = PVE::Firewall::compile();
+
+ update_nf_conntrack_max($hostfw_conf);
if ($start || $status eq 'active') {
projects / pve-firewall.git / blobdiff