use strict;
use Data::Dumper;
use Digest::SHA;
+use PVE::INotify;
+use PVE::Cluster;
use PVE::ProcFSTools;
use PVE::Tools;
use PVE::QemuServer;
+use PVE::OpenVZ; # dependeny problem?!
use File::Basename;
use File::Path;
use IO::File;
use Data::Dumper;
+# fixme: use ULOG instead of LOG?
+
+my $nodename = PVE::INotify::nodename();
+
my $pve_fw_lock_filename = "/var/lock/pvefw.lck";
my $pve_fw_status_filename = "/var/lib/pve-firewall/pvefw.status";
return 1 if $name =~ m/^PVEFW-\S+$/;
return 1 if $name =~ m/^tap\d+i\d+-(:?IN|OUT)$/;
+
+ return 1 if $name =~ m/^veth\d+.\d+-(:?IN|OUT)$/; # fixme: dev name is configurable
+
+ return 1 if $name =~ m/^venet0-\d+-(:?IN|OUT)$/;
+
return 1 if $name =~ m/^vmbr\d+-(:?FW|IN|OUT)$/;
return 1 if $name =~ m/^GROUP-(:?[^\s\-]+)-(:?IN|OUT)$/;
return 1;
}
-sub ruleset_generate_rule {
+sub ruleset_generate_cmdstr {
my ($ruleset, $chain, $rule, $actions, $goto) = @_;
return if $rule->{disable};
my @cmd = ();
+ push @cmd, "-i $rule->{iface_in}" if $rule->{iface_in};
+ push @cmd, "-o $rule->{iface_out}" if $rule->{iface_out};
+
push @cmd, "-m iprange --src-range" if $rule->{nbsource} && $rule->{nbsource} > 1;
push @cmd, "-s $rule->{source}" if $rule->{source};
push @cmd, "-m iprange --dst-range" if $rule->{nbdest} && $rule->{nbdest} > 1;
push @cmd, $goto ? "-g $action" : "-j $action";
}
- if (scalar(@cmd)) {
- my $cmdstr = join(' ', @cmd);
+ return scalar(@cmd) ? join(' ', @cmd) : undef;
+}
+
+sub ruleset_generate_rule {
+ my ($ruleset, $chain, $rule, $actions, $goto) = @_;
+
+ if (my $cmdstr = ruleset_generate_cmdstr($ruleset, $chain, $rule, $actions, $goto)) {
ruleset_addrule($ruleset, $chain, $cmdstr);
}
}
+sub ruleset_generate_rule_insert {
+ my ($ruleset, $chain, $rule, $actions, $goto) = @_;
+
+ if (my $cmdstr = ruleset_generate_cmdstr($ruleset, $chain, $rule, $actions, $goto)) {
+ ruleset_insertrule($ruleset, $chain, $cmdstr);
+ }
+}
sub ruleset_create_chain {
my ($ruleset, $chain) = @_;
}
sub generate_bridge_chains {
- my ($ruleset, $hostfw_conf, $bridge) = @_;
+ my ($ruleset, $hostfw_conf, $bridge, $routing_table) = @_;
- my $options = $hostfw_conf->{options};
-
- # fixme: what log level should we use here?
- my $loglevel = get_option_log_level($options, "log_level_out");
+ my $options = $hostfw_conf->{options} || {};
+
+ die "error: detected direct route to bridge '$bridge'\n"
+ if !$options->{allow_bridge_route} && $routing_table->{$bridge};
if (!ruleset_chain_exist($ruleset, "$bridge-FW")) {
ruleset_create_chain($ruleset, "$bridge-FW");
ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -m physdev --physdev-is-bridged -j $bridge-FW");
ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -m physdev --physdev-is-bridged -j $bridge-FW");
- # disable interbridge routing
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j PVEFW-Drop");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j PVEFW-Drop");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j LOG --log-prefix \"PVEFW-FORWARD-dropped \" --log-level $loglevel");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j LOG --log-prefix \"PVEFW-FORWARD-dropped \" --log-level $loglevel");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j DROP");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j DROP");
}
if (!ruleset_chain_exist($ruleset, "$bridge-OUT")) {
ruleset_create_chain($ruleset, "$bridge-OUT");
ruleset_addrule($ruleset, "$bridge-FW", "-m physdev --physdev-is-bridged --physdev-is-in -j $bridge-OUT");
- ruleset_addrule($ruleset, "PVEFW-INPUT", "-i $bridge -m physdev --physdev-is-bridged --physdev-is-in -j $bridge-OUT");
+ ruleset_insertrule($ruleset, "PVEFW-INPUT", "-i $bridge -m physdev --physdev-is-bridged --physdev-is-in -j $bridge-OUT");
}
if (!ruleset_chain_exist($ruleset, "$bridge-IN")) {
}
}
-sub generate_tap_rules_direction {
- my ($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, $direction) = @_;
-
- my $lc_direction = lc($direction);
-
- my $rules = $vmfw_conf->{rules};
+sub ruleset_create_vm_chain {
+ my ($ruleset, $chain, $options, $macaddr, $direction) = @_;
- my $options = $vmfw_conf->{options};
- my $loglevel = get_option_log_level($options, "log_level_${lc_direction}");
-
- my $tapchain = "$iface-$direction";
-
- ruleset_create_chain($ruleset, $tapchain);
+ ruleset_create_chain($ruleset, $chain);
if (!(defined($options->{nosmurfs}) && $options->{nosmurfs} == 0)) {
- ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate INVALID,NEW -j PVEFW-smurfs");
+ ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate INVALID,NEW -j PVEFW-smurfs");
}
if (!(defined($options->{dhcp}) && $options->{dhcp} == 0)) {
- ruleset_addrule($ruleset, $tapchain, "-p udp -m udp --dport 67:68 -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 67:68 -j ACCEPT");
}
if ($options->{tcpflags}) {
- ruleset_addrule($ruleset, $tapchain, "-p tcp -j PVEFW-tcpflags");
+ ruleset_addrule($ruleset, $chain, "-p tcp -j PVEFW-tcpflags");
}
- ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate INVALID -j DROP");
- ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate INVALID -j DROP");
+ ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
if ($direction eq 'OUT') {
if (defined($macaddr) && !(defined($options->{macfilter}) && $options->{macfilter} == 0)) {
- ruleset_addrule($ruleset, $tapchain, "-m mac ! --mac-source $macaddr -j DROP");
+ ruleset_addrule($ruleset, $chain, "-m mac ! --mac-source $macaddr -j DROP");
}
- ruleset_addrule($ruleset, $tapchain, "-j MARK --set-mark 0"); # clear mark
+ ruleset_addrule($ruleset, $chain, "-j MARK --set-mark 0"); # clear mark
}
+}
+
+sub ruleset_generate_vm_rules {
+ my ($ruleset, $rules, $groups_conf, $chain, $netid, $direction) = @_;
+
+ my $lc_direction = lc($direction);
foreach my $rule (@$rules) {
next if $rule->{iface} && $rule->{iface} ne $netid;
if(!ruleset_chain_exist($ruleset, $group_chain)){
generate_group_rules($ruleset, $groups_conf, $rule->{action});
}
- ruleset_addrule($ruleset, $tapchain, "-j $group_chain");
- ruleset_addrule($ruleset, $tapchain, "-m mark --mark 1 -j RETURN")
+ ruleset_addrule($ruleset, $chain, "-j $group_chain");
+ ruleset_addrule($ruleset, $chain, "-m mark --mark 1 -j RETURN")
if $direction eq 'OUT';
} else {
next if $rule->{type} ne $lc_direction;
if ($direction eq 'OUT') {
- ruleset_generate_rule($ruleset, $tapchain, $rule,
+ ruleset_generate_rule($ruleset, $chain, $rule,
{ ACCEPT => "PVEFW-SET-ACCEPT-MARK", REJECT => "PVEFW-reject" });
} else {
- ruleset_generate_rule($ruleset, $tapchain, $rule, { REJECT => "PVEFW-reject" });
+ ruleset_generate_rule($ruleset, $chain, $rule, { REJECT => "PVEFW-reject" });
}
}
}
+}
+
+sub generate_venet_rules_direction {
+ my ($ruleset, $groups_conf, $vmfw_conf, $vmid, $ip, $direction) = @_;
+
+ parse_address_list($ip); # make sure we have a valid $ip list
+
+ my $lc_direction = lc($direction);
+
+ my $rules = $vmfw_conf->{rules};
+
+ my $options = $vmfw_conf->{options};
+ my $loglevel = get_option_log_level($options, "log_level_${lc_direction}");
+
+ my $chain = "venet0-$vmid-$direction";
+
+ ruleset_create_vm_chain($ruleset, $chain, $options, undef, $direction);
+
+ ruleset_generate_vm_rules($ruleset, $rules, $groups_conf, $chain, 'venet', $direction);
# implement policy
my $policy;
if ($direction eq 'OUT') {
- $policy = $options->{'policy-out'} || 'ACCEPT'; # allow everything by default
+ $policy = $options->{policy_out} || 'ACCEPT'; # allow everything by default
} else {
- $policy = $options->{'policy-in'} || 'DROP'; # allow nothing by default
+ $policy = $options->{policy_in} || 'DROP'; # allow nothing by default
+ }
+
+ my $accept_action = $direction eq 'OUT' ? "PVEFW-SET-ACCEPT-MARK" : "ACCEPT";
+ ruleset_add_chain_policy($ruleset, $chain, $policy, $loglevel, $accept_action);
+
+ # plug into FORWARD, INPUT and OUTPUT chain
+ if ($direction eq 'OUT') {
+ ruleset_generate_rule_insert($ruleset, "PVEFW-FORWARD", {
+ action => $chain,
+ source => $ip,
+ iface_in => 'venet0'});
+
+ ruleset_generate_rule_insert($ruleset, "PVEFW-INPUT", {
+ action => $chain,
+ source => $ip,
+ iface_in => 'venet0'});
+ } else {
+ ruleset_generate_rule($ruleset, "PVEFW-FORWARD", {
+ action => $chain,
+ dest => $ip,
+ iface_out => 'venet0'});
+
+ ruleset_generate_rule($ruleset, "PVEFW-OUTPUT", {
+ action => $chain,
+ dest => $ip,
+ iface_out => 'venet0'});
+ }
+}
+
+sub generate_tap_rules_direction {
+ my ($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, $direction) = @_;
+
+ my $lc_direction = lc($direction);
+
+ my $rules = $vmfw_conf->{rules};
+
+ my $options = $vmfw_conf->{options};
+ my $loglevel = get_option_log_level($options, "log_level_${lc_direction}");
+
+ my $tapchain = "$iface-$direction";
+
+ ruleset_create_vm_chain($ruleset, $tapchain, $options, $macaddr, $direction);
+
+ ruleset_generate_vm_rules($ruleset, $rules, $groups_conf, $tapchain, $netid, $direction);
+
+ # implement policy
+ my $policy;
+
+ if ($direction eq 'OUT') {
+ $policy = $options->{policy_out} || 'ACCEPT'; # allow everything by default
+ } else {
+ $policy = $options->{policy_in} || 'DROP'; # allow nothing by default
}
my $accept_action = $direction eq 'OUT' ? "PVEFW-SET-ACCEPT-MARK" : "ACCEPT";
ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-i lo -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
- ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW -m multiport --dports 5404,5405 -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW --dport 5404:5405 -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
# we use RETURN because we need to check also tap rules
}
# implement input policy
- my $policy = $options->{'policy-in'} || 'DROP'; # allow nothing by default
+ my $policy = $options->{policy_in} || 'DROP'; # allow nothing by default
ruleset_add_chain_policy($ruleset, $chain, $policy, $loglevel, $accept_action);
# host outbound firewall
ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-o lo -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
- ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW -m multiport --dports 5404,5405 -j ACCEPT");
+ ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW --dport 5404:5405 -j ACCEPT");
ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
# we use RETURN because we may want to check other thigs later
}
# implement output policy
- $policy = $options->{'policy-out'} || 'ACCEPT'; # allow everything by default
+ $policy = $options->{policy_out} || 'ACCEPT'; # allow everything by default
ruleset_add_chain_policy($ruleset, $chain, $policy, $loglevel, $accept_action);
ruleset_addrule($ruleset, "PVEFW-OUTPUT", "-j PVEFW-HOST-OUT");
if ($need_iface) {
$iface = undef if $iface && $iface eq '-';
- die "unknown interface '$iface'\n"
- if defined($iface) && !$valid_netdev_names->{$iface};
}
$proto = undef if $proto && $proto eq '-';
} elsif ($line =~ m/^(log_level_in|log_level_out):\s*(($loglevels)\s*)?$/i) {
$opt = lc($1);
$value = $2 ? lc($3) : '';
- } elsif ($line =~ m/^(policy-(in|out)):\s*(ACCEPT|DROP|REJECT)\s*$/i) {
+ } elsif ($line =~ m/^(policy_(in|out)):\s*(ACCEPT|DROP|REJECT)\s*$/i) {
$opt = lc($1);
$value = uc($3);
} else {
my $loglevels = "emerg|alert|crit|err|warning|notice|info|debug|nolog";
- if ($line =~ m/^(enable|dhcp|nosmurfs|tcpflags):\s*(0|1)\s*$/i) {
+ if ($line =~ m/^(enable|dhcp|nosmurfs|tcpflags|allow_bridge_route):\s*(0|1)\s*$/i) {
$opt = lc($1);
$value = int($2);
} elsif ($line =~ m/^(log_level_in|log_level_out|tcp_flags_log_level|smurf_log_level):\s*(($loglevels)\s*)?$/i) {
$opt = lc($1);
$value = $2 ? lc($3) : '';
- } elsif ($line =~ m/^(policy-(in|out)):\s*(ACCEPT|DROP|REJECT)\s*$/i) {
+ } elsif ($line =~ m/^(policy_(in|out)):\s*(ACCEPT|DROP|REJECT)\s*$/i) {
$opt = lc($1);
$value = uc($3);
+ } elsif ($line =~ m/^(nf_conntrack_max):\s*(\d+)\s*$/i) {
+ $opt = lc($1);
+ $value = int($2);
} else {
chomp $line;
die "can't parse option '$line'\n"
sub read_local_vm_config {
my $openvz = {};
-
my $qemu = {};
- my $list = PVE::QemuServer::config_list();
+ my $vmdata = { openvz => $openvz, qemu => $qemu };
- foreach my $vmid (keys %$list) {
- my $cfspath = PVE::QemuServer::cfs_config_path($vmid);
- if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
- $qemu->{$vmid} = $conf;
+ my $vmlist = PVE::Cluster::get_vmlist();
+ return $vmdata if !$vmlist || !$vmlist->{ids};
+ my $ids = $vmlist->{ids};
+
+ foreach my $vmid (keys %$ids) {
+ next if !$vmid; # skip VE0
+ my $d = $ids->{$vmid};
+ next if !$d->{node} || $d->{node} ne $nodename;
+ next if !$d->{type};
+ if ($d->{type} eq 'openvz') {
+ my $cfspath = PVE::OpenVZ::cfs_config_path($vmid);
+ if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
+ $openvz->{$vmid} = $conf;
+ }
+ } elsif ($d->{type} eq 'qemu') {
+ my $cfspath = PVE::QemuServer::cfs_config_path($vmid);
+ if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
+ $qemu->{$vmid} = $conf;
+ }
}
}
-
- my $vmdata = { openvz => $openvz, qemu => $qemu };
-
+
return $vmdata;
};
-sub read_vm_firewall_rules {
+sub read_vm_firewall_configs {
my ($vmdata) = @_;
- my $rules = {};
+ my $vmfw_configs = {};
+
foreach my $vmid (keys %{$vmdata->{qemu}}, keys %{$vmdata->{openvz}}) {
my $filename = "/etc/pve/firewall/$vmid.fw";
my $fh = IO::File->new($filename, O_RDONLY);
next if !$fh;
- $rules->{$vmid} = parse_vm_fw_rules($filename, $fh);
+ $vmfw_configs->{$vmid} = parse_vm_fw_rules($filename, $fh);
}
- return $rules;
+ return $vmfw_configs;
}
sub get_option_log_level {
return $status;
}
+# fixme: move to pve-common PVE::ProcFSTools
+sub read_proc_net_route {
+ my $filename = "/proc/net/route";
+
+ my $res = {};
+
+ my $fh = IO::File->new ($filename, "r");
+ return $res if !$fh;
+
+ my $int_to_quad = sub {
+ return join '.' => map { ($_[0] >> 8*(3-$_)) % 256 } (3, 2, 1, 0);
+ };
+
+ while (defined(my $line = <$fh>)) {
+ next if $line =~/^Iface\s+Destination/; # skip head
+ my ($iface, $dest, $gateway, $metric, $mask, $mtu) = (split(/\s+/, $line))[0,1,2,6,7,8];
+ push @{$res->{$iface}}, {
+ dest => &$int_to_quad(hex($dest)),
+ gateway => &$int_to_quad(hex($gateway)),
+ mask => &$int_to_quad(hex($mask)),
+ metric => $metric,
+ mtu => $mtu,
+ };
+ }
+
+ return $res;
+}
+
sub compile {
my $vmdata = read_local_vm_config();
- my $rules = read_vm_firewall_rules($vmdata);
+ my $vmfw_configs = read_vm_firewall_configs($vmdata);
+
+ my $routing_table = read_proc_net_route();
my $groups_conf = {};
my $filename = "/etc/pve/firewall/groups.fw";
$groups_conf = parse_group_fw_rules($filename, $fh);
}
- #print Dumper($rules);
-
my $ruleset = {};
ruleset_create_chain($ruleset, "PVEFW-INPUT");
ruleset_create_chain($ruleset, "PVEFW-OUTPUT");
ruleset_create_chain($ruleset, "PVEFW-FORWARD");
- ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
my $hostfw_options = {};
- my $hostfw_conf;
+ my $hostfw_conf = {};
$filename = "/etc/pve/local/host.fw";
if (my $fh = IO::File->new($filename, O_RDONLY)) {
generate_std_chains($ruleset, $hostfw_options);
- my $hostfw_enable = $hostfw_conf &&
- !(defined($hostfw_options->{enable}) && ($hostfw_options->{enable} == 0));
+ my $hostfw_enable = !(defined($hostfw_options->{enable}) && ($hostfw_options->{enable} == 0));
enable_host_firewall($ruleset, $hostfw_conf, $groups_conf) if $hostfw_enable;
# generate firewall rules for QEMU VMs
foreach my $vmid (keys %{$vmdata->{qemu}}) {
my $conf = $vmdata->{qemu}->{$vmid};
- my $vmfw_conf = $rules->{$vmid};
+ my $vmfw_conf = $vmfw_configs->{$vmid};
next if !$vmfw_conf;
next if defined($vmfw_conf->{options}->{enable}) && ($vmfw_conf->{options}->{enable} == 0);
$bridge .= "v$net->{tag}" if $net->{tag};
- generate_bridge_chains($ruleset, $hostfw_conf, $bridge);
+ generate_bridge_chains($ruleset, $hostfw_conf, $bridge, $routing_table);
my $macaddr = $net->{macaddr};
generate_tap_rules_direction($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, 'IN');
}
}
- return $ruleset;
+ # generate firewall rules for OpenVZ containers
+ foreach my $vmid (keys %{$vmdata->{openvz}}) {
+ my $conf = $vmdata->{openvz}->{$vmid};
+
+ my $vmfw_conf = $vmfw_configs->{$vmid};
+ next if !$vmfw_conf;
+ next if defined($vmfw_conf->{options}->{enable}) && ($vmfw_conf->{options}->{enable} == 0);
+
+ if ($conf->{ip_address} && $conf->{ip_address}->{value}) {
+ my $ip = $conf->{ip_address}->{value};
+ generate_venet_rules_direction($ruleset, $groups_conf, $vmfw_conf, $vmid, $ip, 'IN');
+ generate_venet_rules_direction($ruleset, $groups_conf, $vmfw_conf, $vmid, $ip, 'OUT');
+ }
+
+ if ($conf->{netif} && $conf->{netif}->{value}) {
+ my $netif = PVE::OpenVZ::parse_netif($conf->{netif}->{value});
+ foreach my $netid (keys %$netif) {
+ my $d = $netif->{$netid};
+ my $bridge = $d->{bridge};
+ if (!$bridge) {
+ warn "no bridge device for CT $vmid iface '$netid'\n";
+ next; # fixme?
+ }
+
+ generate_bridge_chains($ruleset, $hostfw_conf, $bridge, $routing_table);
+
+ my $macaddr = $d->{host_mac};
+ my $iface = $d->{host_ifname};
+ generate_tap_rules_direction($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, 'IN');
+ generate_tap_rules_direction($ruleset, $groups_conf, $iface, $netid, $macaddr, $vmfw_conf, $bridge, 'OUT');
+ }
+ }
+ }
+
+ # fixme: this is an optimization? if so, we should also drop INVALID packages?
+ ruleset_insertrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
+
+ # fixme: what log level should we use here?
+ my $loglevel = get_option_log_level($hostfw_options, "log_level_out");
+
+ # fixme: should we really block inter-bridge traffic?
+
+ # always allow traffic from containers?
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i venet0 -j RETURN");
+
+ # disable interbridge routing
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o vmbr+ -j PVEFW-Drop");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i vmbr+ -j PVEFW-Drop");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o vmbr+ -j LOG --log-prefix \"PVEFW-FORWARD-dropped \" --log-level $loglevel");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i vmbr+ -j LOG --log-prefix \"PVEFW-FORWARD-dropped \" --log-level $loglevel");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o vmbr+ -j DROP");
+ ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i vmbr+ -j DROP");
+
+ return wantarray ? ($ruleset, $hostfw_conf) : $ruleset;
}
sub get_ruleset_status {
}
sub apply_ruleset {
- my ($ruleset, $verbose) = @_;
+ my ($ruleset, $hostfw_conf, $verbose) = @_;
enable_bridge_firewall();
+ update_nf_conntrack_max($hostfw_conf);
+
my $cmdlist = get_rulset_cmdlist($ruleset, $verbose);
print $cmdlist if $verbose;
die "unable to apply firewall changes\n" if $errors;
}
+sub update_nf_conntrack_max {
+ my ($hostfw_conf) = @_;
+
+ my $max = 65536; # reasonable default
+
+ my $options = $hostfw_conf->{options} || {};
+
+ if (defined($options->{nf_conntrack_max}) && ($options->{nf_conntrack_max} > $max)) {
+ $max = $options->{nf_conntrack_max};
+ $max = int(($max+ 8191)/8192)*8192; # round to multiples of 8192
+ }
+
+ my $filename_nf_conntrack_max = "/proc/sys/net/nf_conntrack_max";
+ my $filename_hashsize = "/sys/module/nf_conntrack/parameters/hashsize";
+
+ my $current = int(PVE::Tools::file_read_firstline($filename_nf_conntrack_max) || $max);
+
+ if ($current != $max) {
+ my $hashsize = int($max/4);
+ PVE::ProcFSTools::write_proc_entry($filename_hashsize, $hashsize);
+ PVE::ProcFSTools::write_proc_entry($filename_nf_conntrack_max, $max);
+ }
+}
+
sub update {
my ($start, $verbose) = @_;
my $code = sub {
my $status = read_pvefw_status();
- my $ruleset = PVE::Firewall::compile();
+ my ($ruleset, $hostfw_conf) = PVE::Firewall::compile();
if ($start || $status eq 'active') {
save_pvefw_status('active') if ($status ne 'active');
- PVE::Firewall::apply_ruleset($ruleset, $verbose);
+ apply_ruleset($ruleset, $hostfw_conf, $verbose);
} else {
print "Firewall not active (status = $status)\n" if $verbose;
}
projects / pve-firewall.git / blobdiff