improve error messages

[pve-firewall.git] / test / fwtester.pl

diff --git a/test/fwtester.pl b/test/fwtester.pl
index 2b577bafd1d92b3b62a508daaacd82c7d0a40071..36b38bc9979f48d3b3e4d323ca4a4f876d74f2ed 100755 (executable)
--- a/test/fwtester.pl
+++ b/test/fwtester.pl
@@ -14,6 +14,9 @@ my $trace;
 my $outside_iface = 'eth0';
 my $outside_bridge = 'vmbr0';
 
+my $nfvm_iface = 'tapXYZ';
+my $nfvm_bridge = 'vmbr0';
+
 my $debug = 0;
 
 sub print_usage_and_exit {
@@ -37,6 +40,13 @@ sub add_trace {
     }
 }
 
+sub nf_dev_match {
+    my ($devre, $dev) = @_;
+
+    $devre =~ s/\+$/\.\*/;
+    return  ($dev =~ m/^${devre}$/) ? 1 : 0;
+}
+
 sub rule_match {
     my ($chain, $rule, $pkg) = @_;
 
@@ -51,12 +61,14 @@ sub rule_match {
     }
 
     if ($rule =~ s/^-i (\S+)\s*//) {
+       my $devre = $1;
        die "missing iface_in" if !$pkg->{iface_in};
-       return undef if $pkg->{iface_in} ne $1; # no match
+       return undef if !nf_dev_match($devre, $pkg->{iface_in});
     }
     if ($rule =~ s/^-o (\S+)\s*//) {
+       my $devre = $1;
        die "missing iface_out" if !$pkg->{iface_out};
-       return undef if $pkg->{iface_out} ne $1; # no match
+       return undef if !nf_dev_match($devre, $pkg->{iface_out});
     }
 
     if ($rule =~ s/^-p (tcp|udp)\s*//) {
@@ -91,16 +103,14 @@ sub rule_match {
 
     if ($rule =~ s/^-m physdev --physdev-is-bridged --physdev-in (\S+)\s*//) {
        my $devre = $1;
-       $devre =~ s/\+/\.\*/;
        return undef if !$pkg->{physdev_in};
-       return undef if $pkg->{physdev_in} !~ m/^${devre}$/;
+       return undef if !nf_dev_match($devre, $pkg->{physdev_in});
     }
 
     if ($rule =~ s/^-m physdev --physdev-is-bridged --physdev-out (\S+)\s*//) {
        my $devre = $1;
-       $devre =~ s/\+/\.\*/;
        return undef if !$pkg->{physdev_out};
-       return undef if $pkg->{physdev_out} !~ m/^${devre}$/;
+       return undef if !nf_dev_match($devre, $pkg->{physdev_out});
     }
 
     if ($rule =~ s/^-j MARK --set-mark (\d+)\s*$//) {
@@ -124,7 +134,7 @@ sub ruleset_simulate_chain {
 
     add_trace("ENTER chain $chain\n");
     
-    my $counter = 2; # ENTER + LEAVE = 2
+    my $counter = 0;
 
     if ($chain eq 'PVEFW-Drop') {
        add_trace("LEAVE chain $chain\n");
@@ -217,6 +227,9 @@ sub route_packet {
        if ($route_state eq 'from-outside') {
            $next_route_state = $outside_bridge || die 'internal error';
            $next_physdev_in = $outside_iface || die 'internal error';
+       } elsif ($route_state eq 'from-nfvm') {
+           $next_route_state = $nfvm_bridge || die 'internal error';
+           $next_physdev_in = $nfvm_iface || die 'internal error';
        } elsif ($route_state eq 'host') {
 
            if ($target->{type} eq 'outside') {
@@ -224,6 +237,11 @@ sub route_packet {
                $pkg->{iface_out} = $outside_bridge;
                $chain = 'PVEFW-OUTPUT';
                $next_route_state = $outside_iface
+           } elsif ($target->{type} eq 'nfvm') {
+               $pkg->{iface_in} = 'lo';
+               $pkg->{iface_out} = $nfvm_bridge;
+               $chain = 'PVEFW-OUTPUT';
+               $next_route_state = $nfvm_iface
            } elsif ($target->{type} eq 'ct') {
                $pkg->{iface_in} = 'lo';
                $pkg->{iface_out} = 'venet0';
@@ -254,6 +272,13 @@ sub route_packet {
                $pkg->{iface_out} = $outside_bridge;
                $next_route_state = $outside_iface;
 
+           } elsif ($target->{type} eq 'nfvm') {
+               
+               $chain = 'PVEFW-FORWARD';
+               $pkg->{iface_in} = 'venet0';
+               $pkg->{iface_out} = $nfvm_bridge;
+               $next_route_state = $nfvm_iface;
+
            } elsif ($target->{type} eq 'vm') {
 
                $chain = 'PVEFW-FORWARD';
@@ -314,6 +339,17 @@ sub route_packet {
                }
                $next_route_state = $outside_iface;
 
+           } elsif ($target->{type} eq 'nfvm') {
+
+               $chain = 'PVEFW-FORWARD';
+               $pkg->{iface_in} = $route_state;
+               $pkg->{iface_out} = $nfvm_bridge;
+               # conditionally set physdev_out (same behavior as kernel)
+               if ($route_state eq $nfvm_bridge) {
+                   $pkg->{physdev_out} = $nfvm_iface || die 'internal error';
+               }
+               $next_route_state = $nfvm_iface;
+
            } elsif ($target->{type} eq 'ct') {
 
                $chain = 'PVEFW-FORWARD';
@@ -424,6 +460,9 @@ sub simulate_firewall {
     } elsif ($from eq 'outside') {
        $from_info->{type} = 'outside';
        $start_state = 'from-outside';
+    } elsif ($from eq 'nfvm') {
+       $from_info->{type} = 'nfvm';
+       $start_state = 'from-nfvm';
     } elsif ($from =~ m/^ct(\d+)$/) {
        my $vmid = $1;
        $from_info = extract_ct_info($vmdata, $vmid);
@@ -439,7 +478,7 @@ sub simulate_firewall {
        $start_state = 'fwbr-out'; 
        $pkg->{mac_source} = $from_info->{macaddr};
     } else {
-       die "implement me";
+       die "unable to parse \"from => '$from'\"\n";
     }
 
     my $target;
@@ -450,6 +489,9 @@ sub simulate_firewall {
     } elsif ($to eq 'outside') {
        $target->{type} = 'outside';
        $target->{iface} = $outside_iface;
+     } elsif ($to eq 'nfvm') {
+       $target->{type} = 'nfvm';
+       $target->{iface} = $nfvm_iface;
     } elsif ($to =~ m/^ct(\d+)$/) {
        my $vmid = $1;
        $target = extract_ct_info($vmdata, $vmid);
@@ -465,7 +507,7 @@ sub simulate_firewall {
        $target = extract_vm_info($vmdata, $vmid);
        $target->{iface} = $target->{tapdev};
     } else {
-       die "implement me";
+       die "unable to parse \"to => '$to'\"\n";
     }
 
     my ($res, $ic, $rc) = route_packet($ruleset, $ipset_ruleset, $pkg,