X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=blobdiff_plain;f=PVE%2FFirewall.pm;h=43b42a28b2e29eb54a8ad469dae5a8945123c647;hp=fde72fdf99e800b9fd0f833e8cca9a50d20d58a8;hb=a104121732bddbd34a5870f4ad255be5fa5c0a49;hpb=e3a1d391206d419fadf1f78896dd1dc7f6c9b0b4 diff --git a/PVE/Firewall.pm b/PVE/Firewall.pm index fde72fd..43b42a2 100644 --- a/PVE/Firewall.pm +++ b/PVE/Firewall.pm @@ -736,7 +736,7 @@ sub ruleset_generate_rule { if ($rule->{dport}) { if ($rule->{proto} && $rule->{proto} eq 'icmp') { # Note: we use dport to store --icmp-type - die "unknown icmp-type '$rule->{dport}'\n" if !$icmp_type_names->{$rule->{dport}}; + die "unknown icmp-type '$rule->{dport}'\n" if !defined($icmp_type_names->{$rule->{dport}}); $cmd .= " -m icmp --icmp-type $rule->{dport}"; } else { if ($rule->{nbdport} && $rule->{nbdport} > 1) {