X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=blobdiff_plain;f=PVE%2FFirewall.pm;h=ea24cfb40069adf915e233843182b6511bdcdf09;hp=876700867bbf61112887fde8fd9dd2ef45583828;hb=7b291cabd7a69a441cae666b2c94ab49106cf592;hpb=fcba0bebc7b7997845220cdff0fb16b31a886b3e

diff --git a/PVE/Firewall.pm b/PVE/Firewall.pm
index 8767008..ea24cfb 100644
--- a/PVE/Firewall.pm
+++ b/PVE/Firewall.pm
@@ -3,25 +3,367 @@ package PVE::Firewall;
 use warnings;
 use strict;
 use Data::Dumper;
+use Digest::SHA;
 use PVE::Tools;
 use PVE::QemuServer;
 use File::Path;
 use IO::File;
 use Net::IP;
+use PVE::Tools qw(run_command lock_file);
 
 use Data::Dumper;
 
-my $macros;
-sub get_shorewall_macros {
+my $pve_fw_lock_filename = "/var/lock/pvefw.lck";
+
+# todo: define more MACROS
+# imported/converted from: /usr/share/shorewall/macro.*
+my $pve_fw_macros = {
+    'Amanda' => [
+	{ action => 'PARAM', proto => 'udp', dport => '10080' },
+	{ action => 'PARAM', proto => 'tcp', dport => '10080' },
+    ],
+    'Auth' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '113' },
+    ],
+    'BGP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '179' },
+    ],
+    'BitTorrent' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '6881:6889' },
+	{ action => 'PARAM', proto => 'udp', dport => '6881' },
+    ],
+    'BitTorrent32' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '6881:6999' },
+	{ action => 'PARAM', proto => 'udp', dport => '6881' },
+    ],
+    'CVS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '2401' },
+    ],
+    'Citrix' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '1494' },
+	{ action => 'PARAM', proto => 'udp', dport => '1604' },
+	{ action => 'PARAM', proto => 'tcp', dport => '2598' },
+    ],
+    'DAAP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3689' },
+	{ action => 'PARAM', proto => 'udp', dport => '3689' },
+    ],
+    'DCC' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '6277' },
+    ],
+    'DHCPfwd' => [
+	{ action => 'PARAM', proto => 'udp', dport => '67:68', sport => '67:68' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '67:68', sport => '67:68' },
+    ],
+    'DNS' => [
+	{ action => 'PARAM', proto => 'udp', dport => '53' },
+	{ action => 'PARAM', proto => 'tcp', dport => '53' },
+    ],
+    'Distcc' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3632' },
+    ],
+    'Edonkey' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '4662' },
+	{ action => 'PARAM', proto => 'udp', dport => '4665' },
+    ],
+    'FTP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '21' },
+    ],
+    'Finger' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '79' },
+    ],
+    'GNUnet' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '2086' },
+	{ action => 'PARAM', proto => 'udp', dport => '2086' },
+	{ action => 'PARAM', proto => 'tcp', dport => '1080' },
+	{ action => 'PARAM', proto => 'udp', dport => '1080' },
+    ],
+    'GRE' => [
+	{ action => 'PARAM', proto => '47' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '47' },
+    ],
+    'Git' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '9418' },
+    ],
+    'Gnutella' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '6346' },
+	{ action => 'PARAM', proto => 'udp', dport => '6346' },
+    ],
+    'HKP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '11371' },
+    ],
+    'HTTP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '80' },
+    ],
+    'HTTPS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '443' },
+    ],
+    'ICPV2' => [
+	{ action => 'PARAM', proto => 'udp', dport => '3130' },
+    ],
+    'ICQ' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5190' },
+    ],
+    'IMAP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '143' },
+    ],
+    'IMAPS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '993' },
+    ],
+    'IPIP' => [
+	{ action => 'PARAM', proto => '94' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '94' },
+    ],
+    'IPP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '631' },
+    ],
+    'IPPbrd' => [
+	{ action => 'PARAM', proto => 'udp', dport => '631' },
+    ],
+    'IPPserver' => [
+	{ action => 'PARAM', source => 'SOURCE', dest => 'DEST', proto => 'tcp', dport => '631' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '631' },
+    ],
+    'IPsec' => [
+	{ action => 'PARAM', proto => 'udp', dport => '500', sport => '500' },
+	{ action => 'PARAM', proto => '50' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '500', sport => '500' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '50' },
+    ],
+    'IPsecah' => [
+	{ action => 'PARAM', proto => 'udp', dport => '500', sport => '500' },
+	{ action => 'PARAM', proto => '51' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '500', sport => '500' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '51' },
+    ],
+    'IPsecnat' => [
+	{ action => 'PARAM', proto => 'udp', dport => '500' },
+	{ action => 'PARAM', proto => 'udp', dport => '4500' },
+	{ action => 'PARAM', proto => '50' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '500' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '4500' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '50' },
+    ],
+    'IRC' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '6667' },
+    ],
+    'JabberPlain' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5222' },
+    ],
+    'JabberSecure' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5223' },
+    ],
+    'Jabberd' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5269' },
+    ],
+    'Jetdirect' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '9100' },
+    ],
+    'L2TP' => [
+	{ action => 'PARAM', proto => 'udp', dport => '1701' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '1701' },
+    ],
+    'LDAP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '389' },
+    ],
+    'LDAPS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '636' },
+    ],
+    'MSNP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '1863' },
+    ],
+    'MSSQL' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '1433' },
+    ],
+    'Mail' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '25' },
+	{ action => 'PARAM', proto => 'tcp', dport => '465' },
+	{ action => 'PARAM', proto => 'tcp', dport => '587' },
+    ],
+    'Munin' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '4949' },
+    ],
+    'MySQL' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3306' },
+    ],
+    'NNTP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '119' },
+    ],
+    'NNTPS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '563' },
+    ],
+    'NTP' => [
+	{ action => 'PARAM', proto => 'udp', dport => '123' },
+    ],
+    'NTPbi' => [
+	{ action => 'PARAM', proto => 'udp', dport => '123' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '123' },
+    ],
+    'NTPbrd' => [
+	{ action => 'PARAM', proto => 'udp', dport => '123' },
+	{ action => 'PARAM', proto => 'udp', dport => '1024:65535', sport => '123' },
+    ],
+    'OSPF' => [
+	{ action => 'PARAM', proto => '89' },
+    ],
+    'OpenVPN' => [
+	{ action => 'PARAM', proto => 'udp', dport => '1194' },
+    ],
+    'PCA' => [
+	{ action => 'PARAM', proto => 'udp', dport => '5632' },
+	{ action => 'PARAM', proto => 'tcp', dport => '5631' },
+    ],
+    'POP3' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '110' },
+    ],
+    'POP3S' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '995' },
+    ],
+    'PPtP' => [
+	{ action => 'PARAM', proto => '47' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => '47' },
+	{ action => 'PARAM', proto => 'tcp', dport => '1723' },
+    ],
+    'Ping' => [
+	{ action => 'PARAM', proto => 'icmp', dport => '8' },
+    ],
+    'PostgreSQL' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5432' },
+    ],
+    'Printer' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '515' },
+    ],
+    'RDP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3389' },
+    ],
+    'RIPbi' => [
+	{ action => 'PARAM', proto => 'udp', dport => '520' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '520' },
+    ],
+    'RNDC' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '953' },
+    ],
+    'Razor' => [
+	{ action => 'ACCEPT', proto => 'tcp', dport => '2703' },
+    ],
+    'Rdate' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '37' },
+    ],
+    'Rsync' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '873' },
+    ],
+    'SANE' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '6566' },
+    ],
+    'SMB' => [
+	{ action => 'PARAM', proto => 'udp', dport => '135,445' },
+	{ action => 'PARAM', proto => 'udp', dport => '137:139' },
+	{ action => 'PARAM', proto => 'udp', dport => '1024:65535', sport => '137' },
+	{ action => 'PARAM', proto => 'tcp', dport => '135,139,445' },
+    ],
+    'SMBBI' => [
+	{ action => 'PARAM', proto => 'udp', dport => '135,445' },
+	{ action => 'PARAM', proto => 'udp', dport => '137:139' },
+	{ action => 'PARAM', proto => 'udp', dport => '1024:65535', sport => '137' },
+	{ action => 'PARAM', proto => 'tcp', dport => '135,139,445' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '135,445' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '137:139' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'udp', dport => '1024:65535', sport => '137' },
+	{ action => 'PARAM', source => 'DEST', dest => 'SOURCE', proto => 'tcp', dport => '135,139,445' },
+    ],
+    'SMBswat' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '901' },
+    ],
+    'SMTP' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '25' },
+    ],
+    'SMTPS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '465' },
+    ],
+    'SNMP' => [
+	{ action => 'PARAM', proto => 'udp', dport => '161:162' },
+	{ action => 'PARAM', proto => 'tcp', dport => '161' },
+    ],
+    'SPAMD' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '783' },
+    ],
+    'SSH' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '22' },
+    ],
+    'SVN' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3690' },
+    ],
+    'SixXS' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3874' },
+	{ action => 'PARAM', proto => 'udp', dport => '3740' },
+	{ action => 'PARAM', proto => '41' },
+	{ action => 'PARAM', proto => 'udp', dport => '5072,8374' },
+    ],
+    'Squid' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '3128' },
+    ],
+    'Submission' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '587' },
+    ],
+    'Syslog' => [
+	{ action => 'PARAM', proto => 'udp', dport => '514' },
+	{ action => 'PARAM', proto => 'tcp', dport => '514' },
+    ],
+    'TFTP' => [
+	{ action => 'PARAM', proto => 'udp', dport => '69' },
+    ],
+    'Telnet' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '23' },
+    ],
+    'Telnets' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '992' },
+    ],
+    'Time' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '37' },
+    ],
+    'Trcrt' => [
+	{ action => 'PARAM', proto => 'udp', dport => '33434:33524' },
+	{ action => 'PARAM', proto => 'icmp', dport => '8' },
+    ],
+    'VNC' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5900:5909' },
+    ],
+    'VNCL' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '5500' },
+    ],
+    'Web' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '80' },
+	{ action => 'PARAM', proto => 'tcp', dport => '443' },
+    ],
+    'Webcache' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '8080' },
+    ],
+    'Webmin' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '10000' },
+    ],
+    'Whois' => [
+	{ action => 'PARAM', proto => 'tcp', dport => '43' },
+    ],
+};
 
-    return $macros if $macros;
+my $pve_fw_parsed_macros;
+my $pve_fw_preferred_macro_names = {};
 
-    foreach my $path (</usr/share/shorewall/macro.*>) {
-	if ($path =~ m|/macro\.(\S+)$|) {
-	    $macros->{$1} = 1;
-	}
+sub get_firewall_macros {
+
+    return $pve_fw_parsed_macros if $pve_fw_parsed_macros;
+    
+    $pve_fw_parsed_macros = {};
+
+    foreach my $k (keys %$pve_fw_macros) {
+	my $name = lc($k);
+
+	my $macro =  $pve_fw_macros->{$k};
+	$pve_fw_preferred_macro_names->{$name} = $k;
+	$pve_fw_parsed_macros->{$name} = $macro;
     }
-    return $macros;
+
+    return $pve_fw_parsed_macros;
 }
 
 my $etc_services;
@@ -47,6 +389,7 @@ sub get_etc_services {
 
 	if ($line =~ m!^(\S+)\s+(\S+)/(tcp|udp).*$!) {
 	    $services->{byid}->{$2}->{name} = $1;
+	    $services->{byid}->{$2}->{port} = $2;
 	    $services->{byid}->{$2}->{$3} = 1;
 	    $services->{byname}->{$1} = $services->{byid}->{$2};
 	}
@@ -56,6 +399,7 @@ sub get_etc_services {
 
     $etc_services = $services;    
     
+
     return $etc_services;
 }
 
@@ -95,430 +439,649 @@ sub get_etc_protocols {
 sub parse_address_list {
     my ($str) = @_;
 
+    my $nbaor = 0;
     foreach my $aor (split(/,/, $str)) {
 	if (!Net::IP->new($aor)) {
 	    my $err = Net::IP::Error();
 	    die "invalid IP address: $err\n";
+	}else{
+	    $nbaor++;
 	}
     }
+    return $nbaor;
 }
 
 sub parse_port_name_number_or_range {
     my ($str) = @_;
 
     my $services = PVE::Firewall::get_etc_services();
-
+    my $nbports = 0;
     foreach my $item (split(/,/, $str)) {
+	my $portlist = "";
+	my $oldpon = undef;
 	foreach my $pon (split(':', $item, 2)) {
-	    next if $pon =~ m/^\d+$/ && $pon > 0 && $pon < 65536;
-	    next if defined($services->{byname}->{$pon});
-	    die "invalid port '$pon'\n";
+	    $pon = $services->{byname}->{$pon}->{port} if $services->{byname}->{$pon}->{port};
+	    if ($pon =~ m/^\d+$/){
+		die "invalid port '$pon'\n" if $pon < 0 && $pon > 65535;
+		die "port '$pon' must be bigger than port '$oldpon' \n" if $oldpon && ($pon < $oldpon);
+		$oldpon = $pon;
+	    }else{
+		die "invalid port $services->{byname}->{$pon}\n" if !$services->{byname}->{$pon};
+	    }
+	    $nbports++;
 	}
     }
 
+    return ($nbports);
 }
 
-my $rule_format = "%-15s %-30s %-30s %-15s %-15s %-15s\n";
+my $bridge_firewall_enabled = 0;
 
-my $generate_input_rule = sub {
-    my ($zoneinfo, $rule, $net, $netid) = @_;
+sub enable_bridge_firewall {
 
-    my $zone = $net->{zone} || die "internal error";
-    my $zid = $zoneinfo->{$zone}->{zoneref} || die "internal error";
-    my $tap = $net->{tap} || die "internal error";
+    return if $bridge_firewall_enabled; # only once
 
-    my $dest = "$zid:$tap";
+    system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-iptables");
+    system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-ip6tables");
 
-    if ($rule->{dest}) {
-	$dest .= ":$rule->{dest}";
-    }
+    $bridge_firewall_enabled = 1;
+}
 
-    my $action = $rule->{service} ? 
-	"$rule->{service}($rule->{action})" : $rule->{action};
+my $rule_format = "%-15s %-30s %-30s %-15s %-15s %-15s\n";
 
-    my $sources = [];
+sub iptables {
+    my ($cmd) = @_;
 
-    if (!$rule->{source}) {
-	push @$sources, 'all'; 
-    } elsif ($zoneinfo->{$zone}->{type} eq 'bport') {
-	my $bridge_zone = $zoneinfo->{$zone}->{bridge_zone} || die "internal error";
-	my $zoneref = $zoneinfo->{$bridge_zone}->{zoneref} || die "internal error";
+    run_command("/sbin/iptables $cmd", outfunc => sub {}, errfunc => sub {});
+}
 
-	# using 'all' does not work, so we create one rule for
-	# each related zone on the same bridge
-	push @$sources, "${zoneref}:$rule->{source}";
-	foreach my $z (keys %$zoneinfo) {
-	    next if $z eq $zone;
-	    next if !$zoneinfo->{$z}->{bridge_zone};
-	    next if $zoneinfo->{$z}->{bridge_zone} ne $bridge_zone;
-	    $zoneref = $zoneinfo->{$z}->{zoneref} || die "internal error";
-	    push @$sources, "${zoneref}:$rule->{source}";
-	}
-    } else {
-	push @$sources, "all:$rule->{source}";
-    }
+sub iptables_restore_cmdlist {
+    my ($cmdlist) = @_;
 
-    my $out = '';
+    run_command("/sbin/iptables-restore -n", input => $cmdlist);
+}
 
-    foreach my $source (@$sources) {
-	$out .= sprintf($rule_format, $action, $source, $dest, $rule->{proto} || '-', 
-			$rule->{dport} || '-', $rule->{sport} || '-');
-    }
+sub iptables_get_chains {
 
-    return $out;
-};
+    my $res = {};
 
-my $generate_output_rule = sub {
-    my ($zoneinfo, $rule, $net, $netid) = @_;
+    # check what chains we want to track
+    my $is_pvefw_chain = sub {
+	my $name = shift;
 
-    my $zone = $net->{zone} || die "internal error";
-    my $zid = $zoneinfo->{$zone}->{zoneref} || die "internal error";
-    my $tap = $net->{tap} || die "internal error";
+	return 1 if $name =~ m/^PVEFW-\S+$/;
 
-    my $action = $rule->{service} ? 
-	"$rule->{service}($rule->{action})" : $rule->{action};
-    
-    my $dest;
+	return 1 if $name =~ m/^tap\d+i\d+-(:?IN|OUT)$/;
+	return 1 if $name =~ m/^vmbr\d+-(:?FW|IN|OUT)$/;
+	return 1 if $name =~ m/^GROUP-(:?[^\s\-]+)-(:?IN|OUT)$/;
 
-    if (!$rule->{dest}) {
-	$dest = 'all';
-    } else {
-	$dest = "all:$rule->{dest}";
-    }
+	return undef;
+    };
 
-    return sprintf($rule_format, $action, "$zid:$tap", $dest, 
-		   $rule->{proto} || '-', $rule->{dport} || '-', $rule->{sport} || '-');
-};
+    my $table = '';
 
-# we need complete VM configuration of all VMs (openvz/qemu)
-# in vmdata
+    my $parser = sub {
+	my $line = shift;
 
-my $compile_shorewall = sub {
-    my ($targetdir, $vmdata, $rules) = @_;
+	return if $line =~ m/^#/;
+	return if $line =~ m/^\s*$/;
 
-    # remove existing data ?
-    foreach my $file (qw(params zones rules interfaces  maclist  policy)) {
-	unlink "$targetdir/$file";
-    }
+	if ($line =~ m/^\*(\S+)$/) {
+	    $table = $1;
+	    return;
+	}
 
-    my $netinfo;
+	return if $table ne 'filter';
 
-    my $zoneinfo = {
-	fw => { type => 'firewall' },
+	if ($line =~ m/^:(\S+)\s/) {
+	    my $chain = $1;
+	    return if !&$is_pvefw_chain($chain);
+	    $res->{$chain} = "unknown";
+	} elsif ($line =~ m/^-A\s+(\S+)\s.*--comment\s+\"PVESIG:(\S+)\"/) {
+	    my ($chain, $sig) = ($1, $2);
+	    return if !&$is_pvefw_chain($chain);
+	    $res->{$chain} = $sig;
+	} else {
+	    # simply ignore the rest
+	    return;
+	}
     };
 
-    my $maclist = {};
+    run_command("/sbin/iptables-save", outfunc => $parser);
 
-    my $register_bridge;
+    return $res;
+}
 
-    $register_bridge = sub {
-	my ($bridge, $vlan) = @_;
+sub iptables_chain_exist {
+    my ($chain) = @_;
 
-	my $zone =  'z' . $bridge;
+    eval{
+	iptables("-n --list $chain");
+    };
+    return undef if $@;
+
+    return 1;
+}
+
+sub iptables_rule_exist {
+    my ($rule) = @_;
 
-	return $zone if $zoneinfo->{$zone};
+    eval{
+	iptables("-C $rule");
+    };
+    return undef if $@;
 
-	my $ext_zone = "z${bridge}ext";
+    return 1;
+}
 
-	$zoneinfo->{$zone} = {
-	    type => 'bridge',
-	    bridge => $bridge,
-	    bridge_ext_zone => $ext_zone,
-	};
+sub ruleset_generate_rule {
+    my ($ruleset, $chain, $rule, $goto) = @_;
 
-	# physical input devices
-	my $dir = "/sys/class/net/$bridge/brif";
-	my $physical = {};
-	PVE::Tools::dir_glob_foreach($dir, '((eth|bond).+)', sub {
-	    my ($slave) = @_;
-	    $physical->{$slave} = 1;
-	});
+    my $cmd = '';
 
-	$zoneinfo->{$ext_zone} = {
-	    type => 'bport',
-	    bridge_zone => $zone,
-	    ifaces => $physical,
-	};
+    $cmd .= " -m iprange --src-range" if $rule->{nbsource} && $rule->{nbsource} > 1;
+    $cmd .= " -s $rule->{source}" if $rule->{source};
+    $cmd .= " -m iprange --dst-range" if $rule->{nbdest} && $rule->{nbdest} > 1;
+    $cmd .= " -d $rule->{dest}" if $rule->{dest};
+    $cmd .= " -p $rule->{proto}" if $rule->{proto};
+    $cmd .= "  --match multiport" if $rule->{nbdport} && $rule->{nbdport} > 1;
+    $cmd .= " --dport $rule->{dport}" if $rule->{dport};
+    $cmd .= "  --match multiport" if $rule->{nbsport} && $rule->{nbsport} > 1;
+    $cmd .= " --sport $rule->{sport}" if $rule->{sport};
 
-	return &$register_bridge("${bridge}v${vlan}") if defined($vlan);
-	
-	return $zone;
+    if (my $action = $rule->{action}) {
+	$goto = 1 if !defined($goto) && $action eq 'PVEFW-SET-ACCEPT-MARK';
+	$cmd .= $goto ? " -g $action" : " -j $action";
     };
 
-    my $register_bridge_port = sub {
-	my ($bridge, $vlan, $vmzone, $tap) = @_;
+    ruleset_addrule($ruleset, $chain, $cmd) if $cmd;
+}
 
-	my $bridge_zone = &$register_bridge($bridge, $vlan);
-	my $zone = $bridge_zone . $vmzone;
+sub ruleset_create_chain {
+    my ($ruleset, $chain) = @_;
 
-	if (!$zoneinfo->{$zone}) {
-	    $zoneinfo->{$zone} = {
-		type => 'bport',
-		bridge_zone => $bridge_zone,
-		ifaces => {},
-	    };
-	}
+    die "Invalid chain name '$chain' (28 char max)\n" if length($chain) > 28;
 
-	$zoneinfo->{$zone}->{ifaces}->{$tap} = 1;
-	
-	return $zone;
-    };
+    die "chain '$chain' already exists\n" if $ruleset->{$chain};
 
-    foreach my $vmid (keys %{$vmdata->{qemu}}) {
-	$netinfo->{$vmid} = {};
-	my $conf = $vmdata->{qemu}->{$vmid};
-	foreach my $opt (keys %$conf) {
-	    next if $opt !~ m/^net(\d+)$/;
-	    my $netnum = $1;
-	    my $net = PVE::QemuServer::parse_net($conf->{$opt});
-	    next if !$net;
-	    die "implement me" if !$net->{bridge};
+    $ruleset->{$chain} = [];
+}
 
-	    my $vmzone = $conf->{zone} || "vm$vmid";
-	    $net->{tap} = "tap${vmid}i${netnum}";
-	    $maclist->{$net->{tap}} = $net->{macaddr} || die "internal error";
-	    $net->{zone} = &$register_bridge_port($net->{bridge}, $net->{tag}, $vmzone, $net->{tap});
-	    $netinfo->{$vmid}->{$opt} = $net;
-	}
-    }
+sub ruleset_chain_exist {
+    my ($ruleset, $chain) = @_;
 
-    #print Dumper($netinfo);
+    return $ruleset->{$chain} ? 1 : undef;
+}
 
-    # NOTE: zone names have length limit, so we need to
-    # translate them into shorter names 
+sub ruleset_addrule {
+   my ($ruleset, $chain, $rule) = @_;
 
-    my $zoneid = 0;
-    my $zonemap = { fw => 'fw' };
+   die "no such chain '$chain'\n" if !$ruleset->{$chain};
 
-    my $lookup_zonename = sub {
-	my ($zone) = @_;
+   push @{$ruleset->{$chain}}, "-A $chain $rule";
+}
 
-	return $zonemap->{$zone} if defined($zonemap->{$zone});
-	$zonemap->{$zone} = 'z' . $zoneid++;
+sub ruleset_insertrule {
+   my ($ruleset, $chain, $rule) = @_;
 
-	return $zonemap->{$zone};
-    };
+   die "no such chain '$chain'\n" if !$ruleset->{$chain};
 
-    foreach my $z (sort keys %$zoneinfo) {
-	$zoneinfo->{$z}->{id} = &$lookup_zonename($z);
-	$zoneinfo->{$z}->{zonevar} = uc($z);
- 	$zoneinfo->{$z}->{zoneref} = '$' . $zoneinfo->{$z}->{zonevar};
-    }
+   unshift @{$ruleset->{$chain}}, "-A $chain $rule";
+}
 
-    my $out;
+sub generate_bridge_chains {
+    my ($ruleset, $bridge) = @_;
 
-    # dump params file
-    $out = "# PVE zones\n";
-    foreach my $z (sort keys %$zoneinfo) {
-	$out .= "$zoneinfo->{$z}->{zonevar}=$zoneinfo->{$z}->{id}\n";
+    if (!ruleset_chain_exist($ruleset, "PVEFW-FORWARD")){
+	ruleset_create_chain($ruleset, "PVEFW-FORWARD");
+	ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
     }
-    PVE::Tools::file_set_contents("$targetdir/params", $out);
 
-    # dump zone file
+    if (!ruleset_chain_exist($ruleset, "$bridge-FW")) {
+	ruleset_create_chain($ruleset, "$bridge-FW");
+	ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -m physdev --physdev-is-bridged -j $bridge-FW");
+	ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -m physdev --physdev-is-bridged -j $bridge-FW");
+	ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -j DROP");  # disable interbridge routing
+	ruleset_addrule($ruleset, "PVEFW-FORWARD", "-i $bridge -j DROP"); # disable interbridge routing
+    }
 
-    my $format = "%-30s %-10s %-15s\n";
-    $out = sprintf($format, '#ZONE', 'TYPE', 'OPTIONS');
-    
-    foreach my $z (sort keys %$zoneinfo) {
-	my $zid = $zoneinfo->{$z}->{zoneref};
-	if ($zoneinfo->{$z}->{type} eq 'firewall') {
-	    $out .= sprintf($format, $zid, $zoneinfo->{$z}->{type}, '');
-	} elsif ($zoneinfo->{$z}->{type} eq 'bridge') {
-	    $out .= sprintf($format, $zid, 'ipv4', '');
-	} elsif ($zoneinfo->{$z}->{type} eq 'bport') {
-	    my $bridge_zone = $zoneinfo->{$z}->{bridge_zone} || die "internal error";
-	    my $bzid = $zoneinfo->{$bridge_zone}->{zoneref} || die "internal error";
-	    $out .= sprintf($format, "$zid:$bzid", 'bport', '');
-	} else {
-	    die "internal error";
-	}
+    if (!ruleset_chain_exist($ruleset, "$bridge-OUT")) {
+	ruleset_create_chain($ruleset, "$bridge-OUT");
+	ruleset_addrule($ruleset, "$bridge-FW", "-m physdev --physdev-is-bridged --physdev-is-in -j $bridge-OUT");
     }
 
-    $out .= sprintf("#LAST LINE - ADD YOUR ENTRIES ABOVE THIS ONE - DO NOT REMOVE\n");
+    if (!ruleset_chain_exist($ruleset, "$bridge-IN")) {
+	ruleset_create_chain($ruleset, "$bridge-IN");
+	ruleset_addrule($ruleset, "$bridge-FW", "-m physdev --physdev-is-bridged --physdev-is-out -j $bridge-IN");
+    }
+}
 
-    PVE::Tools::file_set_contents("$targetdir/zones", $out);
+sub generate_tap_rules_direction {
+    my ($ruleset, $group_rules, $iface, $netid, $macaddr, $vmfw_conf, $bridge, $direction) = @_;
 
-    # dump interfaces
+    my $rules = $vmfw_conf->{lc($direction)};
+    my $options = $vmfw_conf->{options};
 
-    $format = "%-25s %-20s %-10s %-15s\n";
-    $out = sprintf($format, '#ZONE', 'INTERFACE', 'BROADCAST', 'OPTIONS');
+    my $tapchain = "$iface-$direction";
 
-    my $maclist_format = "%-15s %-15s %-15s\n";
-    my $macs = sprintf($maclist_format, '#DISPOSITION', 'INTERFACE', 'MACZONE');
+    ruleset_create_chain($ruleset, $tapchain);
 
-    foreach my $z (sort keys %$zoneinfo) {
-	my $zid = $zoneinfo->{$z}->{zoneref};
-	if ($zoneinfo->{$z}->{type} eq 'firewall') {
-	    # do nothing;
-	} elsif ($zoneinfo->{$z}->{type} eq 'bridge') {
-	    my $bridge = $zoneinfo->{$z}->{bridge} || die "internal error";
-	    $out .= sprintf($format, $zid, $bridge, 'detect', 'bridge,optional');
-	} elsif ($zoneinfo->{$z}->{type} eq 'bport') {
-	    my $ifaces = $zoneinfo->{$z}->{ifaces};
-	    foreach my $iface (sort keys %$ifaces) {
-		my $bridge_zone = $zoneinfo->{$z}->{bridge_zone} || die "internal error";
-		my $bridge = $zoneinfo->{$bridge_zone}->{bridge} || die "internal error";
-		my $iftxt = "$bridge:$iface";
+    ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate INVALID -j DROP");
+    ruleset_addrule($ruleset, $tapchain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
 
-		if ($maclist->{$iface}) {
-		    $out .= sprintf($format, $zid, $iftxt, '-', 'maclist');
-		    $macs .= sprintf($maclist_format, 'ACCEPT', $iface, $maclist->{$iface});
-		} else {
-		    $out .= sprintf($format, $zid, $iftxt, '-', '');
+    if ($direction eq 'OUT' && defined($macaddr)) {
+	ruleset_addrule($ruleset, $tapchain, "-m mac ! --mac-source $macaddr -j DROP");
+    }
+
+    if ($rules) {
+        foreach my $rule (@$rules) {
+	    next if $rule->{iface} && $rule->{iface} ne $netid;
+	    # we go to $bridge-IN if accept in out rules
+	    if($rule->{action}  =~ m/^(GROUP-(\S+))$/){
+		$rule->{action} .= "-$direction";
+		# generate empty group rule if don't exist
+		if(!ruleset_chain_exist($ruleset, $rule->{action})){
+		    generate_group_rules($ruleset, $group_rules, $2);
 		}
+		ruleset_generate_rule($ruleset, $tapchain, $rule);
+		ruleset_addrule($ruleset, $tapchain, "-m mark --mark 1 -j RETURN")
+		    if $direction eq 'OUT';
+	    } else {
+		$rule->{action} = "RETURN" if $rule->{action} eq 'ACCEPT' && $direction eq 'OUT';
+		ruleset_generate_rule($ruleset, $tapchain, $rule);
 	    }
+	}
+    }
+
+    # implement policy
+    my $policy;
+
+    if ($direction eq 'OUT') {
+	$policy = $options->{'policy-out'} || 'ACCEPT'; # allow everything by default
+    } else {
+	$policy = $options->{'policy-in'} || 'DROP'; # allow everything by default
+    }
+
+    if ($policy eq 'ACCEPT') {
+	if ($direction eq 'OUT') {
+	    ruleset_addrule($ruleset, $tapchain, "-j RETURN");
 	} else {
-	    die "internal error";
+	    ruleset_addrule($ruleset, $tapchain, "-j ACCEPT");
 	}
+    } elsif ($policy eq 'DROP') {
+	ruleset_addrule($ruleset, $tapchain, "-j LOG --log-prefix \"$tapchain-dropped: \" --log-level 4");
+	ruleset_addrule($ruleset, $tapchain, "-j DROP");
+    } elsif ($policy eq 'REJECT') {
+	ruleset_addrule($ruleset, $tapchain, "-j LOG --log-prefix \"$tapchain-reject: \" --log-level 4");
+	ruleset_addrule($ruleset, $tapchain, "-j REJECT");
+    } else {
+	# should not happen
+	die "internal error: unknown policy '$policy'";
     }
 
-    $out .= sprintf("#LAST LINE - ADD YOUR ENTRIES ABOVE THIS ONE - DO NOT REMOVE\n");
+    # plug the tap chain to bridge chain
+    my $physdevdirection = $direction eq 'IN' ? "out" : "in";
+    my $rule = "-m physdev --physdev-$physdevdirection $iface --physdev-is-bridged -j $tapchain";
+    ruleset_insertrule($ruleset, "$bridge-$direction", $rule);
+
+    if ($direction eq 'OUT'){
+	# add tap->host rules
+	my $rule = "-m physdev --physdev-$physdevdirection $iface -j $tapchain";
+	ruleset_addrule($ruleset, "PVEFW-INPUT", $rule);
+    }
+}
 
-    PVE::Tools::file_set_contents("$targetdir/interfaces", $out);
+sub enablehostfw {
+    my ($ruleset, $rules, $group_rules) = @_;
 
-    # dump maclist
-    PVE::Tools::file_set_contents("$targetdir/maclist", $macs);
+    # fixme: allow security groups
 
-    # dump policy
+    # host inbound firewall
+    my $chain = "PVEFW-HOST-IN";
+    ruleset_create_chain($ruleset, $chain);
 
-    $format = "%-15s %-15s %-15s %s\n";
-    $out = sprintf($format, '#SOURCE', 'DEST', 'POLICY', 'LOG');
-    $out .= sprintf($format, 'fw', 'all', 'ACCEPT', '');
+    ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate INVALID -j DROP");
+    ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-i lo -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW -m multiport --dports 5404,5405 -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT");  #corosync
 
-    # we need to disable intra-zone traffic on bridges. Else traffic
-    # from untracked interfaces simply pass the firewall
-    foreach my $z (sort keys %$zoneinfo) {
-	my $zid = $zoneinfo->{$z}->{zoneref};
-	if ($zoneinfo->{$z}->{type} eq 'bridge') {
-	    $out .= sprintf($format, $zid, $zid, 'REJECT', 'info');
-	}
+    if ($rules->{in}) {
+        foreach my $rule (@{$rules->{in}}) {
+            # we use RETURN because we need to check also tap rules
+            $rule->{action} = 'RETURN' if $rule->{action} eq 'ACCEPT';
+            ruleset_generate_rule($ruleset, $chain, $rule);
+        }
     }
-    $out .= sprintf($format, 'all', 'all', 'REJECT', 'info');
 
-    PVE::Tools::file_set_contents("$targetdir/policy", $out);
+    ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-IN dropped: \" --log-level 4");
+    ruleset_addrule($ruleset, $chain, "-j DROP");
+
+    # host outbound firewall
+    $chain = "PVEFW-HOST-OUT";
+    ruleset_create_chain($ruleset, $chain);
+
+    ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate INVALID -j DROP");
+    ruleset_addrule($ruleset, $chain, "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-o lo -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-m addrtype --dst-type MULTICAST -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-p udp -m conntrack --ctstate NEW -m multiport --dports 5404,5405 -j ACCEPT");
+    ruleset_addrule($ruleset, $chain, "-p udp -m udp --dport 9000 -j ACCEPT"); #corosync
+
+    if ($rules->{out}) {
+        foreach my $rule (@{$rules->{out}}) {
+            # we use RETURN because we need to check also tap rules
+            $rule->{action} = 'RETURN' if $rule->{action} eq 'ACCEPT';
+            ruleset_generate_rule($ruleset, $chain, $rule);
+        }
+    }
 
-    # dump rules
-    $out = '';
+    ruleset_addrule($ruleset, $chain, "-j LOG --log-prefix \"kvmhost-OUT dropped: \" --log-level 4");
+    ruleset_addrule($ruleset, $chain, "-j DROP");
+    
+    ruleset_addrule($ruleset, "PVEFW-OUTPUT", "-j PVEFW-HOST-OUT");
+    ruleset_addrule($ruleset, "PVEFW-INPUT", "-j PVEFW-HOST-IN");
+}
 
-    $out = sprintf($rule_format, '#ACTION', 'SOURCE', 'DEST', 'PROTO', 'DPORT', 'SPORT');
-    foreach my $vmid (sort keys %$rules) {
-	my $inrules = $rules->{$vmid}->{in};
-	my $outrules = $rules->{$vmid}->{out};
+sub generate_group_rules {
+    my ($ruleset, $group_rules, $group) = @_;
 
-	if (scalar(@$inrules)) {
-	    $out .= "# IN to VM $vmid\n";
-	    foreach my $rule (@$inrules) {
-		foreach my $netid (keys %{$netinfo->{$vmid}}) {
-		    my $net = $netinfo->{$vmid}->{$netid};
-		    next if $rule->{iface} && $rule->{iface} ne $netid;
-		    $out .= &$generate_input_rule($zoneinfo, $rule, $net, $netid);
-		}
-	    }
-	}
+    my $rules = $group_rules->{$group};
+
+    die "no such security group '$group'\n" if !$rules;
+    
+    my $chain = "GROUP-${group}-IN";
+
+    ruleset_create_chain($ruleset, $chain);
+
+    if ($rules->{in}) {
+        foreach my $rule (@{$rules->{in}}) {
+ 	    ruleset_generate_rule($ruleset, $chain, $rule);
+        }
+    }
+
+    $chain = "GROUP-${group}-OUT";
+
+    ruleset_create_chain($ruleset, $chain);
+    ruleset_addrule($ruleset, $chain, "-j MARK --set-mark 0"); # clear mark
+
+    if ($rules->{out}) {
+        foreach my $rule (@{$rules->{out}}) {
+            # we go the PVEFW-SET-ACCEPT-MARK Instead of ACCEPT) because we need to 
+	    # check also other tap rules (and group rules can be set on any bridge, 
+	    # so we can't go to VMBRXX-IN)
+            $rule->{action} = 'PVEFW-SET-ACCEPT-MARK' if $rule->{action} eq 'ACCEPT';
+            ruleset_generate_rule($ruleset, $chain, $rule);
+        }
+    }
+}
+
+my $MAX_NETS = 32;
+my $valid_netdev_names = {};
+for (my $i = 0; $i < $MAX_NETS; $i++)  {
+    $valid_netdev_names->{"net$i"} = 1;
+}
+
+sub parse_fw_rule {
+    my ($line, $need_iface, $allow_groups) = @_;
+
+    my $macros = get_firewall_macros();
+    my $protocols = get_etc_protocols();
+
+    my ($action, $iface, $source, $dest, $proto, $dport, $sport);
 
-	if (scalar(@$outrules)) {
-	    $out .= "# OUT from VM $vmid\n";
-	    foreach my $rule (@$outrules) {
-		foreach my $netid (keys %{$netinfo->{$vmid}}) {
-		    my $net = $netinfo->{$vmid}->{$netid};
-		    next if $rule->{iface} && $rule->{iface} ne $netid;
-		    $out .= &$generate_output_rule($zoneinfo, $rule, $net, $netid);
+    $line =~ s/#.*$//;
+
+    my @data = split(/\s+/, $line);
+    my $expected_elements = $need_iface ? 7 : 6;
+
+    die "wrong number of rule elements\n" if scalar(@data) > $expected_elements;
+
+    if ($need_iface) {
+	($action, $iface, $source, $dest, $proto, $dport, $sport) = @data
+    } else {
+	($action, $source, $dest, $proto, $dport, $sport) =  @data;
+    }
+
+    die "incomplete rule\n" if !$action;
+
+    my $macro;
+    my $macro_name;
+
+    if ($action =~ m/^(ACCEPT|DROP|REJECT)$/) {
+	# OK
+    } elsif ($allow_groups && $action =~ m/^GROUP-(:?\S+)$/) {
+	# OK
+    } elsif ($action =~ m/^(\S+)\((ACCEPT|DROP|REJECT)\)$/) {
+	($macro_name, $action) = ($1, $2);
+	my $lc_macro_name = lc($macro_name);
+	my $preferred_name = $pve_fw_preferred_macro_names->{$lc_macro_name};
+	$macro_name = $preferred_name if $preferred_name;
+	$macro = $macros->{$lc_macro_name};
+	die "unknown macro '$macro_name'\n" if !$macro;
+    } else {
+	die "unknown action '$action'\n";
+    }
+
+    if ($need_iface) {
+	$iface = undef if $iface && $iface eq '-';
+	die "unknown interface '$iface'\n" 
+	    if defined($iface) && !$valid_netdev_names->{$iface};
+    }
+
+    $proto = undef if $proto && $proto eq '-';
+    die "unknown protokol '$proto'\n" if $proto && 
+	!(defined($protocols->{byname}->{$proto}) ||
+	  defined($protocols->{byid}->{$proto}));
+
+    $source = undef if $source && $source eq '-';
+    $dest = undef if $dest && $dest eq '-';
+
+    $dport = undef if $dport && $dport eq '-';
+    $sport = undef if $sport && $sport eq '-';
+
+    my $nbsource = undef;
+    my $nbdest = undef;
+
+    $nbsource = parse_address_list($source) if $source;
+    $nbdest = parse_address_list($dest) if $dest;
+ 
+    my $rules = [];
+
+    my $param = {
+	action => $action,
+	iface => $iface,
+	source => $source,
+	dest => $dest,
+	nbsource => $nbsource,
+	nbdest => $nbdest,
+	proto => $proto,
+	dport => $dport,
+	sport => $sport,
+    };
+
+    if ($macro) {
+	foreach my $templ (@$macro) {
+	    my $rule = {};
+	    foreach my $k (keys %$templ) {
+		my $v = $templ->{$k};
+		if ($v eq 'PARAM') {
+		    $v = $param->{$k};
+		} elsif ($v eq 'DEST') {
+		    $v = $param->{dest};
+		} elsif ($v eq 'SOURCE') {
+		    $v = $param->{source};
 		}
+
+		die "missing parameter '$k' in macro '$macro_name'\n" if !defined($v);
+		$rule->{$k} = $v;
 	    }
+	    push @$rules, $rule;
 	}
+    } else {
+	push @$rules, $param;
     }
 
-    PVE::Tools::file_set_contents("$targetdir/rules", $out);
-};
+    foreach my $rule (@$rules) {
+	$rule->{nbdport} = parse_port_name_number_or_range($rule->{dport}) 
+	    if defined($rule->{dport});
+	$rule->{nbsport} = parse_port_name_number_or_range($rule->{sport}) 
+	    if defined($rule->{sport});
+    }
+
+    return $rules;
+}
+
+sub parse_fw_option {
+    my ($line) = @_;
 
+    my ($opt, $value);
+
+    if ($line =~ m/^enable:\s*(0|1)\s*$/i) {
+	$opt = 'enable';
+	$value = int($1);
+    } elsif ($line =~ m/^(policy-(in|out)):\s*(ACCEPT|DROP|REJECT)\s*$/i) {
+	$opt = lc($1);
+	$value = uc($3);
+     } else {
+	chomp $line;
+	die "can't parse option '$line'\n"
+    }
 
-sub parse_fw_rules {
+    return ($opt, $value);
+}
+
+sub parse_vm_fw_rules {
     my ($filename, $fh) = @_;
 
-    my $section;
+    my $res = { in => [], out => [], options => {}};
 
-    my $res = { in => [], out => [] };
+    my $section;
 
-    my $macros = get_shorewall_macros();
-    my $protocols = get_etc_protocols();
-    
     while (defined(my $line = <$fh>)) {
 	next if $line =~ m/^#/;
 	next if $line =~ m/^\s*$/;
 
-	if ($line =~ m/^\[(in|out)\]\s*$/i) {
+	my $linenr = $fh->input_line_number();
+	my $prefix = "$filename (line $linenr)";
+
+	if ($line =~ m/^\[(\S+)\]\s*$/i) {
 	    $section = lc($1);
+	    warn "$prefix: ignore unknown section '$section'\n" if !$res->{$section};
+	    next;
+	}
+	if (!$section) {
+	    warn "$prefix: skip line - no section";
 	    next;
 	}
-	next if !$section;
 
-	my ($action, $iface, $source, $dest, $proto, $dport, $sport) =
-	    split(/\s+/, $line);
+	next if !$res->{$section}; # skip undefined section
 
-	if (!$action) {
-	    warn "skip incomplete line\n";
+	if ($section eq 'options') {
+	    eval { 
+		my ($opt, $value) = parse_fw_option($line); 
+		$res->{options}->{$opt} = $value;
+	    };
+	    warn "$prefix: $@" if $@;
 	    next;
 	}
 
-	my $service;
-	if ($action =~ m/^(ACCEPT|DROP|REJECT)$/) {
-	    # OK
-	} elsif ($action =~ m/^(\S+)\((ACCEPT|DROP|REJECT)\)$/) {
-	    ($service, $action) = ($1, $2);
-	    if (!$macros->{$service}) {
-		warn "unknown service '$service'\n";
-		next;
-	    }
-	} else {
-	    warn "unknown action '$action'\n";
+	my $rules;
+	eval { $rules = parse_fw_rule($line, 1, 1); };
+	if (my $err = $@) {
+	    warn "$prefix: $err";
 	    next;
 	}
 
-	$iface = undef if $iface && $iface eq '-';
-	if ($iface && $iface !~ m/^(net0|net1|net2|net3|net4|net5)$/) {
-	    warn "unknown interface '$iface'\n";
+	push @{$res->{$section}}, @$rules;
+    }
+
+    return $res;
+}
+
+sub parse_host_fw_rules {
+    my ($filename, $fh) = @_;
+
+    my $res = { in => [], out => [] };
+
+    my $section;
+
+    while (defined(my $line = <$fh>)) {
+	next if $line =~ m/^#/;
+	next if $line =~ m/^\s*$/;
+
+	my $linenr = $fh->input_line_number();
+	my $prefix = "$filename (line $linenr)";
+
+	if ($line =~ m/^\[(in|out)\]\s*$/i) {
+	    $section = lc($1);
+	    next;
+	}
+	if (!$section) {
+	    warn "$prefix: skip line - no section";
 	    next;
 	}
 
-	$proto = undef if $proto && $proto eq '-';
-	if ($proto && !(defined($protocols->{byname}->{$proto}) ||
-			defined($protocols->{byid}->{$proto}))) {
-	    warn "unknown protokol '$proto'\n";
+	my $rules;
+	eval { $rules = parse_fw_rule($line, 1, 1); };
+	if (my $err = $@) {
+	    warn "$prefix: $err";
 	    next;
 	}
 
-	$source = undef if $source && $source eq '-';
-	$dest = undef if $dest && $dest eq '-';
+	push @{$res->{$section}}, @$rules;
+    }
 
-	$dport = undef if $dport && $dport eq '-';
-	$sport = undef if $sport && $sport eq '-';
+    return $res;
+}
 
-	eval {
-	    parse_address_list($source) if $source;
-	    parse_address_list($dest) if $dest;
-	    parse_port_name_number_or_range($dport) if $dport;
-	    parse_port_name_number_or_range($sport) if $sport;
-	};
-	if (my $err = $@) {
-	    warn $err;
+sub parse_group_fw_rules {
+    my ($filename, $fh) = @_;
+
+    my $section;
+    my $group;
+
+    my $res = { in => [], out => [] };
+   
+    while (defined(my $line = <$fh>)) {
+	next if $line =~ m/^#/;
+	next if $line =~ m/^\s*$/;
+
+	my $linenr = $fh->input_line_number();
+	my $prefix = "$filename (line $linenr)";
+
+	if ($line =~ m/^\[(in|out):(\S+)\]\s*$/i) {
+	    $section = lc($1);
+	    $group = lc($2);
+	    next;
+	}
+	if (!$section || !$group) {
+	    warn "$prefix: skip line - no section";
 	    next;
+	}
 
+	my $rules;
+	eval { $rules = parse_fw_rule($line, 0, 0); };
+	if (my $err = $@) {
+	    warn "$prefix: $err";
+	    next;
 	}
 
+	push @{$res->{$group}->{$section}}, @$rules;
+    }
+
+    return $res;
+}
 
-	my $rule = {
-	    action => $action,
-	    service => $service,
-	    iface => $iface,
-	    source => $source,
-	    dest => $dest,
-	    proto => $proto,
-	    dport => $dport,
-	    sport => $sport,
-	};
+sub run_locked {
+    my ($code, @param) = @_;
 
-	push @{$res->{$section}}, $rule;
-    }
+    my $timeout = 10;
+
+    my $res = lock_file($pve_fw_lock_filename, $timeout, $code, @param);
+
+    die $@ if $@;
 
     return $res;
 }
@@ -532,7 +1095,6 @@ sub read_local_vm_config {
     my $list = PVE::QemuServer::config_list();
 
     foreach my $vmid (keys %$list) {
-	#next if !($vmid eq '100' || $vmid eq '102');
 	my $cfspath = PVE::QemuServer::cfs_config_path($vmid);
 	if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
 	    $qemu->{$vmid} = $conf;
@@ -552,34 +1114,216 @@ sub read_vm_firewall_rules {
 	my $fh = IO::File->new($filename, O_RDONLY);
 	next if !$fh;
 
-	$rules->{$vmid} = parse_fw_rules($filename, $fh);
+	$rules->{$vmid} = parse_vm_fw_rules($filename, $fh);
     }
 
     return $rules;
 }
 
 sub compile {
-
     my $vmdata = read_local_vm_config();
     my $rules = read_vm_firewall_rules($vmdata);
+    
+    my $group_rules = {};
+    my $filename = "/etc/pve/firewall/groups.fw";
+    if (my $fh = IO::File->new($filename, O_RDONLY)) {
+	$group_rules = parse_group_fw_rules($filename, $fh);
+    }
+
+    #print Dumper($rules);
+
+    my $ruleset = {};
+
+    ruleset_create_chain($ruleset, "PVEFW-INPUT");
+    ruleset_create_chain($ruleset, "PVEFW-OUTPUT");
+    ruleset_create_chain($ruleset, "PVEFW-FORWARD");
 
-    # print Dumper($vmdata);
+    ruleset_create_chain($ruleset, "PVEFW-SET-ACCEPT-MARK");
+    ruleset_addrule($ruleset, "PVEFW-SET-ACCEPT-MARK", "-j MARK --set-mark 1");
 
-    my $swdir = '/etc/shorewall';
-    mkdir $swdir;
+    my $enable_hostfw = 0;
+    $filename = "/etc/pve/local/host.fw";
+    if (my $fh = IO::File->new($filename, O_RDONLY)) {
+	my $host_rules = parse_host_fw_rules($filename, $fh);
 
-    &$compile_shorewall($swdir, $vmdata, $rules);
+	$enable_hostfw = 1;
 
-    PVE::Tools::run_command(['shorewall', 'compile']);
+	enablehostfw($ruleset, $host_rules, $group_rules);
+    }
+
+    # generate firewall rules for QEMU VMs 
+    foreach my $vmid (keys %{$vmdata->{qemu}}) {
+	my $conf = $vmdata->{qemu}->{$vmid};
+	my $vmfw_conf = $rules->{$vmid};
+	next if !$vmfw_conf;
+	next if defined($vmfw_conf->{options}->{enable}) && ($vmfw_conf->{options}->{enable} == 0);
+
+	foreach my $netid (keys %$conf) {
+	    next if $netid !~ m/^net(\d+)$/;
+	    my $net = PVE::QemuServer::parse_net($conf->{$netid});
+	    next if !$net;
+	    my $iface = "tap${vmid}i$1";
+
+	    my $bridge = $net->{bridge};
+	    next if !$bridge; # fixme: ?
+
+	    $bridge .= "v$net->{tag}" if $net->{tag};
+
+
+	    generate_bridge_chains($ruleset, $bridge);
+
+	    my $macaddr = $net->{macaddr};
+	    generate_tap_rules_direction($ruleset, $group_rules, $iface, $netid, $macaddr, $vmfw_conf, $bridge, 'IN');
+	    generate_tap_rules_direction($ruleset, $group_rules, $iface, $netid, $macaddr, $vmfw_conf, $bridge, 'OUT');
+	}
+    }
+
+    if ($enable_hostfw) {
+	# allow traffic from lo (ourself)
+	ruleset_addrule($ruleset, "PVEFW-INPUT", "-i lo -j ACCEPT");
+    }
+
+    return $ruleset;
+}
+
+sub get_ruleset_status {
+    my ($ruleset, $verbose) = @_;
+
+    my $active_chains = iptables_get_chains();
+
+    my $statushash = {};
+
+    foreach my $chain (sort keys %$ruleset) {
+	my $digest = Digest::SHA->new('sha1');
+	foreach my $cmd (@{$ruleset->{$chain}}) {
+	     $digest->add("$cmd\n");
+	}
+	my $sig = $digest->b64digest;
+	$statushash->{$chain}->{sig} = $sig;
+
+	my $oldsig = $active_chains->{$chain};
+	if (!defined($oldsig)) {
+	    $statushash->{$chain}->{action} = 'create';
+	} else {
+	    if ($oldsig eq $sig) {
+		$statushash->{$chain}->{action} = 'exists';
+	    } else {
+		$statushash->{$chain}->{action} = 'update';
+	    }
+	}
+	print "$statushash->{$chain}->{action} $chain ($sig)\n" if $verbose;
+	foreach my $cmd (@{$ruleset->{$chain}}) {
+	    print "\t$cmd\n" if $verbose;
+	}
+    }
+
+    foreach my $chain (sort keys %$active_chains) {
+	if (!defined($ruleset->{$chain})) {
+	    my $sig = $active_chains->{$chain};
+	    $statushash->{$chain}->{action} = 'delete';
+	    $statushash->{$chain}->{sig} = $sig;
+	    print "delete $chain ($sig)\n" if $verbose;
+	}
+    }    
+
+    return $statushash;
 }
 
-sub compile_and_start {
-    my ($restart) = @_;
+sub print_ruleset {
+    my ($ruleset) = @_;
 
-    compile();
+    get_ruleset_status($ruleset, 1);
+}
+
+sub print_sig_rule {
+    my ($chain, $sig) = @_;
 
-    PVE::Tools::run_command(['shorewall', $restart ? 'restart' : 'start']);
+    # We just use this to store a SHA1 checksum used to detect changes
+    return "-A $chain -m comment --comment \"PVESIG:$sig\"\n";
 }
 
+sub apply_ruleset {
+    my ($ruleset, $verbose) = @_;
+
+    enable_bridge_firewall();
+
+    my $cmdlist = "*filter\n"; # we pass this to iptables-restore;
+
+    my $statushash = get_ruleset_status($ruleset, $verbose);
+
+    # create missing chains first
+    foreach my $chain (sort keys %$ruleset) {
+	my $stat = $statushash->{$chain};
+	die "internal error" if !$stat;
+	next if $stat->{action} ne 'create';
+
+	$cmdlist .= ":$chain - [0:0]\n";
+    }
+
+    my $rule = "INPUT -j PVEFW-INPUT";
+    if (!PVE::Firewall::iptables_rule_exist($rule)) {
+	$cmdlist .= "-A $rule\n";
+    }
+    $rule = "OUTPUT -j PVEFW-OUTPUT";
+    if (!PVE::Firewall::iptables_rule_exist($rule)) {
+	$cmdlist .= "-A $rule\n";
+    }
+
+    $rule = "FORWARD -j PVEFW-FORWARD";
+    if (!PVE::Firewall::iptables_rule_exist($rule)) {
+	$cmdlist .= "-A $rule\n";
+    }
+
+    foreach my $chain (sort keys %$ruleset) {
+	my $stat = $statushash->{$chain};
+	die "internal error" if !$stat;
+
+	if ($stat->{action} eq 'update' || $stat->{action} eq 'create') {
+	    $cmdlist .= "-F $chain\n";
+	    foreach my $cmd (@{$ruleset->{$chain}}) {
+		$cmdlist .= "$cmd\n";
+	    }
+	    $cmdlist .= print_sig_rule($chain, $stat->{sig});
+	} elsif ($stat->{action} eq 'delete') {
+	    die "internal error"; # this should not happen
+	} elsif ($stat->{action} eq 'exists') {
+	    # do nothing
+	} else {
+	    die "internal error - unknown status '$stat->{action}'";
+	}
+    }
+
+    foreach my $chain (keys %$statushash) {
+	next if $statushash->{$chain}->{action} ne 'delete';
+	$cmdlist .= "-F $chain\n";
+    }
+    foreach my $chain (keys %$statushash) {
+	next if $statushash->{$chain}->{action} ne 'delete';
+	next if $chain eq 'PVEFW-INPUT';
+	next if $chain eq 'PVEFW-OUTPUT';
+	next if $chain eq 'PVEFW-FORWARD';
+	$cmdlist .= "-X $chain\n";
+    }
+
+    $cmdlist .= "COMMIT\n";
+
+    print $cmdlist if $verbose;
+
+    iptables_restore_cmdlist($cmdlist);
+
+    # test: re-read status and check if everything is up to date 
+    $statushash = get_ruleset_status($ruleset);
+
+    my $errors;
+    foreach my $chain (sort keys %$ruleset) {
+	my $stat = $statushash->{$chain};
+	if ($stat->{action} ne 'exists') {
+	    warn "unable to update chain '$chain'\n";
+	    $errors = 1;
+	}
+    }
+
+    die "unable to apply firewall changes\n" if $errors;
+}
 
 1;