skip diabled rules and rules with errors early

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index f2f533164969c36dd587fc3c3d7ab3b75958032a..aa7de7e2c1453fb759c15e653cd1f0e585f32d8e 100644 (file)
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -1774,7 +1774,10 @@ sub enable_host_firewall {
 
     # add host rules first, so that cluster wide rules can be overwritten
     foreach my $rule (@$rules, @$cluster_rules) {
+       next if !$rule->{enable} || $rule->{errors};
+       
        $rule->{iface_in} = $rule->{iface} if $rule->{iface};
+
        eval {
            if ($rule->{type} eq 'group') {
                ruleset_add_group_rule($ruleset, $cluster_conf, $chain, $rule, 'IN', $accept_action);
@@ -1824,6 +1827,8 @@ sub enable_host_firewall {
 
     # add host rules first, so that cluster wide rules can be overwritten
     foreach my $rule (@$rules, @$cluster_rules) {
+       next if !$rule->{enable} || $rule->{errors};
+
        $rule->{iface_out} = $rule->{iface} if $rule->{iface};
        eval {
            if ($rule->{type} eq 'group') {