add comments to generated rules file

diff --git a/PVE/Firewall.pm b/PVE/Firewall.pm
index c9f502a25598daaee50978a8a0a80526881d5fd8..b0cf92da49520b67bffb8870d92832ed5942b050 100644 (file)
--- a/PVE/Firewall.pm
+++ b/PVE/Firewall.pm
@@ -229,7 +229,11 @@ sub compile {
 
     $out = sprintf($rule_format, '#ACTION', 'SOURCE', 'DEST', 'PROTO', 'DPORT', 'SPORT');
     foreach my $vmid (sort keys %$rules) {
-       if (my $inrules = $rules->{$vmid}->{in}) {
+       my $inrules = $rules->{$vmid}->{in};
+       my $outrules = $rules->{$vmid}->{out};
+
+       if (scalar(@$inrules)) {
+           $out .= "# IN to VM $vmid\n";
            foreach my $rule (@$inrules) {
                foreach my $netid (keys %{$netinfo->{$vmid}}) {
                    my $net = $netinfo->{$vmid}->{$netid};
@@ -239,7 +243,8 @@ sub compile {
            }
        }
 
-       if (my $outrules = $rules->{$vmid}->{out}) {
+       if (scalar(@$outrules)) {
+           $out .= "# OUT from VM $vmid\n";
            foreach my $rule (@$outrules) {
                foreach my $netid (keys %{$netinfo->{$vmid}}) {
                    my $net = $netinfo->{$vmid}->{$netid};