From: Daniel Krambrock via pve-devel <pve-devel@lists.proxmox.com>
Date: Tue, 16 Apr 2024 07:26:45 +0000 (+0200)
Subject: fix #5335: stable sorting in cluster.fw
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain

fix #5335: stable sorting in cluster.fw

Stable sorting in cluster.fw config file allows tracking changes by
checking into git or when using automation like ansible.

Signed-off-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
---

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 77cbaf4..81a8798 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -3360,7 +3360,7 @@ my $format_aliases = sub {
     my $raw = '';
 
     $raw .= "[ALIASES]\n\n";
-    foreach my $k (keys %$aliases) {
+    foreach my $k (sort keys %$aliases) {
 	my $e = $aliases->{$k};
 	$raw .= "$e->{name} $e->{cidr}";
 	$raw .= " # " . encode('utf8', $e->{comment})